Patch Detail
Show a patch.
GET /api/1.1/patches/25155/?format=api
{ "id": 25155, "url": "https://patchwork.libcamera.org/api/1.1/patches/25155/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25155/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251122205507.37387-4-johannes.goede@oss.qualcomm.com>", "date": "2025-11-22T20:55:07", "name": "[3/3] libcamera: egl: Fix eGLImage() constructor stride calculation", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "b8c3d6f0516dc31631b53b5c8bb6c50a4b9893d4", "submitter": { "id": 242, "url": "https://patchwork.libcamera.org/api/1.1/people/242/?format=api", "name": "Hans de Goede", "email": "johannes.goede@oss.qualcomm.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25155/mbox/", "series": [ { "id": 5605, "url": "https://patchwork.libcamera.org/api/1.1/series/5605/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5605", "date": "2025-11-22T20:55:04", "name": "GPUISP fixes", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5605/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25155/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25155/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1C0E5C3334\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 22 Nov 2025 20:55:21 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A0F4C60AA1;\n\tSat, 22 Nov 2025 21:55:20 +0100 (CET)", "from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com\n\t[205.220.180.131])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 033FE606E6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 22 Nov 2025 21:55:17 +0100 (CET)", "from pps.filterd (m0279870.ppops.net [127.0.0.1])\n\tby mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n\t5AMKPmnl3626695 for <libcamera-devel@lists.libcamera.org>;\n\tSat, 22 Nov 2025 20:55:17 GMT", "from mail-qt1-f199.google.com (mail-qt1-f199.google.com\n\t[209.85.160.199])\n\tby mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ak6cds9bg-1\n\t(version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 22 Nov 2025 20:55:16 +0000 (GMT)", "by mail-qt1-f199.google.com with SMTP id\n\td75a77b69052e-4ee42d99125so88289041cf.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 22 Nov 2025 12:55:16 -0800 (PST)", "from shalem\n\t(2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl.\n\t[2001:1c00:c32:7800:5bfa:a036:83f0:f9ec])\n\tby smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-b7655050c53sm822745966b.68.2025.11.22.12.55.13\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 22 Nov 2025 12:55:14 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=qualcomm.com header.i=@qualcomm.com\n\theader.b=\"SeyNm/Wu\"; dkim=pass (2048-bit key;\n\tunprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n\theader.b=\"Hil755mH\"; dkim-atps=neutral", "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n\tcc:content-transfer-encoding:date:from:in-reply-to:message-id\n\t:mime-version:references:subject:to; s=qcppdkim1; bh=5sMGVwnGbnv\n\tPIoikCtB+aUp3FLBN0seGy74Gac56oBQ=; b=SeyNm/Wuq3Q2kPuAgDWFgOjMTZC\n\t6AjOD6ouqH+g7d7cMADlnyo2u5BG5y4M8VgNjE7sX45XnQdvd8GIu83bkShEpvda\n\te7TQ+27eOJX2kHcBSN72yAaRhJlGuyRBSw6vnawG4aXsEK+xpofnAI/d+wF6S6L3\n\t61BzSbGpAI/Ww3ZM1DAaCFFX1uTpX0thKX+GOq29pQJVivBzxDZB0kKOLGNtkdec\n\tdro48somJbB7HIwf1bBQcjUQTgY4Uu3AIQfdAMkKN0FqBIxlD3A2YHfyNkfytxl3\n\t56IJzhj6+uEq0CVgqc0K/+v0a0KL8HLypKAd30Cv/LMQCa/WPNabUzeiHEg==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=oss.qualcomm.com; s=google; t=1763844916; x=1764449716;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=5sMGVwnGbnvPIoikCtB+aUp3FLBN0seGy74Gac56oBQ=;\n\tb=Hil755mHPyzK68zLArFlP3olyyjLfHvLk+oL8qyS3r0HtwB3ouMoVr6LGaWpiND2Yv\n\tvz9s4N+jIYEi9i0ASmbgwMZ8FYDxeM8+Ak2aO07Txj0KPkGc90CuMi21d1Q5UH1XyokD\n\t0lUTGp8+XR+xc8pVpA7GILKw1knhkVhHJyntGhbO5hQswEdEsPV/52RU8AIRnp5tXlay\n\tD6zCQLIfwlAa9tYpGRmJfKk9j/YRPcxPkI2bxmJyIVJWvLj1YbASrNpxmgeumB2ljIkA\n\t2JvwlZQktVpCTOGZMUmjG6Jtg+9bpcT040Ct9aos4kIh3uDccJplHtTDSo9vCgcpc6Rt\n\tGBbA==" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1763844916; x=1764449716;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=5sMGVwnGbnvPIoikCtB+aUp3FLBN0seGy74Gac56oBQ=;\n\tb=PtaW4ciFyPd5Wvyi00SS3HNDZ71Ie+tGZh0qTlS3YYTfJuRPhQLNiBw5aAsZ2KxWaM\n\tSXczH9BOV8Qq64YVS/N3J9/8+RfQskCMYKUZiRznuil9xYyTEs4cWXgQ7vtHKAvmVcve\n\tgtyyafotMPezjgKGbTIYJ+2MDtnj26+4KhE7h7KvUhYyiQO0z9srpwepI0ZdQvgCIQJr\n\ttSx48vbqc7uc6NhPgVw57ubTWxk0iDLFvkaLp03Y3DafFMQCoghYu3TREZdLzi+zo9+J\n\tinnJrXLk9fymD+CXdoLBB0lyXmrZHIIhWZvWkeR9VtKm3yoZWciFgqfLmT0Dm9TRpIWE\n\tVXfQ==", "X-Gm-Message-State": "AOJu0YxI9iAxnluSqCGPJWRO6fJUMSXEmah9aOnlBgjVZCFIuf2J21p5\n\tsFs81gZ3arWxvmprkVTb3cS6rzWeB2H3adAPbCtoN/F8HujAGHLLacqTm77hSvw/2mLVw9oh+dh\n\t0Hk1kwD6dbXPoqDy/TU4oLUBC63eNf3Cs0DgJrLxqRReX0/5dwpk855k9pdZ9+DDG054yr/ryw0\n\tofzKDTKwhx", "X-Gm-Gg": "ASbGncuxjfN62/2/YDhot3IoBGJfYlvethKVdrttZd664oQJapm/T5NOzoUMb/j0Scv\n\tf/sowVZF3huwNbVgJymi8/Hfq5XGuzN9J6y0z9sVXeWYbsjKpO7PbTHv1OloCCmkxrNIEdrwT/X\n\txh7dTv4a/zL7/jgodN4dvaiXGnLfh1tJA63praQ1kcGO8rHQSHhfyXRdrcwgO7glt2VOHWOEC1B\n\tGQfHd+K4kh+VsPpOXyXc3cIgm/Nh1+CPPA9WFL3XV7mZofUfHy26jzy6Ved+h2vQkIhp+arD0Tr\n\tSUmR2PF+vWQPiLdOUG+PVbSxiMVYfK1GEjhDw/Xm8CsI/QY7dSzrBZeg59k2Q9BcfN17g/z/e2Z\n\t1y3lUr9LwPZO8lmim5E4G1yfhMZeWbjy2dpde7TJwW91qmUAbjoyjG+rxdVOnQYr79j0MLO5Eic\n\t7j55eocZ0Lx3F3zxf2y9iBlZ2Z", "X-Received": [ "by 2002:a05:622a:1207:b0:4ee:1563:2829 with SMTP id\n\td75a77b69052e-4ee58b04a99mr101402161cf.72.1763844916020; \n\tSat, 22 Nov 2025 12:55:16 -0800 (PST)", "by 2002:a05:622a:1207:b0:4ee:1563:2829 with SMTP id\n\td75a77b69052e-4ee58b04a99mr101401761cf.72.1763844915343; \n\tSat, 22 Nov 2025 12:55:15 -0800 (PST)" ], "X-Google-Smtp-Source": "AGHT+IEVSOAD8w9X872h4azfrf5ZRjN32WQKK/R5ogJH8W0J82nJMRH3Qa61CdAFv3Fyr8ssAgDLdw==", "From": "Hans de Goede <johannes.goede@oss.qualcomm.com>", "To": "libcamera-devel@lists.libcamera.org,\n\tBryan O'Donoghue <bryan.odonoghue@linaro.org>", "Cc": "Hans de Goede <johannes.goede@oss.qualcomm.com>", "Subject": "[PATCH 3/3] libcamera: egl: Fix eGLImage() constructor stride\n\tcalculation", "Date": "Sat, 22 Nov 2025 21:55:07 +0100", "Message-ID": "<20251122205507.37387-4-johannes.goede@oss.qualcomm.com>", "X-Mailer": "git-send-email 2.51.1", "In-Reply-To": "<20251122205507.37387-1-johannes.goede@oss.qualcomm.com>", "References": "<20251122205507.37387-1-johannes.goede@oss.qualcomm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Authority-Analysis": "v=2.4 cv=bsdBxUai c=1 sm=1 tr=0 ts=69222334 cx=c_pps\n\ta=WeENfcodrlLV9YRTxbY/uA==:117 a=xqWC_Br6kY4A:10 a=6UeiqGixMTsA:10\n\ta=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8\n\ta=nKa267-EdcKCvconACgA:9 a=kacYvNCVWA4VmyqE58fU:22", "X-Proofpoint-ORIG-GUID": "oDnFUWblp7zHi6QdXp8Q8kmPiDjZ8peW", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjUxMTIyMDE3NCBTYWx0ZWRfX37Jw0aVs7yOr\n\tZiOP6qf4oBba1akx07DRc6BDszdNJNVIjazI1OZ6aw5gitV0wlzcer/4WYfc2wazUZHvqGVX4Zw\n\twTQ0ZnlDqAfBKe2aQc980wDg9XVbfF97SA77hmhEwrK/L9U+aHt1ya4phbenMXKUWOgWOwxS/l3\n\ty4wj8+N/oKO1NEV42hjXGCzl8NLlw6BaaKsc7f4EPtDHG4yLgd0aMS4N4Aw1ip3XCFy5mUkqD7I\n\t6wD02vKVdLCEtKTr4JkV6rW+k/wAlH3iVtc0aShSzpfC3o+bhBWn2XKXLpK9yWZxe0WVc56k3mD\n\t9JOU6l7RTga55oJF2LpHY6f95iZXjmgOGPmGE27TRmCyc+dICVc/COKfG1ZfhtMmXzdt1p1DmAR\n\tWMwcpTMPO56ft34t8PnmaCGxGd6++g==", "X-Proofpoint-GUID": "oDnFUWblp7zHi6QdXp8Q8kmPiDjZ8peW", "X-Proofpoint-Virus-Version": "vendor=baseguard\n\tengine=ICAP:2.0.293, Aquarius:18.0.1121, Hydra:6.1.9,\n\tFMLib:17.12.100.49\n\tdefinitions=2025-11-22_08,2025-11-21_01,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tmalwarescore=0 priorityscore=1501 clxscore=1015 suspectscore=0\n\tphishscore=0\n\tbulkscore=0 adultscore=0 impostorscore=0 spamscore=0\n\tlowpriorityscore=0\n\tclassifier=typeunknown authscore=0 authtc= authcc= route=outbound\n\tadjust=0\n\treason=mlx scancount=1 engine=8.22.0-2510240001\n\tdefinitions=main-2511220174", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The mimimum stride is width * bpp / 8 not width * bpp.\n\nCorrect this to fix setting the stride to a value which is\n8 times too large.\n\nSigned-off-by: Hans de Goede <johannes.goede@oss.qualcomm.com>\n---\nThis can be squashed into \"libcamera: software_isp: egl: Add a eGL base\nhelper class\"\n---\n include/libcamera/internal/egl.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/include/libcamera/internal/egl.h b/include/libcamera/internal/egl.h\nindex e61a394a..5b7cb248 100644\n--- a/include/libcamera/internal/egl.h\n+++ b/include/libcamera/internal/egl.h\n@@ -75,7 +75,7 @@ public:\n \t */\n \teGLImage(uint32_t width, uint32_t height, uint32_t bpp, GLenum texture_unit, uint32_t texture_unit_uniform_id)\n \t{\n-\t\tuint32_t stride = libcamera::utils::alignUp(width * bpp, 256);\n+\t\tuint32_t stride = libcamera::utils::alignUp(width * bpp / 8, 256);\n \n \t\tinit(width, height, bpp, stride, texture_unit, texture_unit_uniform_id);\n \t}\n", "prefixes": [ "3/3" ] }