Patch Detail
Show a patch.
GET /api/1.1/patches/25150/?format=api
{ "id": 25150, "url": "https://patchwork.libcamera.org/api/1.1/patches/25150/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25150/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251121163016.94159-1-mzamazal@redhat.com>", "date": "2025-11-21T16:30:16", "name": "[v2] libcamera: software_isp: Assign colour spaces in configurations", "commit_ref": "5a33bc10e9d3bc3a7cb1ead66c7ec0a413083d91", "pull_url": null, "state": "accepted", "archived": false, "hash": "d1d9f1c7f030cef0f5a0efc88c3e0c425bfaca17", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/1.1/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25150/mbox/", "series": [ { "id": 5603, "url": "https://patchwork.libcamera.org/api/1.1/series/5603/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5603", "date": "2025-11-21T16:30:16", "name": "[v2] libcamera: software_isp: Assign colour spaces in configurations", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5603/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25150/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25150/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E77E5C3333\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 21 Nov 2025 16:30:35 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B21CE60AA0;\n\tFri, 21 Nov 2025 17:30:35 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CCED760805\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 21 Nov 2025 17:30:33 +0100 (CET)", "from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-31-2FvTxiTWN7Sb9NT0BQ-Log-1;\n\tFri, 21 Nov 2025 11:30:26 -0500", "from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.93])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id B332F195DE7F; Fri, 21 Nov 2025 16:30:22 +0000 (UTC)", "from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.32.212])\n\tby mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id BD53818009A4; Fri, 21 Nov 2025 16:30:19 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"hkPnhQmP\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1763742632;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding;\n\tbh=4VrvobwgQXBg6CcAMlkWqBBp1AXK6P0HrvfdEZ2inN8=;\n\tb=hkPnhQmPeemj4CodyZuUaQWBsUBRtCsc2L4W7y3eI2MOjvQzCEmeRTp9lxTRpLqml9sGfH\n\t7ZntROWHSOb4jJB2E0oHV4gCyqSs43+rbaPTtJbLLsJ5zB7a4fhM7qwjJBMcqswXBzUyIU\n\t8B7mXN5TdYD7k88Ry+Lmpb56m24BA1U=", "X-MC-Unique": "2FvTxiTWN7Sb9NT0BQ-Log-1", "X-Mimecast-MFC-AGG-ID": "2FvTxiTWN7Sb9NT0BQ-Log_1763742624", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>, Kieran Bingham\n\t<kieran.bingham@ideasonboard.com>, Laurent Pinchart\n\t<laurent.pinchart@ideasonboard.com>, =?utf-8?b?QmFybmFiw6FzIFDFkWN6?=\n\t=?utf-8?q?e?= <barnabas.pocze@ideasonboard.com>, Paul Elder\n\t<paul.elder@ideasonboard.com>, Umang Jain <uajain@igalia.com>,\n\tIsaac Scott <isaac.scott@ideasonboard.com>", "Subject": "[PATCH v2] libcamera: software_isp: Assign colour spaces in\n\tconfigurations", "Date": "Fri, 21 Nov 2025 17:30:16 +0100", "Message-ID": "<20251121163016.94159-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.93", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "vGkd_GB4hkuTPbaQDWfRSzGJA-Fp2FvEPHg3YyRfGgk_1763742624", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "StreamConfiguration's should have colorSpace set. This is not the case\nin the simple pipeline. Let's set it there. This also fixes a crash in\n`cam' due to accessing an unset colorSpace.\n\nWe set the colour spaces according to the pixel format. This is not\ncompletely correct because pixel formats and colour spaces are\ndifferent, although not completely independent, things. But for the\nlack of a better practical option to determine the colour space, we use\nthis.\n\nCloses: https://gitlab.freedesktop.org/camera/libcamera/-/issues/294\nReviewed-by: Isaac Scott <isaac.scott@ideasonboard.com>\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/libcamera/pipeline/simple/simple.cpp | 40 ++++++++++++++++++++++++\n 1 file changed, 40 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 118b4186c..c0d938cf0 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -25,6 +25,7 @@\n #include <libcamera/base/log.h>\n \n #include <libcamera/camera.h>\n+#include <libcamera/color_space.h>\n #include <libcamera/control_ids.h>\n #include <libcamera/request.h>\n #include <libcamera/stream.h>\n@@ -36,6 +37,7 @@\n #include \"libcamera/internal/converter.h\"\n #include \"libcamera/internal/delayed_controls.h\"\n #include \"libcamera/internal/device_enumerator.h\"\n+#include \"libcamera/internal/formats.h\"\n #include \"libcamera/internal/global_configuration.h\"\n #include \"libcamera/internal/media_device.h\"\n #include \"libcamera/internal/pipeline_handler.h\"\n@@ -1227,6 +1229,44 @@ CameraConfiguration::Status SimpleCameraConfiguration::validate()\n \t\t\tstatus = Adjusted;\n \t\t}\n \n+\t\t/*\n+\t\t * Best effort to fix the color space. If the color space is not set,\n+\t\t * set it according to the pixel format, which may not be correct (pixel\n+\t\t * formats and color spaces are different things, although somewhat\n+\t\t * related) but we don't have a better option at the moment. Then in any\n+\t\t * case, perform the standard pixel format based color space adjustment.\n+\t\t */\n+\t\tif (!cfg.colorSpace) {\n+\t\t\tconst PixelFormatInfo &info = PixelFormatInfo::info(pixelFormat);\n+\t\t\tswitch (info.colourEncoding) {\n+\t\t\tcase PixelFormatInfo::ColourEncodingRGB:\n+\t\t\t\tcfg.colorSpace = ColorSpace::Srgb;\n+\t\t\t\tbreak;\n+\t\t\tcase PixelFormatInfo::ColourEncodingYUV:\n+\t\t\t\tcfg.colorSpace = ColorSpace::Sycc;\n+\t\t\t\tbreak;\n+\t\t\tdefault:\n+\t\t\t\tcfg.colorSpace = ColorSpace::Raw;\n+\t\t\t}\n+\t\t\tLOG(SimplePipeline, Debug)\n+\t\t\t\t<< \"Unspecified color space set to \"\n+\t\t\t\t<< cfg.colorSpace.value().toString();\n+\t\t\t/*\n+\t\t\t * Adjust the assigned color space to make sure everything is OK.\n+\t\t\t * Since this is assigning an unspecified color space rather than\n+\t\t\t * adjusting a requested one, changes here shouldn't set the status\n+\t\t\t * to Adjusted.\n+\t\t\t */\n+\t\t\tcfg.colorSpace->adjust(pixelFormat);\n+\t\t} else {\n+\t\t\tif (cfg.colorSpace->adjust(pixelFormat)) {\n+\t\t\t\tLOG(SimplePipeline, Debug)\n+\t\t\t\t\t<< \"Color space adjusted to \"\n+\t\t\t\t\t<< cfg.colorSpace.value().toString();\n+\t\t\t\tstatus = Adjusted;\n+\t\t\t}\n+\t\t}\n+\n \t\tif (!pipeConfig_->outputSizes.contains(cfg.size)) {\n \t\t\tSize adjustedSize = pipeConfig_->captureSize;\n \t\t\t/*\n", "prefixes": [ "v2" ] }