Patch Detail
Show a patch.
GET /api/1.1/patches/25138/?format=api
{ "id": 25138, "url": "https://patchwork.libcamera.org/api/1.1/patches/25138/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25138/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251120233347.5046-15-bryan.odonoghue@linaro.org>", "date": "2025-11-20T23:33:38", "name": "[v4,14/23] libcamera: software_isp: debayer_cpu: Make getInputConfig and getOutputConfig static", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "4332d9c2287e66c06675e1d2dd88742998b215e1", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/1.1/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25138/mbox/", "series": [ { "id": 5600, "url": "https://patchwork.libcamera.org/api/1.1/series/5600/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5600", "date": "2025-11-20T23:33:24", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 4, "mbox": "https://patchwork.libcamera.org/series/5600/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25138/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25138/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B8E88BD80A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 20 Nov 2025 23:34:22 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5D7F960B0B;\n\tFri, 21 Nov 2025 00:34:22 +0100 (CET)", "from mail-wm1-x334.google.com (mail-wm1-x334.google.com\n\t[IPv6:2a00:1450:4864:20::334])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B83D260A9E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 21 Nov 2025 00:34:19 +0100 (CET)", "by mail-wm1-x334.google.com with SMTP id\n\t5b1f17b1804b1-4779aa4f928so13903275e9.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 20 Nov 2025 15:34:19 -0800 (PST)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-42cb7fa3a81sm7984139f8f.26.2025.11.20.15.34.17\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 20 Nov 2025 15:34:17 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"iomcvW2P\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1763681659; x=1764286459;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=U4gZBzqGbQfvRAdn9kIktQq170/k2VAqruGy17o40mc=;\n\tb=iomcvW2PZSqpWl99asYmYACa/mZ6kGkSWbPfr1mQQBOetAm9p+vuIYIQD2TZjDzJQ5\n\t+fkhcGKj+xgtZvgYnMlZ3tgPtsVG1Wfx+PrYFnOY6BgbH5l6W9RX94NWa2RveUdkGSPc\n\tyQxWogYDnJRjLaB0grbRSU3tKE5TYuQpDGWhmE1vuDJZet2pPare5gEOo7CsTHZ6LoPW\n\tpC19CsXcgbqCBoG8r1JM/0e9z8toAQnBxKoTCJ4uE+/W/783IuKyBMl48QlLMarLU3//\n\tsoYb4QHWGUEmpo2u/fXBrf1/kkyVfTL9d7V6ZObUgTBhO597lgwqu6lIsdRLxGuBSEQE\n\ttjhQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1763681659; x=1764286459;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=U4gZBzqGbQfvRAdn9kIktQq170/k2VAqruGy17o40mc=;\n\tb=pUsvD0IjL/K+EO8eaKMIXLtaOjTvsNSYHqCK+YOu86hWZGeQCseCDAg7PfGUwh3lkt\n\tIEhXX2EJyx99yG0lMt/MJYA7/saggrmzcvBptLV+9kB817RbfmKAO3c8BIvxG8HMnTTI\n\tsbPF5kH//HZ2rUo1fBvHN+eM1qn3GkGw362UbyvWcERR/L3ke5YGNVFpUuatzCQMOSg9\n\t2cK7PsOreVdR5nPdxliT87reD1AxemBHFw0OfyfkdSPuW8G0IorlhRBNMKB+cvmf/7ar\n\t4TIfyGj/G+L5TM+08SWjwqeu4ZgBByQio0bR/B9DVPZwOe0MAAc+d4JkNT8KRVy0vMyQ\n\tLBPA==", "X-Gm-Message-State": "AOJu0YwymB107nCnPUdMbKfXB9eWNbE+qNW2d3OseoZN3pJM5z6IZWs8\n\tBMK6jvyJl0L42I9rcTtWfXdETWuBescXHRS+vJ6v2DXYy/V4ttVShouD7bsDa+EdtRQ2cBq2KdS\n\t2xCWwdnY=", "X-Gm-Gg": "ASbGncuTXmEp0gKFs5lDL4Sz39/OtlunN+1SaPEWVN1ZYPH6xyZlNu2a4AEBFBGQDAY\n\tHBRSvpyzgcDMnlys+j9jUGezk1/BKARwKbtFILXQR/RoPBfyLTJEGs7CKyXiFgOYQCR9zxG5EHJ\n\tTRHzhmS+RVcb7fbSD4zFThzB3/sNBYawM+UMV7yluYJfZhh+J4gQABXV2wL+3pRTcaInwoJMMUQ\n\tGBkxxE3SAMawiXXqHqs5N7sRjcb8eSyZf+BwKX1STWLsSVmNXY8caFG8uwVDdDq8jRAMU0NizDG\n\tuVkBkHmbfN4vCnHJ1hIvmRt3O4KyZJCLw2KupO+KVFl79Jyw8hLtLXir5YU/jblrispzC02RtWG\n\tclhkJ+xM7aUHDDQrbOiTF2ouIcIJN0VcOuYZ7ZmQwysR8xfBIbHTRkpLx5r6f8eX4me7QeCi1YW\n\tYXjY28/9ffuX/eVfGZY6J5nxNhN5hf5KWjH0NTjngna8qpgRonMOZj1KEzbVQP4n5XCVQ=", "X-Google-Smtp-Source": "AGHT+IHHhEiVs7+Pxy6H5m+Lik7EgWWji3ChGHb8KMZJsQQ5PHzSdmIoLZDHuonNghWtGknp0VtZnQ==", "X-Received": "by 2002:a05:600c:19d2:b0:476:4efc:8ed4 with SMTP id\n\t5b1f17b1804b1-477c0184965mr3221425e9.11.1763681659053; \n\tThu, 20 Nov 2025 15:34:19 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz, Bryan O'Donoghue <bryan.odonoghue@linaro.org>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v4 14/23] libcamera: software_isp: debayer_cpu: Make\n\tgetInputConfig and getOutputConfig static", "Date": "Thu, 20 Nov 2025 23:33:38 +0000", "Message-ID": "<20251120233347.5046-15-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.51.2", "In-Reply-To": "<20251120233347.5046-1-bryan.odonoghue@linaro.org>", "References": "<20251120233347.5046-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Make getInputConfig and getOutputConfig static so as to allow for\ninterrogation of the supported pixel formats prior to object instantiation.\nDo this so as to allow the higher level logic make an informed choice\nbetween CPU and GPU ISP based on which pixel formats are supported.\n\nCurrently CPU ISP supports more diverse input and output schemes.\n\nAcked-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/software_isp/debayer_cpu.h | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/software_isp/debayer_cpu.h b/src/libcamera/software_isp/debayer_cpu.h\nindex 2d385cf01..a395fc97c 100644\n--- a/src/libcamera/software_isp/debayer_cpu.h\n+++ b/src/libcamera/software_isp/debayer_cpu.h\n@@ -98,8 +98,8 @@ private:\n \ttemplate<bool addAlphaByte, bool ccmEnabled>\n \tvoid debayer10P_RGRG_BGR888(uint8_t *dst, const uint8_t *src[]);\n \n-\tint getInputConfig(PixelFormat inputFormat, DebayerInputConfig &config);\n-\tint getOutputConfig(PixelFormat outputFormat, DebayerOutputConfig &config);\n+\tstatic int getInputConfig(PixelFormat inputFormat, DebayerInputConfig &config);\n+\tstatic int getOutputConfig(PixelFormat outputFormat, DebayerOutputConfig &config);\n \tint setupStandardBayerOrder(BayerFormat::Order order);\n \tint setDebayerFunctions(PixelFormat inputFormat,\n \t\t\t\tPixelFormat outputFormat,\n", "prefixes": [ "v4", "14/23" ] }