Patch Detail
Show a patch.
GET /api/1.1/patches/25133/?format=api
{ "id": 25133, "url": "https://patchwork.libcamera.org/api/1.1/patches/25133/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25133/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251120233347.5046-10-bryan.odonoghue@linaro.org>", "date": "2025-11-20T23:33:33", "name": "[v4,09/23] libcamera: shaders: Add support for Gamma", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "8c685f7220a7a85931d0be3a2912a9da5a8fef42", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/1.1/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25133/mbox/", "series": [ { "id": 5600, "url": "https://patchwork.libcamera.org/api/1.1/series/5600/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5600", "date": "2025-11-20T23:33:24", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 4, "mbox": "https://patchwork.libcamera.org/series/5600/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25133/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25133/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3FE07BD80A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 20 Nov 2025 23:34:13 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C2B5D60AB1;\n\tFri, 21 Nov 2025 00:34:12 +0100 (CET)", "from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com\n\t[IPv6:2a00:1450:4864:20::42c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B74F560A8A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 21 Nov 2025 00:34:09 +0100 (CET)", "by mail-wr1-x42c.google.com with SMTP id\n\tffacd0b85a97d-42b31c610fcso1230216f8f.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 20 Nov 2025 15:34:09 -0800 (PST)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-42cb7fa3a81sm7984139f8f.26.2025.11.20.15.34.07\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 20 Nov 2025 15:34:07 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"Wv3AWEi1\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1763681649; x=1764286449;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=suq5XMZu0qhDPnhx2EUi5HyBXr7OCjnwhdm8i1aWyHM=;\n\tb=Wv3AWEi1xY+eJUeom6gFKowaKJmWXX9fe/N/wEdYNW937Q35cR5hzgPpofpaARnoUc\n\tS3Qs23kVDtmLQKw+bKowslq23vx/lnnPjhSJb8AR8NtG3xZh6vFjRvx/RiE09WgfgEd3\n\tfCXhR7dOC1B2ZLvaNf6kFvrO+Vp31+Gq3RN8b8jZg5zZ7G5cRJt56i+yRoidF1McRUaX\n\t3kl8QmGuEPa/LXeL6obU4Si2lkFBH9L9Y+wpsO/THuPar8a7Z7e6woPcYM9Ctl7XAR/y\n\tNDBxiWBV83VMD7h6lK7QiW7ONNKsrK6qc936GliH4+b22xt8lXuhndDWgZ0zyWCalOw+\n\t35hw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1763681649; x=1764286449;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=suq5XMZu0qhDPnhx2EUi5HyBXr7OCjnwhdm8i1aWyHM=;\n\tb=Vaw+REP1UD+jp+iHmhDXRj3KqM91TWVFKPEIjM1cDnJLJQiAZ8FoY6b8uyZMTFC6tq\n\ttUoCGB3tHzPzLqjctulRqFgMqR4Eyze0gXO8/zH2amTZjYD+yzleDPBlpkOIyWQw71jO\n\tug4ti0A+qW0VQxGTMYAxP1kHcMgJkkKUHQe482pqJ/Q5IHZzhPYXIJC7zSFjZQqDNYXI\n\tiL/N4rhhu7FYopgFpt7hP+ubNqvewoOKE7AGZg32JeBXAuCu7Oj6bm59/4qAE1cnnXWH\n\toxS1xCqGCshMgESE3ZVDtZp7BVZUFe6ok7MYa6Le8GIY9xzfQKNemgGznx4PqTbD26vM\n\tAogg==", "X-Gm-Message-State": "AOJu0Yzq+Fi9EGcFPfRs3ZRCGsH9YoVZA8lB/ok7n4Ffg6K8Gu9DVN7/\n\tazeMltvNdMUbKRmL8g5CZ3rjG8jTVUbXSP7Ae2NLaCeiiE9U7RPvaTrrRUQzivX1vYrmz/fZBc0\n\tyJvO0oJs=", "X-Gm-Gg": "ASbGnct8A4ql2BxdZefWTwooMq9GMY9bA4lTeM4Q/dh7fRm+iKr8H7nOHN47Mn34PWC\n\tRQ4ECbqubSrD3AcYkK9oM/yM4QBQeS8PxvPSqDjrm/5qQ+G6vdssQFP71yeB0ognMv5aMzb5Ygz\n\tqBYTAwae89tX0RWfcrzt6TFrw+aDRVHfY1rSI9GlL+p4nduoKweZgMmud8UZ8tpXV6qQllHnImM\n\tgYPp45d4wLJrAPMXDRVlDKm384R2o+HoOtn5Od6yQlmqPIdlLmGkFH6uuyhZ5Rog3X6/IAErwCl\n\tUlxwV5YBd9qXYI8fOUGyrCdFrjZpnSN8JF+WM1m46/o7n/nH8Mz15HNEMAIZf7K/UysCgnr9rAY\n\t4gIMJFfx3oh+R+IuDAaDpGsuCwJmDu2LgYwo0E4/kQgw94U/wbidd0EZw9lBgXHVQIiy1Kz4PQA\n\tNARJbSEG8eKGfvoVoH/ImXoB6eNkP83d/R5gc2fKjrf+r6Lz7XvOAY9DqUI9x8HTTHKv8=", "X-Google-Smtp-Source": "AGHT+IGvvPlhCTahDkElwU2H00SFfjpQXLJaaMWSkfr7p6Fweyasl5rfR04ivoIjgW/ok4TPImS9tg==", "X-Received": "by 2002:a05:6000:2f86:b0:42b:32a0:3490 with SMTP id\n\tffacd0b85a97d-42cc1d19ed4mr87002f8f.49.1763681649078; \n\tThu, 20 Nov 2025 15:34:09 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz, Bryan O'Donoghue <bryan.odonoghue@linaro.org>,\n\tMilan Zamazal <mzamazal@redhat.com>", "Subject": "[PATCH v4 09/23] libcamera: shaders: Add support for Gamma", "Date": "Thu, 20 Nov 2025 23:33:33 +0000", "Message-ID": "<20251120233347.5046-10-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.51.2", "In-Reply-To": "<20251120233347.5046-1-bryan.odonoghue@linaro.org>", "References": "<20251120233347.5046-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add gamma compentation to the debayer shaders after colour correction is\napplied.\n\nSimilarly only apply the calculated Gamma curve when using the CCM as the\nlookup tables already contain the data.\n\nSuggested-by: Milan Zamazal <mzamazal@redhat.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n include/libcamera/internal/shaders/bayer_1x_packed.frag | 4 ++++\n include/libcamera/internal/shaders/bayer_unpacked.frag | 4 ++++\n 2 files changed, 8 insertions(+)", "diff": "diff --git a/include/libcamera/internal/shaders/bayer_1x_packed.frag b/include/libcamera/internal/shaders/bayer_1x_packed.frag\nindex 6bca07b6e..069b880ff 100644\n--- a/include/libcamera/internal/shaders/bayer_1x_packed.frag\n+++ b/include/libcamera/internal/shaders/bayer_1x_packed.frag\n@@ -70,6 +70,7 @@ uniform sampler2D green_param;\n uniform sampler2D blue_param;\n uniform mat3 ccm;\n uniform vec3 blacklevel;\n+uniform float gamma;\n \n void main(void)\n {\n@@ -265,6 +266,9 @@ void main(void)\n \trgb.g = (rin * ccm[1][0]) + (gin * ccm[1][1]) + (bin * ccm[1][2]);\n \trgb.b = (rin * ccm[2][0]) + (gin * ccm[2][1]) + (bin * ccm[2][2]);\n \n+\t/* Apply gamma after colour correction */\n+\trgb = pow(rgb, vec3(gamma));\n+\n #elif defined(APPLY_RGB_PARAMETERS)\n \t/* Apply bayer params */\n \trgb.r = texture2D(red_param, vec2(rgb.r, 0.5)).r;\ndiff --git a/include/libcamera/internal/shaders/bayer_unpacked.frag b/include/libcamera/internal/shaders/bayer_unpacked.frag\nindex ae214a9ae..950a4733e 100644\n--- a/include/libcamera/internal/shaders/bayer_unpacked.frag\n+++ b/include/libcamera/internal/shaders/bayer_unpacked.frag\n@@ -29,6 +29,7 @@ varying vec4 yCoord;\n varying vec4 xCoord;\n uniform mat3\t\tccm;\n uniform vec3\t\tblacklevel;\n+uniform float\t\tgamma;\n \n void main(void) {\n vec3 rgb;\n@@ -160,6 +161,9 @@ void main(void) {\n \trgb.g = (rin * ccm[1][0]) + (gin * ccm[1][1]) + (bin * ccm[1][2]);\n \trgb.b = (rin * ccm[2][0]) + (gin * ccm[2][1]) + (bin * ccm[2][2]);\n \n+\t/* Apply gamma after colour correction */\n+\trgb = pow(rgb, vec3(gamma));\n+\n #elif defined(APPLY_RGB_PARAMETERS)\n \t/* Apply bayer params */\n \trgb.r = texture2D(red_param, vec2(rgb.r, 0.5)).r;\n", "prefixes": [ "v4", "09/23" ] }