Patch Detail
Show a patch.
GET /api/1.1/patches/25131/?format=api
{ "id": 25131, "url": "https://patchwork.libcamera.org/api/1.1/patches/25131/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25131/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251120233347.5046-8-bryan.odonoghue@linaro.org>", "date": "2025-11-20T23:33:31", "name": "[v4,07/23] libcamera: shaders: Extend bayer shaders to support swapping R and B on output", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "bfb7a41c09ebf92347a53894034f4b5947679234", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/1.1/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25131/mbox/", "series": [ { "id": 5600, "url": "https://patchwork.libcamera.org/api/1.1/series/5600/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5600", "date": "2025-11-20T23:33:24", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 4, "mbox": "https://patchwork.libcamera.org/series/5600/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25131/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25131/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1369DBD80A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 20 Nov 2025 23:34:09 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C2B8560AB1;\n\tFri, 21 Nov 2025 00:34:08 +0100 (CET)", "from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com\n\t[IPv6:2a00:1450:4864:20::32a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2D73660A8B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 21 Nov 2025 00:34:06 +0100 (CET)", "by mail-wm1-x32a.google.com with SMTP id\n\t5b1f17b1804b1-4779aa4f928so13902015e9.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 20 Nov 2025 15:34:06 -0800 (PST)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-42cb7fa3a81sm7984139f8f.26.2025.11.20.15.34.02\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 20 Nov 2025 15:34:04 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"No9sczOh\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1763681645; x=1764286445;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=Ftr53nnZFbN48TlKdqsyBREu/6cYVA4gRslhx9V2PI8=;\n\tb=No9sczOhtJmp564JYv22mwUy9omlno3R3ToKxZYy7rz36uPjVTLQuLXo2YLrCxX9D5\n\tSuFYXnI3irIA/VNSuQ4S/dkihQR1URTJjfJy1vYMeeIrNJHghPrXELz/oWGKeZJsKLHI\n\t4eErwzFmUFD+OFn+vk5iQrRUxPb/U2/esnHpIbqhe9V1JoZ12xqjjMPosJt+nE/BUuck\n\tvkMelK9pQJZDaL6mcrK+Lrh02on7jWYg9Y6hOExp4pLQF9fxLm6oJyXSnqiAyKamE4Em\n\tLWEWsmyVa9egsnAm/MOAoiRndJ6iVMahfKKHCkXqJxc1kXHmVU/E1qFYmDmQRDpIpagf\n\tRPwg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1763681645; x=1764286445;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=Ftr53nnZFbN48TlKdqsyBREu/6cYVA4gRslhx9V2PI8=;\n\tb=tBOY4oSguEZVbyJ5t7frS2lJdCMJerbRrg/oHCxALwUQUTeVo8onBeHqZWLLfBr4E6\n\tycEK5Y0O2xtwfnv5j42U5EQBgkk/u2ytgH6/fSDiypDHetmuk7JorwgChZ9y9/V0Rn6w\n\tODd8Bg9honoW2fXs9+uUcIJvxnkBqujAfV6zvD1/wMjkIxBqxKfdzBJHSVuH+XP9C/cQ\n\twJl5Y2j6Q4VRlnS/puVb+nLP+3R0ESwJFO6ZK/4H14oXWidgH9Wji//rG/amntYbn21/\n\tdSm3mwrN2kw8Y5VkZyLxQXliCcln3fAFza4NMtz1xhVwtYXQVf669Vfk772ltMC3kEsk\n\t05sw==", "X-Gm-Message-State": "AOJu0YwlDGfRnhastuGwDN9UOQN0jpTLMsHk8j69M2obYSmEizNF5S9N\n\tWExWSgpyfAdK/lxobHFMlxhHP0l/IKYuDKRdxaDhRqQwkvoOZHsElkZe52hPyyV+uc0TZZSq2sx\n\tRHKAh2bk=", "X-Gm-Gg": "ASbGncvryXEeGDkeLKdToi9jL8HkyZQyizaYsu9IxllCqO85/djhjxlUYbae3VFqwDM\n\tmWUgpKzfi3g3iYwgDaNmf8YfM9Mp5VKpgta2CKZIHGgmxcmh+0Oc+DvH3RAiSeBfCkafugQiURL\n\trRBjIvRy0VCqg5aj9cow/TDtnv2OvPrNW0p07ehjRcauZFmLSO4kC/Y/q1VICRlDl2lyzKo/jl3\n\t1WKnhe+4nF+2RfvRdDMoAbcI9Te47L+bXHyQw+sxXcQHvj26jtVPohpVZwO1ojAJXeJTOWlD14U\n\ti9F9iTKqE285wDE31TxRe0Sw5zBz0X2YAaY/iHOWzLSO0+A3csdBp3uFYotDx+qDp/mVg5V242X\n\tRLLnU/Q/FInKz4guR50rzjz4MyIN6dXGOOx+FNXtN/evMNf0rR1oVvTJLfsPScCeRB9ZoG34VQL\n\t/hy/ckYorc+zL4XwMFh4q61NPzTx8U7z5yI+tBVFRbn9ivjxBGN+cH8CZbJ2CRyQCkT2U=", "X-Google-Smtp-Source": "AGHT+IEVkcdjtGpUOagEpkIKZMk9mBXMBmpv5g3wo6+3WuibeHByLVGZKfZkhAdi7dzdH4X7m62bHw==", "X-Received": "by 2002:a05:6000:401e:b0:425:8bc2:9c43 with SMTP id\n\tffacd0b85a97d-42cc1ac93a2mr115331f8f.1.1763681645422; \n\tThu, 20 Nov 2025 15:34:05 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz, Bryan O'Donoghue <bryan.odonoghue@linaro.org>,\n\tMilan Zamazal <mzamazal@redhat.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v4 07/23] libcamera: shaders: Extend bayer shaders to support\n\tswapping R and B on output", "Date": "Thu, 20 Nov 2025 23:33:31 +0000", "Message-ID": "<20251120233347.5046-8-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.51.2", "In-Reply-To": "<20251120233347.5046-1-bryan.odonoghue@linaro.org>", "References": "<20251120233347.5046-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "We can easily facilitate swapping R and B on output. Pivot on an\nenvironment define for this purpose.\n\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nAcked-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n include/libcamera/internal/shaders/bayer_1x_packed.frag | 4 ++++\n include/libcamera/internal/shaders/bayer_unpacked.frag | 6 +++++-\n 2 files changed, 9 insertions(+), 1 deletion(-)", "diff": "diff --git a/include/libcamera/internal/shaders/bayer_1x_packed.frag b/include/libcamera/internal/shaders/bayer_1x_packed.frag\nindex 90bd64570..c0632eb1f 100644\n--- a/include/libcamera/internal/shaders/bayer_1x_packed.frag\n+++ b/include/libcamera/internal/shaders/bayer_1x_packed.frag\n@@ -268,5 +268,9 @@ void main(void)\n \trgb.b = texture2D(blue_param, vec2(rgb.b, 0.5)).b;\n #endif\n \n+#if defined (SWAP_BLUE)\n+\tgl_FragColor = vec4(rgb.bgr, 1.0);\n+#else\n \tgl_FragColor = vec4(rgb, 1.0);\n+#endif\n }\ndiff --git a/include/libcamera/internal/shaders/bayer_unpacked.frag b/include/libcamera/internal/shaders/bayer_unpacked.frag\nindex 7c3d12b03..b545fbbdc 100644\n--- a/include/libcamera/internal/shaders/bayer_unpacked.frag\n+++ b/include/libcamera/internal/shaders/bayer_unpacked.frag\n@@ -163,5 +163,9 @@ void main(void) {\n \trgb.b = texture2D(blue_param, vec2(rgb.b, 0.5)).b;\n #endif\n \n- gl_FragColor.rgb = rgb;\n+#if defined (SWAP_BLUE)\n+\tgl_FragColor = vec4(rgb.bgr, 1.0);\n+#else\n+\tgl_FragColor = vec4(rgb, 1.0);\n+#endif\n }\n", "prefixes": [ "v4", "07/23" ] }