Patch Detail
Show a patch.
GET /api/1.1/patches/25120/?format=api
{ "id": 25120, "url": "https://patchwork.libcamera.org/api/1.1/patches/25120/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25120/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251120232019.3590-20-bryan.odonoghue@linaro.org>", "date": "2025-11-20T23:20:16", "name": "[19/22] libcamera: software_isp: lut: Make CCM available in debayer params", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "2457bf8966f2e8c9d334d3fb284d516d10d02d67", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/1.1/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25120/mbox/", "series": [ { "id": 5599, "url": "https://patchwork.libcamera.org/api/1.1/series/5599/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5599", "date": "2025-11-20T23:19:57", "name": "GPUISP precursor series", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5599/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25120/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25120/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3852CC3330\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 20 Nov 2025 23:21:01 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CBB5260B31;\n\tFri, 21 Nov 2025 00:21:00 +0100 (CET)", "from mail-wr1-x432.google.com (mail-wr1-x432.google.com\n\t[IPv6:2a00:1450:4864:20::432])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6D72E60B2F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 21 Nov 2025 00:20:58 +0100 (CET)", "by mail-wr1-x432.google.com with SMTP id\n\tffacd0b85a97d-42b3377aaf2so813959f8f.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 20 Nov 2025 15:20:58 -0800 (PST)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-477bf3af0ecsm11618415e9.9.2025.11.20.15.20.55\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 20 Nov 2025 15:20:56 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"qQ1zSuHQ\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1763680858; x=1764285658;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=Q72Mq/ODDFKHXLOJoLvTa+pTSd+VTsB7EmzhQuxUCGI=;\n\tb=qQ1zSuHQrdFwWiS4CywnBK52zeO6BX/dPRtJIexmg8uqx0gz1pmp5q9au3I3XkFg1H\n\tNq1HffEXUT3pKZPP3HzDEhovJQTCdOfLCyXkSovyFl3Os4PJwMllj70P6qExbdN9Dyqw\n\tZ8IGihmo7hTCLqFYwJHk8Cjk6qvYezTyg6Kj/KiH/FfToTyMG1zod/+Hb1EaN5qfqH5l\n\ta+f8yM7eBxSVjst+ntgRRwVjA8iegF5G1McHMhOHVxnHuRMQYms5gRX75eYof3hE1TlE\n\tejmBQb+mBcn+KWbqalLIyUIGX9D+Iff42coTdO1Npu/Ql/xlyotIM6vp1Hggkd59na6T\n\tGVNg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1763680858; x=1764285658;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=Q72Mq/ODDFKHXLOJoLvTa+pTSd+VTsB7EmzhQuxUCGI=;\n\tb=nUVo4YpW7eyQoTOtaoeXEG9xWnG6p4gaDx+tR57UM6oodrBFEQpusekjHU39SVYMJx\n\te7K0C07Ri/UrgibW0cuKKIxug0mhjL5+iQYxFrburA1jJ99wl1okIxruHCL7bgpvXvCe\n\tc9D6UJfvlzzff5oyTLsm29rbwTNI8BinUUbN01VJn6R7VIoIJ0u0vDxtL7IqV9kba+5i\n\taYQtXq/oHa6MfHYbGRSPzn5OfwfhIYZOjwYNY6VTugrM73JOEdZrD8Ek69xS5oqj1O8S\n\tbRB2vNgVX1LaoLClViiSvJkCqCAoDuiPltia2QWQDdAtwRboEYPqth0KTL/6ZYFQ0Pof\n\tRNhw==", "X-Gm-Message-State": "AOJu0Yz7t1IPSs7HzROi3luC/TmI6wQaHLG/M88xU1XsaIRGDObUy6dQ\n\tIff+QQx+mX0SRpaDPM8jOMSmN9L2+Az91W4cfzKv55RZzQ25jcTGQ9UCbymVRA9gofV+kohPiaM\n\tdCadGx7k=", "X-Gm-Gg": "ASbGnctPBcMMwaSHPuhRfOqIU280n2Ww0r+n8K6hnpllg38E29LCXV7Gs/2E8zaLRKB\n\tPzIO9eG5cgWAlTZaNGmfHUqkq/39lN4Byeteuza4DmW3WSb4D/MkHbqaZ1DeY4f/xQ6szAQSWt9\n\tv1HH/JjDEP6PHH2pMBN4s2/H119P/bdh5rxBcWvJcX3RPdt7UUoQrVHruUjBetz20SmNG8SVt0P\n\t4QZ57Fpn3xw2RUBfGHI2Hkbmy6acrUMwVBYLCojcGrtaqaccFFH16c4ok71nSbtWMMnCUsn8OWi\n\trcjZS/ztgJ20SPi9RhawzKWlvKozHZ2rsgaOF0/Uqje8hMeEssAgbeMBJAQbNt3yBFwn9DS1ZGL\n\tH6mWH0NGB3BtoZ7jBM0CJ7o1xC2CJwq/f5FxJh/nF8mv8lYHRTMZkOJlzzP/zDvNP3FgKsfAwi0\n\tZ6G88T8gUY7cVBZkGV5X/wmPvhk6/40QTb5IQG8mSqTeQGrVf4iVAUpAENd18aX7EHzzSyi5bBJ\n\t4pQrw==", "X-Google-Smtp-Source": "AGHT+IGr6em+UcoEmUHGX2PSVgy1Y/ZKLLYBm2RhcDpWvuQ2pmaipdpJAQncAy3M78cHMcjgcA2ypw==", "X-Received": "by 2002:a05:6000:401e:b0:427:690:1d84 with SMTP id\n\tffacd0b85a97d-42cc1d0ce5bmr76942f8f.32.1763680857721; \n\tThu, 20 Nov 2025 15:20:57 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz,\n\tBryan O'Donoghue <bryan.odonoghue@linaro.org>", "Subject": "[PATCH 19/22] libcamera: software_isp: lut: Make CCM available in\n\tdebayer params", "Date": "Thu, 20 Nov 2025 23:20:16 +0000", "Message-ID": "<20251120232019.3590-20-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.51.2", "In-Reply-To": "<20251120232019.3590-1-bryan.odonoghue@linaro.org>", "References": "<20251120232019.3590-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Provide the CCM calculated in LUT to the debayer params structure for\nconsumption in the debayer shaders.\n\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n include/libcamera/internal/software_isp/debayer_params.h | 7 +++++++\n src/ipa/simple/algorithms/lut.cpp | 1 +\n 2 files changed, 8 insertions(+)", "diff": "diff --git a/include/libcamera/internal/software_isp/debayer_params.h b/include/libcamera/internal/software_isp/debayer_params.h\nindex 217cd5d92..019df2048 100644\n--- a/include/libcamera/internal/software_isp/debayer_params.h\n+++ b/include/libcamera/internal/software_isp/debayer_params.h\n@@ -13,6 +13,8 @@\n #include <array>\n #include <stdint.h>\n \n+#include \"libcamera/internal/matrix.h\"\n+\n namespace libcamera {\n \n struct DebayerParams {\n@@ -49,6 +51,11 @@ struct DebayerParams {\n \tCcmLookupTable greenCcm;\n \tCcmLookupTable blueCcm;\n \tLookupTable gammaLut;\n+\n+\t/*\n+\t * Per frame CCM values as calcualted by the IPA\n+\t */\n+\tMatrix<float, 3, 3> ccm;\t/**< Per frame colour correction matrix for GPUISP */\n };\n \n } /* namespace libcamera */\ndiff --git a/src/ipa/simple/algorithms/lut.cpp b/src/ipa/simple/algorithms/lut.cpp\nindex d4a79e101..49482d711 100644\n--- a/src/ipa/simple/algorithms/lut.cpp\n+++ b/src/ipa/simple/algorithms/lut.cpp\n@@ -133,6 +133,7 @@ void Lut::prepare(IPAContext &context,\n \t\tauto &red = params->redCcm;\n \t\tauto &green = params->greenCcm;\n \t\tauto &blue = params->blueCcm;\n+\t\tparams->ccm = ccm;\n \t\tfor (unsigned int i = 0; i < DebayerParams::kRGBLookupSize; i++) {\n \t\t\tred[i].r = ccmValue(i, ccm[0][0]);\n \t\t\tred[i].g = ccmValue(i, ccm[1][0]);\n", "prefixes": [ "19/22" ] }