Patch Detail
Show a patch.
GET /api/1.1/patches/2512/?format=api
{ "id": 2512, "url": "https://patchwork.libcamera.org/api/1.1/patches/2512/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2512/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200104054127.14108-1-laurent.pinchart@ideasonboard.com>", "date": "2020-01-04T05:41:27", "name": "[libcamera-devel] libcamera: ipc_unixsocket: Don't send uninitialized bytes over the socket", "commit_ref": "a0c31b2ca39fdf06364553194ce725c4912265b3", "pull_url": null, "state": "accepted", "archived": false, "hash": "07a8c8db606d25d3c6a37df4a810d8e6bdaf9db6", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2512/mbox/", "series": [ { "id": 602, "url": "https://patchwork.libcamera.org/api/1.1/series/602/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=602", "date": "2020-01-04T05:41:27", "name": "[libcamera-devel] libcamera: ipc_unixsocket: Don't send uninitialized bytes over the socket", "version": 1, "mbox": "https://patchwork.libcamera.org/series/602/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2512/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2512/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CB39560461\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 4 Jan 2020 06:41:41 +0100 (CET)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5668CA49\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 4 Jan 2020 06:41:41 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1578116501;\n\tbh=yQxhwBj+sDOkUMgCDfmUn5e78RSog1dY8bjJh0ejB84=;\n\th=From:To:Subject:Date:From;\n\tb=ZjR/zilcpHhpbgEJypNDH3T2ZfnMarqURNV2lPSWwtUgh3KXoKIY4vl5WKihogj3J\n\tVJ1/dro22IdLUaQf62dfOcNH0Gy7O+f4AG5ow3NiKfPAELcTZhQtLtLTSxKT0Ui39w\n\tnHEa2ObFPAJSnHmeQNLjMgMebdK+Ho0KxTaFiyqM=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 4 Jan 2020 07:41:27 +0200", "Message-Id": "<20200104054127.14108-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.24.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libcamera: ipc_unixsocket: Don't send\n\tuninitialized bytes over the socket", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Sat, 04 Jan 2020 05:41:42 -0000" }, "content": "IPCUnixSocket::send() sends a IPCUnixSocket::Header allocated on the\nstack. All the fields of the header are initialized, but the padding\nbytes are not. This results in random data being sent over the UNIX\nsocket, potentially leaking information.\n\nFix this by initializing the whole header to 0.\n\nFixes: 13dd7a01ecbe (\"libcamera: ipc: unix: Add a IPC mechanism based on Unix sockets\")\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/ipc_unixsocket.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/ipc_unixsocket.cpp b/src/libcamera/ipc_unixsocket.cpp\nindex def08eef00f8..eb1a50239188 100644\n--- a/src/libcamera/ipc_unixsocket.cpp\n+++ b/src/libcamera/ipc_unixsocket.cpp\n@@ -172,7 +172,7 @@ int IPCUnixSocket::send(const Payload &payload)\n \tif (!isBound())\n \t\treturn -ENOTCONN;\n \n-\tHeader hdr;\n+\tHeader hdr = {};\n \thdr.data = payload.data.size();\n \thdr.fds = payload.fds.size();\n \n", "prefixes": [ "libcamera-devel" ] }