Patch Detail
Show a patch.
GET /api/1.1/patches/25098/?format=api
{ "id": 25098, "url": "https://patchwork.libcamera.org/api/1.1/patches/25098/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25098/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251120104548.80268-13-mzamazal@redhat.com>", "date": "2025-11-20T10:45:47", "name": "[RFC,v2,12/13] libcamera: ipa: simple: Use symbolic constants for adjust defaults", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "e8a17f90199252861525bb88b563d0a81ff9b7de", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/1.1/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25098/mbox/", "series": [ { "id": 5597, "url": "https://patchwork.libcamera.org/api/1.1/series/5597/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5597", "date": "2025-11-20T10:45:35", "name": "Simple pipeline IPA cleanup", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5597/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25098/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25098/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B0062C3334\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 20 Nov 2025 10:46:36 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5792260AA0;\n\tThu, 20 Nov 2025 11:46:36 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B34EB60AA0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 20 Nov 2025 11:46:32 +0100 (CET)", "from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-662-O4aD6rFfPx6GC-0V4Pnr8Q-1;\n\tThu, 20 Nov 2025 05:46:28 -0500", "from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.111])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 593D519560A7; Thu, 20 Nov 2025 10:46:27 +0000 (UTC)", "from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.34.39])\n\tby mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 9F2C0180094C; Thu, 20 Nov 2025 10:46:25 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"e6PxP8Mg\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1763635591;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=/qa56mmG/1DgtFXVlsEmljH2308w/osuFl9CNcfayS8=;\n\tb=e6PxP8MgrHSMDVDOe1SYK2q2U8x7Ia9iZz/HpKmC9LNy8wA575pFDe+vVRfKyCEC2jVDC5\n\tsBBeJilPcS3bcLtw3xQ5NvmvvkTOu7QxcqmcZXBUNJB9aMunfSXx09DV/ZowmQ/X0i0tC6\n\tBPI6s4DCQfkw1IQYgYKd+68D4h+dDyk=", "X-MC-Unique": "O4aD6rFfPx6GC-0V4Pnr8Q-1", "X-Mimecast-MFC-AGG-ID": "O4aD6rFfPx6GC-0V4Pnr8Q_1763635587", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>, Kieran Bingham\n\t<kieran.bingham@ideasonboard.com>, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t<barnabas.pocze@ideasonboard.com>", "Subject": "[RFC PATCH v2 12/13] libcamera: ipa: simple: Use symbolic constants\n\tfor adjust defaults", "Date": "Thu, 20 Nov 2025 11:45:47 +0100", "Message-ID": "<20251120104548.80268-13-mzamazal@redhat.com>", "In-Reply-To": "<20251120104548.80268-1-mzamazal@redhat.com>", "References": "<20251120104548.80268-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.111", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "_F4xo03WUMaq_1719CSG5Mm55wy4FfHo9dTUTNg7tTI_1763635587", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The adjust algorithm already uses a symbolic constant for gamma. Let's\nintroduce similar constants for contrast and saturation to prevent\ncopying the numeric defaults to multiple places.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/ipa/simple/algorithms/adjust.cpp | 11 +++++++----\n src/ipa/simple/algorithms/adjust.h | 2 ++\n 2 files changed, 9 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/ipa/simple/algorithms/adjust.cpp b/src/ipa/simple/algorithms/adjust.cpp\nindex 57ed4f6bf..96c0bde0a 100644\n--- a/src/ipa/simple/algorithms/adjust.cpp\n+++ b/src/ipa/simple/algorithms/adjust.cpp\n@@ -23,10 +23,13 @@ LOG_DEFINE_CATEGORY(IPASoftAdjust)\n \n int Adjust::init(IPAContext &context, [[maybe_unused]] const YamlObject &tuningData)\n {\n-\tcontext.ctrlMap[&controls::Gamma] = ControlInfo(0.1f, 10.0f, kDefaultGamma);\n-\tcontext.ctrlMap[&controls::Contrast] = ControlInfo(0.0f, 2.0f, 1.0f);\n+\tcontext.ctrlMap[&controls::Gamma] =\n+\t\tControlInfo(0.1f, 10.0f, kDefaultGamma);\n+\tcontext.ctrlMap[&controls::Contrast] =\n+\t\tControlInfo(0.0f, 2.0f, kDefaultContrast);\n \tif (context.ccmEnabled)\n-\t\tcontext.ctrlMap[&controls::Saturation] = ControlInfo(0.0f, 2.0f, 1.0f);\n+\t\tcontext.ctrlMap[&controls::Saturation] =\n+\t\t\tControlInfo(0.0f, 2.0f, kDefaultSaturation);\n \treturn 0;\n }\n \n@@ -118,7 +121,7 @@ void Adjust::process([[maybe_unused]] IPAContext &context,\n \t\tmetadata.set(controls::Contrast, contrast.value());\n \n \tconst auto &saturation = frameContext.saturation;\n-\tmetadata.set(controls::Saturation, saturation.value_or(1.0));\n+\tmetadata.set(controls::Saturation, saturation.value_or(kDefaultSaturation));\n }\n \n REGISTER_IPA_ALGORITHM(Adjust, \"Adjust\")\ndiff --git a/src/ipa/simple/algorithms/adjust.h b/src/ipa/simple/algorithms/adjust.h\nindex 190d2079f..11d8297ca 100644\n--- a/src/ipa/simple/algorithms/adjust.h\n+++ b/src/ipa/simple/algorithms/adjust.h\n@@ -20,6 +20,8 @@ namespace libcamera {\n namespace ipa::soft::algorithms {\n \n const float kDefaultGamma = 2.2f;\n+const float kDefaultContrast = 1.0f;\n+const float kDefaultSaturation = 1.0f;\n \n class Adjust : public Algorithm\n {\n", "prefixes": [ "RFC", "v2", "12/13" ] }