Patch Detail
Show a patch.
GET /api/1.1/patches/25073/?format=api
{ "id": 25073, "url": "https://patchwork.libcamera.org/api/1.1/patches/25073/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25073/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251114154341.654850-2-antoine.bouyer@nxp.com>", "date": "2025-11-14T15:43:40", "name": "[v2,1/2] libamera: media_pipeline: Add accessor for MediaPipeline list of entities", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "a8e2158b1b3f251ecefd9b171a97b388a4688e32", "submitter": { "id": 218, "url": "https://patchwork.libcamera.org/api/1.1/people/218/?format=api", "name": "Antoine Bouyer", "email": "antoine.bouyer@nxp.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25073/mbox/", "series": [ { "id": 5591, "url": "https://patchwork.libcamera.org/api/1.1/series/5591/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5591", "date": "2025-11-14T15:43:39", "name": "imx8-isi: Use MediaPipeline", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5591/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25073/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25073/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3C8F6C32DB\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 14 Nov 2025 15:41:56 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C07D960A80;\n\tFri, 14 Nov 2025 16:41:54 +0100 (CET)", "from MRWPR03CU001.outbound.protection.outlook.com\n\t(mail-francesouthazlp170110003.outbound.protection.outlook.com\n\t[IPv6:2a01:111:f403:c207::3])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4DDA8609D8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 14 Nov 2025 16:41:52 +0100 (CET)", "from GVXPR04MB9831.eurprd04.prod.outlook.com (2603:10a6:150:11c::8)\n\tby GV1PR04MB10108.eurprd04.prod.outlook.com (2603:10a6:150:1a2::5)\n\twith Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9320.16;\n\tFri, 14 Nov 2025 15:41:51 +0000", "from GVXPR04MB9831.eurprd04.prod.outlook.com\n\t([fe80::4634:3d9c:c4a:641a]) by\n\tGVXPR04MB9831.eurprd04.prod.outlook.com\n\t([fe80::4634:3d9c:c4a:641a%6]) with mapi id 15.20.9320.018;\n\tFri, 14 Nov 2025 15:41:51 +0000" ], "Authentication-Results": [ "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"eI/iGl3S\";\n\tdkim-atps=neutral", "dkim=none (message not signed)\n\theader.d=none;dmarc=none action=none header.from=nxp.com;" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n\tb=EJ5rOJogrkSkchSCmoh03M50WvlUHu2Y1yf0tXdinTDqij937CRKElifZsP6hST2lGxozT8W5uUCIf/qe6/4Ug5uxJM3MKDkwDUZxB2rQ9XG3k9VhI2cGkpxOZZoCFTeVh+wEMJzWiChVT1pSs++Jz9qcnev6e2WfOQsS2vgsobEWP2CUizfaThjtjcAinC2sMKqr5ouTkmsmNtjvzZfw0i2ym/m4QQdYfghvsbUU9+dVLJtcOexIc/RKREYLvmp2BZeBYScTU+l0oqq2TwK7C69gKJWUFpAQR0+DeeiSkNIvIZ58lOtPn/kkkvx9xEZmr5EnD3TbYqnEnbSljtFpw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n\ts=arcselector10001;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n\tbh=JRexS7c3AqEGKu5NQLAj5oGpqtUjrovH5NEuBy84eEI=;\n\tb=L3fgk9vDu5PxjN9TZPcc6SbZk/Md5cf6cIV2TeNTL72sFqVJA7iOClyHO5jCFUhUxv3GdDcCluBnzme0/fwuBM5mQjxkXNTRWMwczCsph+/zwYdsvclZLa/zMS0yKK61bwutEZXC1lR7Azo1MHRxFar/HUVsxfMgpQSbJRae0IBdltq9Jq+3MVA9H2WsI/EZbY1yduj1fXv307iMWPfuQQNn64STR9vWw68DonhMr5uvOaw5mpEFOTEYCjvMW1h4YuW27YWkt986zWKp1d2c11ujHBR0tbqRqlFw+zVLSRURC+GUlv9bo+S57u0yo5YjEpyWXxXf6h8/8gz59xTocQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n\tsmtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com;\n\tdkim=pass header.d=nxp.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=JRexS7c3AqEGKu5NQLAj5oGpqtUjrovH5NEuBy84eEI=;\n\tb=eI/iGl3So2tpfJ1tYg+V9rOV7578h7IOrRp2eUjEfc2qka00sh1ZO/GZlq5/oSMURrUr551BfbTYW4NVhxEegFijC6TnTAyCwgTCvAyjARxHvA4pjqIW357jVIGbLBI7OBk2CEqAwvqAd55oS73+a+8JjGt8Qhwbt6EmQWYOFooAYzqb9oDNmF28T1Ny87adkOmViYAwYhaJSgrabQUmwc5cvTns274YRzxvKWFa6kE9w35mBl2LPJB4f25kWkoxl505m0DPZfo4Cpmtm6iyRpK+zgi+z/jUT8Qk/SI8BUdj9V5Si/h9f3i3N/YZKzb4CLyhJBppZpLHSJbj8YgDQQ==", "From": "Antoine Bouyer <antoine.bouyer@nxp.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "julien.vuillaumier@nxp.com, jacopo.mondi@ideasonboard.com,\n\tbarnabas.pocze@ideasonboard.com,\n\tAndrei Gansari <andrei.gansari@nxp.com>, \n\tAntoine Bouyer <antoine.bouyer@nxp.com>", "Subject": "[PATCH v2 1/2] libamera: media_pipeline: Add accessor for\n\tMediaPipeline list of entities", "Date": "Fri, 14 Nov 2025 16:43:40 +0100", "Message-Id": "<20251114154341.654850-2-antoine.bouyer@nxp.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20251114154341.654850-1-antoine.bouyer@nxp.com>", "References": "<20251114154341.654850-1-antoine.bouyer@nxp.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "AS4P192CA0039.EURP192.PROD.OUTLOOK.COM\n\t(2603:10a6:20b:658::20) To GVXPR04MB9831.eurprd04.prod.outlook.com\n\t(2603:10a6:150:11c::8)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "GVXPR04MB9831:EE_|GV1PR04MB10108:EE_", "X-MS-Office365-Filtering-Correlation-Id": "5a548076-00ae-4a43-1f8c-08de2394543b", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;\n\tARA:13230040|52116014|19092799006|376014|1800799024|366016|38350700014;", "X-Microsoft-Antispam-Message-Info": "+JYBcoCyoKg2EWyew/aDLDEirPemqNb5zLDSew6dMocxtMeMolyl+j5jxfMdx9CeaOCijbZzXeJy/pgZBMTJqJ5bg/UYjxHNiuL/FroAC4cjfu5MFOSutBQb1afg1hL10cqb9T1L+6yoWAqdIhjC8ry086x8B5JNc++DJsWC8bieVJrvRGz4e3WV7Kl5D9tdol9jT+8Up4+CnQVVJd/+/MCT9cNgA6ZrH8VTG0fGihGMJuozCzmT51J2T/6Jhq8QF8qcwAwBKIDKdmYL85LgMrXRDD/TGldeJOkZsMxkjab92VnXUZF9Mm2m43RWM/GqHV6T5dN1qKjPD5Fu14TE3HrL0g43bQN3XkIdmhgowEyjLHNgXp16QOTWzfAGwWhETvV+d+Nc6HEu9PK3vW8Ax8z5q3ZlyNaMV0NOQJf3vf4c2eShiUDMcZzoxrkrVCBUU26N6Mt02lLO2D+sbCAXjQ2KbMMPNum7SoNUsAvdMm7psV7Am/mqZoJTUAvfl9U5u+UFKDkiOPo6Zt76D/dg3lFJffcSH+JoYRvD6HitU3HO2Q6J8H6634iJj8byzsCNtXlF5EmknTOX5yiQ1Ru1/drf4XPaz3K4VkwIYbwyOu1HfCfa4gz5tUxHu+DKHpUsvBP/TKySv3vJSFeRD3CcaHBmDuHU5GfcaO8HYza8/bZAZEj7rmAgQkcZQBZw4w7GyTxi/BWR+42h458A18W0pZONl/5xmULbhGCnASVe7ZxLiY3usDWfYnc+FHITa1Lf+1V1uoQ5wdMWOxQS00KWG4PWwsD42wjm/xk8SRUSu/IOsWuDh2IcYZynvh71hln19LtTdbKAc+JsnsV/n1cYAS+bz1cphD0nGFiPiX7XftckkYHhgFHJGQhRWU+dsWvqWyskyO2Rjw1CE+1vNgN3XC++lnZGMAnruIUbzvlzNlRgXJrafulEPf8mwX/X1H4kqC925YjNSDScUp8ehueYkEdDX+LD3dbfUoUKbZAFik76tTddfaLSPmAuLE9zVPkryX3P6RtiaRZwlQEcxhkIc681gmx+5amSdpmeZsL8hUA5sM4WAw3zLUtW1bTrAkni0wU7YxgxaRKMxkCPm4aV8E4EqzjFSjY24ppvSweJ6YmUpkKJM5hykvy0eRlus9RE+0e3YN76DESEJk2ZRz0NJ+Sqj24sm3vr2/clWNkae9jozBcSKm1hFSLY5u0W9UNsBvSsV20E+CgzF93B3MsJOrx8H5v0QUsswx7AY5cLwfj7I7VpOKD8SZFCbIlxEjQfRfHYTFekcuPTcD5qBX0m7iTEyxLtlSZDvK8qXOloow1DmTNFOhd/Pd9cN16LBEa9znlCJ6XP40rRIIaQzMOjyCAywkxTtKiBL3pfBuNdxfFkK7wq8LT8uTbvdSlkYEaJWwv96HeXT/1D1XMRwcTjHDQpo8Y6IYuoINFRRTMSpcSsw9Z1nvVGo0epqNZ/d7m2jbEFqKMOa1BBfNTMTOjf1HPEp2Bwe5TgEZAEad0htT9posDPnNBpaTN2Kzs9WkKS", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n\tIPV:NLI; SFV:NSPM; H:GVXPR04MB9831.eurprd04.prod.outlook.com; PTR:;\n\tCAT:NONE; \n\tSFS:(13230040)(52116014)(19092799006)(376014)(1800799024)(366016)(38350700014);\n\tDIR:OUT; SFP:1101; ", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "M78TTe1j+32zWkQbbuA2EWmNOB2CsleGv43ATWEZ6ce/zTJiJAUjArc2i6c9HQZiJDJrgauLNoLiYXZeTZ017mpJ8766QE7YL7JcN6OsSHZ0Tr1fyXdmMr3Bsm76u4qvRAMOTCKeCXEdOjr8+UlWQbWcFf02vZ4aufrsnji79zxJGBk10rDdMdgaGJhAGNxtQHUebok3YWuGK08Kn4iDB17BstcalnTCDSBwJzDyVwLwxe/LGRq2qlkLZxhelw10VrQ7cpyqAJTPu1xiE1mIGdoLzKXNq3Qpi+9xsw9tAArnXhnvlWMQmfxYEOGZotV+O2NLVjtWFA7K5RLlJ9rLRd56RKUeAj+IJCxKo8edNLP+NTcd1YhQZ9GYDFKS/OC1aqlXAILiyU0VWWC6bd0BOGUsfzyvrH5hLiWIjWu1GOQnl5so9dzi9aXCRXYtOTNF114tSUjNn1JFSq7/IBqVWHWZWpza4q4Eq9mZ/qOhpLJ2R8I61f2TQ2JPZpO+OFdgivLfptElVsUEzSWtOcmn91ksZukD40RJzVgBzlFu3t6oKaUKTcVu2MraQ4Qcg/UN3VarGjg42VaSjK2zmrK6XwIo0mdA9NQfbFx8hxdiI4WqmVn5zMlXxIxPKR3mhZJys0YOpqj1JddJ61H5gQMkgINMTA3myXBpU8nDF7e19Mp17CpsnPafV7lI89unab2DnL1s2G4r0Va+4Zf/BDIE/2wFMlG1KXLtTrTErknCDbiRchOIgup/F7dEbe/bA1E1zfUiUsaESNF2YRBuOTEcp5By1duqe2ntdsHVeg/ndAW2Iae41BpZefzYMFZ3Wfl2pypx83T/SYO4Q7teYAJbYG1ZnSuKIfpMZBKCJFHV8VhfK7xbOQz7m6Dd0RR2O1+QC15zyhU9vA17+iDuyxs+PzXy8UnYe9ul4Pmwbrjnt1sflhxDM7dMGGMIt/7qmFxa+GObNnIxsNyS4WJD8Wj53XNt7Q/2BFJ/PyqLYMNCi5Vh+sTPXJk7WRKf/bfhvS1YoMKBUflUlHO6XKXPQnccRxAWAMdZ2gdCQrY2/TOr1wWqPHkwQGmbWi8s/BOt6uZgM3Zh/2JJJVIYtaoS8dR9kvkuPOuGusAtrQXhoOgAi8zE0Ms+sSSCsjLPSrcKj6ubPcDTWRSrAJ4XwmbLLNkTRTK9lkqthAl9PBzZEwZbEs+EYmPn3+XuFe0q/8OB5heIPwZWmNOmCQQESVKdoP+fHnT2DsBz3b+kkZSF/Y6v3jN7GmepNrh2EqJjuU5W2e3kZ2ATQjqOIJ49yYgSUc2KivDVOX1JtV694Bh/SKwK8sXEStaImCIX54JT7YhEC7ujMzI2QVCFs5akD0NntTB7+3f7hJH+SPWxsrsZwHOf4GMxc9dr/hMYIBlz/5azgqylyhJtxYLapjofKiAwlC/ea/mF9eorUdGc+1nuIG8tmdyrnbjmYjug6ppB4ooJe2KK7RCrbcOPYik4tXT7gI14z4eexRV46FQ0ck+FX4jX6OBQj0af4xmzIYg6ZtDYEn1sXTHNc9nuB5Kz3lM2vsdBqxaEK8iNXBg/xKtY1TuN1YNDHacrC7Y14xewMXmjovyRWU+zMvzV76P9KwCWBvPBng==", "X-OriginatorOrg": "nxp.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "5a548076-00ae-4a43-1f8c-08de2394543b", "X-MS-Exchange-CrossTenant-AuthSource": "GVXPR04MB9831.eurprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "14 Nov 2025 15:41:51.0165\n\t(UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "yrTmNsN1Dn5A9QrrcmqsJ4wo6LtSLt7Qa7MKBeF+5Vi08BlNAOqnMfkF3t8CsVsvgZreSo75cmgXFAi3oPlS7Q==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "GV1PR04MB10108", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Andrei Gansari <andrei.gansari@nxp.com>\n\nExposes internal MediaEntity::Entity list to help extracting more\ninformation regarding linked entities.\n\nFor example, when the pad index of the last device in the list need to be\nretrieved from the media pipeline user.\n\nExposes as const to with a dedicated access to prevent any corruption from\nuser. Then it is still protected so as when the list was private.\n\nSince MediaPipeline::Entity needs also to be moved to public, then need to\nadd some documentation in cpp source. Existing documentation from header\nfile is applied when available.\n\nSigned-off-by: Andrei Gansari <andrei.gansari@nxp.com>\nSigned-off-by: Antoine Bouyer <antoine.bouyer@nxp.com>\n---\n include/libcamera/internal/media_pipeline.h | 29 ++++----------\n src/libcamera/media_pipeline.cpp | 44 +++++++++++++++++++++\n 2 files changed, 51 insertions(+), 22 deletions(-)", "diff": "diff --git a/include/libcamera/internal/media_pipeline.h b/include/libcamera/internal/media_pipeline.h\nindex a7a4b8c559cd..f62e3e8c58b0 100644\n--- a/include/libcamera/internal/media_pipeline.h\n+++ b/include/libcamera/internal/media_pipeline.h\n@@ -23,36 +23,21 @@ struct V4L2SubdeviceFormat;\n class MediaPipeline\n {\n public:\n-\tint init(MediaEntity *source, std::string_view sink);\n-\tint initLinks();\n-\tint configure(CameraSensor *sensor, V4L2SubdeviceFormat *);\n-\n-private:\n \tstruct Entity {\n-\t\t/* The media entity, always valid. */\n \t\tMediaEntity *entity;\n-\t\t/*\n-\t\t * Whether or not the entity is a subdev that supports the\n-\t\t * routing API.\n-\t\t */\n \t\tbool supportsRouting;\n-\t\t/*\n-\t\t * The local sink pad connected to the upstream entity, null for\n-\t\t * the camera sensor at the beginning of the pipeline.\n-\t\t */\n \t\tconst MediaPad *sink;\n-\t\t/*\n-\t\t * The local source pad connected to the downstream entity, null\n-\t\t * for the video node at the end of the pipeline.\n-\t\t */\n \t\tconst MediaPad *source;\n-\t\t/*\n-\t\t * The link on the source pad, to the downstream entity, null\n-\t\t * for the video node at the end of the pipeline.\n-\t\t */\n \t\tMediaLink *sourceLink;\n \t};\n \n+\tint init(MediaEntity *source, std::string_view sink);\n+\tint initLinks();\n+\tint configure(CameraSensor *sensor, V4L2SubdeviceFormat *);\n+\n+\tconst std::list<Entity> &entities() const { return entities_; }\n+\n+private:\n \tstd::list<Entity> entities_;\n };\n \ndiff --git a/src/libcamera/media_pipeline.cpp b/src/libcamera/media_pipeline.cpp\nindex c4e9f69b8f6a..1bb55a507fce 100644\n--- a/src/libcamera/media_pipeline.cpp\n+++ b/src/libcamera/media_pipeline.cpp\n@@ -43,6 +43,50 @@ LOG_DEFINE_CATEGORY(MediaPipeline)\n * two entities in a media graph.\n */\n \n+/**\n+ * \\struct MediaPipeline::Entity\n+ * \\brief A node composing the media pipeline\n+ *\n+ * The MediaPipeline::Entity struct stores how a MediaEntity composing a\n+ * media pipeline is connected to other media entities. Source and sink pads\n+ * are stored, so as whether the entity itself does support internal routing.\n+ */\n+\n+/**\n+ * \\var MediaPipeline::Entity::entity\n+ * Pointer to the libcamera::MediaEntity, always valid\n+ */\n+\n+/**\n+ * \\var MediaPipeline::Entity::supportsRouting\n+ * Whether or not the entity is a subdev that supports the routing API\n+ */\n+\n+/**\n+ * \\var MediaPipeline::Entity::sink\n+ * The local libcamera::MediaPad sink pad connected to the upstream entity,\n+ * null for the camera sensor at the beginning of the pipeline.\n+ */\n+\n+/**\n+ * \\var MediaPipeline::Entity::source\n+ * The local libcamera::MediaPad source pad connected to the upstream entity,\n+ * null for the last node at the end of the pipeline.\n+ */\n+\n+/**\n+ * \\var MediaPipeline::Entity::sourceLink\n+ * The link on the libcamera::MediaLink source pad, to the downstream entity,\n+ * null for the last node at the end of the pipeline.\n+ */\n+\n+/**\n+ * \\fn MediaPipeline::entities()\n+ * \\brief Retrieve list of entities composing the media pipeline\n+ * \\return The list of MediaPipeline::Entity entities composing the media\n+ * pipeline.\n+ */\n+\n /**\n * \\brief Retrieve all source pads connected to a sink pad through active routes\n *\n", "prefixes": [ "v2", "1/2" ] }