Patch Detail
Show a patch.
GET /api/1.1/patches/25002/?format=api
{ "id": 25002, "url": "https://patchwork.libcamera.org/api/1.1/patches/25002/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25002/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251112082715.17823-5-mzamazal@redhat.com>", "date": "2025-11-12T08:27:12", "name": "[RFC,4/7] libcamera: ipa: simple: Rename \"ccm\" identifiers not specific to CCM", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "26f49cb9709e3d704de46ef01498a10d0c790dba", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/1.1/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25002/mbox/", "series": [ { "id": 5582, "url": "https://patchwork.libcamera.org/api/1.1/series/5582/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5582", "date": "2025-11-12T08:27:08", "name": "Simple pipeline IPA cleanup", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5582/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25002/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25002/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 95273C3241\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 12 Nov 2025 08:27:35 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1037C60AAA;\n\tWed, 12 Nov 2025 09:27:35 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0079160A9E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 12 Nov 2025 09:27:30 +0100 (CET)", "from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-645-Laqnu6WAMjCixh9PXElZ9A-1;\n\tWed, 12 Nov 2025 03:27:28 -0500", "from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.93])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS\n\tid AFF8E1954B00 for <libcamera-devel@lists.libcamera.org>;\n\tWed, 12 Nov 2025 08:27:27 +0000 (UTC)", "from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.33.149])\n\tby mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 8B28518004D8; Wed, 12 Nov 2025 08:27:26 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"ZPsh1lCN\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1762936050;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=oumnQQoZKAW/ZsSaeK1XJTwDKNiPsQHH7o2c/HmpfmM=;\n\tb=ZPsh1lCNZ14xMEooybV0mYaPXJE38a2z3gI7h5Q+J+EuZs20yHYiz/QX31h7TVAUhJNSm0\n\toEVgrDa4mzPTfCA8MGVg2sKKyDts7VrByummEXoAgRBG/PRDfZqhlDN+OQz1dGkzD6QvIT\n\tKOGmHWBOZTeouCUe2kzzS4UvENcWkek=", "X-MC-Unique": "Laqnu6WAMjCixh9PXElZ9A-1", "X-Mimecast-MFC-AGG-ID": "Laqnu6WAMjCixh9PXElZ9A_1762936047", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>", "Subject": "[RFC PATCH 4/7] libcamera: ipa: simple: Rename \"ccm\" identifiers not\n\tspecific to CCM", "Date": "Wed, 12 Nov 2025 09:27:12 +0100", "Message-ID": "<20251112082715.17823-5-mzamazal@redhat.com>", "In-Reply-To": "<20251112082715.17823-1-mzamazal@redhat.com>", "References": "<20251112082715.17823-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.93", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "jHa92R1daHnbcUZBXYgdzvP80Q5E4lEXyR3qSdfykBw_1762936047", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Let's rename the identifiers that are related to general colour\ncorrections applied by matrix operations, rather than directly to the\nsensor colour correction matrix.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/ipa/simple/algorithms/lut.cpp | 28 ++++++++++++++--------------\n src/ipa/simple/algorithms/lut.h | 2 +-\n 2 files changed, 15 insertions(+), 15 deletions(-)", "diff": "diff --git a/src/ipa/simple/algorithms/lut.cpp b/src/ipa/simple/algorithms/lut.cpp\nindex dead55f34..b27491042 100644\n--- a/src/ipa/simple/algorithms/lut.cpp\n+++ b/src/ipa/simple/algorithms/lut.cpp\n@@ -80,7 +80,7 @@ void Lut::updateGammaTable(IPAContext &context)\n \tcontext.activeState.gamma.contrast = contrast;\n }\n \n-int16_t Lut::ccmValue(unsigned int i, float ccm) const\n+int16_t Lut::matrixValue(unsigned int i, float ccm) const\n {\n \treturn std::round(i * ccm);\n }\n@@ -120,23 +120,23 @@ void Lut::prepare(IPAContext &context,\n \t\t}\n \n \t} else if (context.activeState.matrixChanged || gammaUpdateNeeded) {\n-\t\tMatrix<float, 3, 3> gainCcm = { { gains.r(), 0, 0,\n-\t\t\t\t\t\t 0, gains.g(), 0,\n-\t\t\t\t\t\t 0, 0, gains.b() } };\n-\t\tauto ccm = context.activeState.ccm * gainCcm;\n+\t\tMatrix<float, 3, 3> gainMatrix = { { gains.r(), 0, 0,\n+\t\t\t\t\t\t 0, gains.g(), 0,\n+\t\t\t\t\t\t 0, 0, gains.b() } };\n+\t\tauto matrix = context.activeState.ccm * gainMatrix;\n \t\tauto &red = params->redCcm;\n \t\tauto &green = params->greenCcm;\n \t\tauto &blue = params->blueCcm;\n \t\tfor (unsigned int i = 0; i < DebayerParams::kRGBLookupSize; i++) {\n-\t\t\tred[i].r = ccmValue(i, ccm[0][0]);\n-\t\t\tred[i].g = ccmValue(i, ccm[1][0]);\n-\t\t\tred[i].b = ccmValue(i, ccm[2][0]);\n-\t\t\tgreen[i].r = ccmValue(i, ccm[0][1]);\n-\t\t\tgreen[i].g = ccmValue(i, ccm[1][1]);\n-\t\t\tgreen[i].b = ccmValue(i, ccm[2][1]);\n-\t\t\tblue[i].r = ccmValue(i, ccm[0][2]);\n-\t\t\tblue[i].g = ccmValue(i, ccm[1][2]);\n-\t\t\tblue[i].b = ccmValue(i, ccm[2][2]);\n+\t\t\tred[i].r = matrixValue(i, matrix[0][0]);\n+\t\t\tred[i].g = matrixValue(i, matrix[1][0]);\n+\t\t\tred[i].b = matrixValue(i, matrix[2][0]);\n+\t\t\tgreen[i].r = matrixValue(i, matrix[0][1]);\n+\t\t\tgreen[i].g = matrixValue(i, matrix[1][1]);\n+\t\t\tgreen[i].b = matrixValue(i, matrix[2][1]);\n+\t\t\tblue[i].r = matrixValue(i, matrix[0][2]);\n+\t\t\tblue[i].g = matrixValue(i, matrix[1][2]);\n+\t\t\tblue[i].b = matrixValue(i, matrix[2][2]);\n \t\t\tparams->gammaLut[i] = gammaTable[i / div];\n \t\t}\n \t\tcontext.activeState.matrixChanged = false;\ndiff --git a/src/ipa/simple/algorithms/lut.h b/src/ipa/simple/algorithms/lut.h\nindex ba8b9021b..0eafd0695 100644\n--- a/src/ipa/simple/algorithms/lut.h\n+++ b/src/ipa/simple/algorithms/lut.h\n@@ -38,7 +38,7 @@ public:\n \n private:\n \tvoid updateGammaTable(IPAContext &context);\n-\tint16_t ccmValue(unsigned int i, float ccm) const;\n+\tint16_t matrixValue(unsigned int i, float ccm) const;\n };\n \n } /* namespace ipa::soft::algorithms */\n", "prefixes": [ "RFC", "4/7" ] }