Patch Detail
Show a patch.
GET /api/1.1/patches/2500/?format=api
{ "id": 2500, "url": "https://patchwork.libcamera.org/api/1.1/patches/2500/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2500/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200104050947.7673-5-laurent.pinchart@ideasonboard.com>", "date": "2020-01-04T05:09:37", "name": "[libcamera-devel,04/14] libcamera: bound_method: Mark overriden methods with override", "commit_ref": "7d66a45b8d91994ed0b9db368282b0e1135bfb44", "pull_url": null, "state": "accepted", "archived": false, "hash": "53b02e3bc50cfd4b09fb2007b6bdb863ed0b53ad", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2500/mbox/", "series": [ { "id": 600, "url": "https://patchwork.libcamera.org/api/1.1/series/600/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=600", "date": "2020-01-04T05:09:33", "name": "object: Propagate return value of invoked method", "version": 1, "mbox": "https://patchwork.libcamera.org/series/600/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2500/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2500/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3CA3160466\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 4 Jan 2020 06:10:04 +0100 (CET)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D9AB830F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 4 Jan 2020 06:10:03 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1578114604;\n\tbh=Q31aLLJP61ph/JvgeiUo+dtOidufq2NNa6OwPbOIvOU=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=GYvSShe4/vC5KbxjgX7AlXVjpXMP2Qn8GgJMHFxE1lK8dli8Se7r1ti3xaaIgu7KI\n\tQJRyhOSJyCH0g15IOSKkCQ5Z0gC9NGU3tGEoechyRDqrMhd62ayaUxw+rHWK7gDV6s\n\tqGzpXYpqUKu/Jjo0tTsSUhynjpo7RV0KoNYtyllI=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 4 Jan 2020 07:09:37 +0200", "Message-Id": "<20200104050947.7673-5-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.24.1", "In-Reply-To": "<20200104050947.7673-1-laurent.pinchart@ideasonboard.com>", "References": "<20200104050947.7673-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 04/14] libcamera: bound_method: Mark\n\toverriden methods with override", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Sat, 04 Jan 2020 05:10:04 -0000" }, "content": "Mark the activate() and invoke() methods with the override keyword where\nappropriate.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n include/libcamera/bound_method.h | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/include/libcamera/bound_method.h b/include/libcamera/bound_method.h\nindex 5743cacf5388..f23b17c7dd98 100644\n--- a/include/libcamera/bound_method.h\n+++ b/include/libcamera/bound_method.h\n@@ -107,7 +107,7 @@ public:\n \n \tbool match(void (T::*func)(Args...)) const { return func == func_; }\n \n-\tvoid activate(Args... args, bool deleteMethod = false)\n+\tvoid activate(Args... args, bool deleteMethod = false) override\n \t{\n \t\tif (this->object_)\n \t\t\tBoundMethodBase::activatePack(new PackType{ args... }, deleteMethod);\n@@ -115,7 +115,7 @@ public:\n \t\t\t(static_cast<T *>(this->obj_)->*func_)(args...);\n \t}\n \n-\tvoid invoke(Args... args)\n+\tvoid invoke(Args... args) override\n \t{\n \t\t(static_cast<T *>(this->obj_)->*func_)(args...);\n \t}\n@@ -136,12 +136,12 @@ public:\n \n \tbool match(void (*func)(Args...)) const { return func == func_; }\n \n-\tvoid activate(Args... args, bool deleteMethod = false)\n+\tvoid activate(Args... args, bool deleteMethod = false) override\n \t{\n \t\t(*func_)(args...);\n \t}\n \n-\tvoid invoke(Args...) {}\n+\tvoid invoke(Args...) override {}\n \n private:\n \tvoid (*func_)(Args...);\n", "prefixes": [ "libcamera-devel", "04/14" ] }