Patch Detail
Show a patch.
GET /api/1.1/patches/24996/?format=api
{ "id": 24996, "url": "https://patchwork.libcamera.org/api/1.1/patches/24996/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24996/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251111145326.1194122-1-rui.wang@ideasonboard.com>", "date": "2025-11-11T14:53:26", "name": "[v2] ipa: rkisp1: dpf: Enable strength after enable Dpf", "commit_ref": "30779421e83fe67487f87fa4b2d01ed995154a81", "pull_url": null, "state": "accepted", "archived": false, "hash": "9949cc68414cd47c9ab947f9dae5eff29034f547", "submitter": { "id": 241, "url": "https://patchwork.libcamera.org/api/1.1/people/241/?format=api", "name": "Rui Wang", "email": "rui.wang@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24996/mbox/", "series": [ { "id": 5580, "url": "https://patchwork.libcamera.org/api/1.1/series/5580/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5580", "date": "2025-11-11T14:53:26", "name": "[v2] ipa: rkisp1: dpf: Enable strength after enable Dpf", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5580/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24996/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24996/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F3525C3241\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 11 Nov 2025 14:53:43 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 620F9606D5;\n\tTue, 11 Nov 2025 15:53:43 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 68D59606A0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 11 Nov 2025 15:53:41 +0100 (CET)", "from rui-Precision-7560.local (unknown [209.216.122.90])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 48E59FDB;\n\tTue, 11 Nov 2025 15:51:42 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QEDyFsLz\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1762872702;\n\tbh=sk4RG1+0bLxU9pSX1cxGsoAR2eI44Ygk15XdXXbNKe4=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=QEDyFsLzmPQIroXvtGA6xwSznoWKQ0nNl+ggOZNSOlO0Yr8oeSl20lbQTXejm065i\n\tM7fJSOFuhVLAvy3blv/QbGmipINHf1W8n8C9Tqa3Bjn6zGNkfeewc7cX7iLSTjEe5z\n\tbp+fJ8BCLuhoRS/cxjvv5wOZXfKJrK+isw/pvLPw=", "From": "Rui Wang <rui.wang@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Rui Wang <rui.wang@ideasonboard.com>", "Subject": "[PATCH v2] ipa: rkisp1: dpf: Enable strength after enable Dpf", "Date": "Tue, 11 Nov 2025 09:53:26 -0500", "Message-ID": "<20251111145326.1194122-1-rui.wang@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The filter strength configuration block was previously only enabled on the\nfirst frame (frame == 0). Apply the strength values when denoise is active.\nThis prevents the strength config from being disabled on subsequent frames.\n\nSigned-off-by: Rui Wang <rui.wang@ideasonboard.com>\n---\n src/ipa/rkisp1/algorithms/dpf.cpp | 10 ++++------\n 1 file changed, 4 insertions(+), 6 deletions(-)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/dpf.cpp b/src/ipa/rkisp1/algorithms/dpf.cpp\nindex cb6095da..39f3e461 100644\n--- a/src/ipa/rkisp1/algorithms/dpf.cpp\n+++ b/src/ipa/rkisp1/algorithms/dpf.cpp\n@@ -225,8 +225,12 @@ void Dpf::prepare(IPAContext &context, const uint32_t frame,\n \tauto config = params->block<BlockType::Dpf>();\n \tconfig.setEnabled(frameContext.dpf.denoise);\n \n+\tauto strengthConfig = params->block<BlockType::DpfStrength>();\n+\tstrengthConfig.setEnabled(frameContext.dpf.denoise);\n+\n \tif (frameContext.dpf.denoise) {\n \t\t*config = config_;\n+\t\t*strengthConfig = strengthConfig_;\n \n \t\tconst auto &awb = context.configuration.awb;\n \t\tconst auto &lsc = context.configuration.lsc;\n@@ -250,12 +254,6 @@ void Dpf::prepare(IPAContext &context, const uint32_t frame,\n \t\telse\n \t\t\tmode = RKISP1_CIF_ISP_DPF_GAIN_USAGE_DISABLED;\n \t}\n-\n-\tif (frame == 0) {\n-\t\tauto strengthConfig = params->block<BlockType::DpfStrength>();\n-\t\tstrengthConfig.setEnabled(true);\n-\t\t*strengthConfig = strengthConfig_;\n-\t}\n }\n \n REGISTER_IPA_ALGORITHM(Dpf, \"Dpf\")\n", "prefixes": [ "v2" ] }