Patch Detail
Show a patch.
GET /api/1.1/patches/24990/?format=api
{ "id": 24990, "url": "https://patchwork.libcamera.org/api/1.1/patches/24990/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24990/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251111120634.1132790-1-rui.wang@ideasonboard.com>", "date": "2025-11-11T12:06:17", "name": "[v1] ipa: rkisp1: dpf: Enable strength after enable Dpf", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "d9d9bed3da4a5aa9a3e04ed22a68cadd08e3b227", "submitter": { "id": 241, "url": "https://patchwork.libcamera.org/api/1.1/people/241/?format=api", "name": "Rui Wang", "email": "rui.wang@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24990/mbox/", "series": [ { "id": 5574, "url": "https://patchwork.libcamera.org/api/1.1/series/5574/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5574", "date": "2025-11-11T12:06:17", "name": "[v1] ipa: rkisp1: dpf: Enable strength after enable Dpf", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5574/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24990/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24990/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4DB2FC3241\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 11 Nov 2025 12:06:40 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 78BC760A80;\n\tTue, 11 Nov 2025 13:06:39 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5F7C5606A0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 11 Nov 2025 13:06:38 +0100 (CET)", "from rui-Precision-7560.local (unknown [209.216.122.90])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 75DD6FE;\n\tTue, 11 Nov 2025 13:04:39 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lqIrVBz3\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1762862679;\n\tbh=x9u3ebRjXYSB1DDO701/+1EJqBqK/snOiGp6Mn+GN9o=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=lqIrVBz3iWoYGOVhtoKL9nndVU+H5C+z4QP7sh1pvWzENxh0WyUKftGFcGKSMRLv6\n\ttEyVlka25PTxo3N5MSmStCPrN/gfgnD02ziCGE4+C16WUpEj/wJnGHIfQ33h05Vl0b\n\t3O3Mcy9Wc+DB1GjcWTkZ8gig0I/5WIYnZXryNCvU=", "From": "Rui Wang <rui.wang@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Rui Wang <rui.wang@ideasonboard.com>", "Subject": "[PATCH v1] ipa: rkisp1: dpf: Enable strength after enable Dpf", "Date": "Tue, 11 Nov 2025 07:06:17 -0500", "Message-ID": "<20251111120634.1132790-1-rui.wang@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20251024120107.681968-1-rui.wang@ideasonboard.com>", "References": "<barnabas.pocze@ideasonboard.com>\n\t<20251024120107.681968-1-rui.wang@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The filter strength configuration block was previously only enabled on the\nfirst frame (frame == 0). Apply the strength values when denoise is active.\nThis prevents the strength config from being disabled on subsequent frames.\n\nSigned-off-by: Rui Wang <rui.wang@ideasonboard.com>\n---\n src/ipa/rkisp1/algorithms/dpf.cpp | 7 ++++---\n 1 file changed, 4 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/dpf.cpp b/src/ipa/rkisp1/algorithms/dpf.cpp\nindex cb6095da..e95fb95d 100644\n--- a/src/ipa/rkisp1/algorithms/dpf.cpp\n+++ b/src/ipa/rkisp1/algorithms/dpf.cpp\n@@ -251,9 +251,10 @@ void Dpf::prepare(IPAContext &context, const uint32_t frame,\n \t\t\tmode = RKISP1_CIF_ISP_DPF_GAIN_USAGE_DISABLED;\n \t}\n \n-\tif (frame == 0) {\n-\t\tauto strengthConfig = params->block<BlockType::DpfStrength>();\n-\t\tstrengthConfig.setEnabled(true);\n+\tauto strengthConfig = params->block<BlockType::DpfStrength>();\n+\tstrengthConfig.setEnabled(frameContext.dpf.denoise);\n+\n+\tif (frameContext.dpf.denoise) {\n \t\t*strengthConfig = strengthConfig_;\n \t}\n }\n", "prefixes": [ "v1" ] }