Patch Detail
Show a patch.
GET /api/1.1/patches/24987/?format=api
{ "id": 24987, "url": "https://patchwork.libcamera.org/api/1.1/patches/24987/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24987/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251111092319.2313234-1-barnabas.pocze@ideasonboard.com>", "date": "2025-11-11T09:23:19", "name": "[RFC,v1] libcamera: pipeline: uvcvideo: Reject sensor configuration", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "5b84287c0a84cf1ef03039d0864aa45874585398", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/1.1/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24987/mbox/", "series": [ { "id": 5571, "url": "https://patchwork.libcamera.org/api/1.1/series/5571/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5571", "date": "2025-11-11T09:23:19", "name": "[RFC,v1] libcamera: pipeline: uvcvideo: Reject sensor configuration", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5571/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24987/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24987/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A6EEFC3263\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 11 Nov 2025 09:23:25 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D5727609DE;\n\tTue, 11 Nov 2025 10:23:24 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4E32D60805\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 11 Nov 2025 10:23:23 +0100 (CET)", "from pb-laptop.local (185.221.140.239.nat.pool.zt.hu\n\t[185.221.140.239])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 92B5850A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 11 Nov 2025 10:21:24 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"aLkTJxtT\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1762852884;\n\tbh=1aB4nhr1F1qLCYMJ4M9BDuv0RXI8YBmaUG7RI3DvVmU=;\n\th=From:To:Subject:Date:From;\n\tb=aLkTJxtTPrYNxEL5/CM9aUE8agPNiIVBDRYk55F1FcvJ7ucxaSktHvMdhulwe6pLm\n\tH+qUc3XZ3KNdAdXgPC7ENQC8vJ0FbSkCKwTfNSP3XI6ZTsrZqityr6P46bcbzNqSlg\n\tCMDbMvyTT+7aZTe90Na3bgQV/FP1WEh+CCwF7tos=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[RFC PATCH v1] libcamera: pipeline: uvcvideo: Reject sensor\n\tconfiguration", "Date": "Tue, 11 Nov 2025 10:23:19 +0100", "Message-ID": "<20251111092319.2313234-1-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.51.2", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The UVC pipeline handler cannot set the sensor configuration so if the\ndesired `CameraConfiguration` specifies one, then reject it.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 3 +++\n 1 file changed, 3 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\nindex 4b5816dfdd..48d6b39d53 100644\n--- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n+++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n@@ -143,6 +143,9 @@ CameraConfiguration::Status UVCCameraConfiguration::validate()\n \tif (config_.empty())\n \t\treturn Invalid;\n \n+\tif (sensorConfig)\n+\t\treturn Invalid;\n+\n \tif (orientation != Orientation::Rotate0) {\n \t\torientation = Orientation::Rotate0;\n \t\tstatus = Adjusted;\n", "prefixes": [ "RFC", "v1" ] }