Patch Detail
Show a patch.
GET /api/1.1/patches/24955/?format=api
{ "id": 24955, "url": "https://patchwork.libcamera.org/api/1.1/patches/24955/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24955/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251103213014.62713-2-uajain@igalia.com>", "date": "2025-11-03T21:30:12", "name": "[v4,1/3] gstreamer: Associate libcamera::Stream with GstPad", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "3a536e4c40ee17a08abc3450a0fba9c3e52e6db7", "submitter": { "id": 232, "url": "https://patchwork.libcamera.org/api/1.1/people/232/?format=api", "name": "Umang Jain", "email": "uajain@igalia.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24955/mbox/", "series": [ { "id": 5559, "url": "https://patchwork.libcamera.org/api/1.1/series/5559/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5559", "date": "2025-11-03T21:30:12", "name": "gstreamer: Assorted fixes", "version": 4, "mbox": "https://patchwork.libcamera.org/series/5559/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24955/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24955/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 05F30BDE4C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 3 Nov 2025 21:29:46 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2890460A8A;\n\tMon, 3 Nov 2025 22:29:45 +0100 (CET)", "from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8A48F609D8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 3 Nov 2025 22:29:42 +0100 (CET)", "from [81.140.124.245] (helo=uajain)\n\tby fanzine2.igalia.com with esmtpsa \n\t(Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)\n\t(Exim) id 1vG27S-0013tS-1T; Mon, 03 Nov 2025 22:29:42 +0100" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=igalia.com header.i=@igalia.com\n\theader.b=\"rLmw9oMa\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;\n\ts=20170329;\n\th=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=/vMh/6/YtHaKdQ17o9NZ4SR1gcacTFRGywsSl3TKXmA=;\n\tb=rLmw9oMaznn4TAT+SaYLxdCEtx\n\tioYeP5IGD+EtB8DHUZ3rnS5RH7Vmm6LX5ZgxEDkMki2+jW4+6ZNHMQQMvuq3+t2TZr6MQkcNKRKpJ\n\trI//ejG2bULqNqB8pvxGfiji7F0GhirC715+zuexLekFgcXbsKaxcebMcSJH9hKWkkGKg4J+tO4tc\n\tTguLgK5JQsaFqWfazb8dSGCrGdk5S/kNcSR7nW3fcVrijx9GE/ANIrMgxA11yHD+Qw+kXUgm29n+i\n\thZ1alqBLN92njhKlZIME1eltzBZvV6lyYmaFQtAPPfH1Byhs1J79oTlx45eHoBe87AfhHBsPwlgTX\n\tci2hHmoA==;", "From": "Umang Jain <uajain@igalia.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Nicolas Dufresne <nicolas.dufresne@collabora.com>,\n\tUmang Jain <uajain@igalia.com>", "Subject": "[PATCH v4 1/3] gstreamer: Associate libcamera::Stream with GstPad", "Date": "Mon, 3 Nov 2025 21:30:12 +0000", "Message-ID": "<20251103213014.62713-2-uajain@igalia.com>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20251103213014.62713-1-uajain@igalia.com>", "References": "<20251103213014.62713-1-uajain@igalia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Instead of trying to figure out which libcamera::Stream, the GstPad\nis configured with (from the libcamera pool), associate the Stream\nwith the GstPad directly. The association can be set using\ngst_pad_set_element_private().\n\nAdd the gst_libcamera_pad_set_stream() helper to associate the stream\nwith the pad. Additionally, modify the gst_libcamera_pad_get_stream()\nto use to the getter helper gst_pad_get_element_private().\n\nSigned-off-by: Umang Jain <uajain@igalia.com>\n---\n src/gstreamer/gstlibcamerapad.cpp | 11 ++++++-----\n src/gstreamer/gstlibcamerapad.h | 2 ++\n src/gstreamer/gstlibcamerasrc.cpp | 6 +++++-\n 3 files changed, 13 insertions(+), 6 deletions(-)", "diff": "diff --git a/src/gstreamer/gstlibcamerapad.cpp b/src/gstreamer/gstlibcamerapad.cpp\nindex 22b96719..b37c4b34 100644\n--- a/src/gstreamer/gstlibcamerapad.cpp\n+++ b/src/gstreamer/gstlibcamerapad.cpp\n@@ -192,12 +192,13 @@ void gst_libcamera_pad_set_video_info(GstPad *pad, const GstVideoInfo *info)\n Stream *\n gst_libcamera_pad_get_stream(GstPad *pad)\n {\n-\tauto *self = GST_LIBCAMERA_PAD(pad);\n-\n-\tif (self->pool)\n-\t\treturn gst_libcamera_pool_get_stream(self->pool);\n+\treturn static_cast<Stream *>(gst_pad_get_element_private(pad));\n+}\n \n-\treturn nullptr;\n+void\n+gst_libcamera_pad_set_stream(GstPad *pad, Stream *stream)\n+{\n+\tgst_pad_set_element_private(pad, stream);\n }\n \n void\ndiff --git a/src/gstreamer/gstlibcamerapad.h b/src/gstreamer/gstlibcamerapad.h\nindex f98b8a7f..bbd7c687 100644\n--- a/src/gstreamer/gstlibcamerapad.h\n+++ b/src/gstreamer/gstlibcamerapad.h\n@@ -33,4 +33,6 @@ void gst_libcamera_pad_set_video_info(GstPad *pad, const GstVideoInfo *info);\n \n libcamera::Stream *gst_libcamera_pad_get_stream(GstPad *pad);\n \n+void gst_libcamera_pad_set_stream(GstPad *pad, libcamera::Stream *stream);\n+\n void gst_libcamera_pad_set_latency(GstPad *pad, GstClockTime latency);\ndiff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\nindex 011a12fc..bd79b769 100644\n--- a/src/gstreamer/gstlibcamerasrc.cpp\n+++ b/src/gstreamer/gstlibcamerasrc.cpp\n@@ -357,7 +357,7 @@ int GstLibcameraSrcState::processRequest()\n \t\tGstBuffer *buffer = wrap->detachBuffer(stream);\n \n \t\tFrameBuffer *fb = gst_libcamera_buffer_get_frame_buffer(buffer);\n-\t\tconst StreamConfiguration &stream_cfg = config_->at(i);\n+\t\tconst StreamConfiguration &stream_cfg = stream->configuration();\n \t\tGstBufferPool *video_pool = gst_libcamera_pad_get_video_pool(srcpad);\n \n \t\tif (video_pool) {\n@@ -692,6 +692,9 @@ gst_libcamera_src_negotiate(GstLibcameraSrc *self)\n \t\tgst_libcamera_pad_set_pool(srcpad, pool);\n \t\tgst_libcamera_pad_set_video_pool(srcpad, video_pool);\n \n+\t\t/* Associate the configured stream with the source pad. */\n+\t\tgst_libcamera_pad_set_stream(srcpad, stream_cfg.stream());\n+\n \t\t/* Clear all reconfigure flags. */\n \t\tgst_pad_check_reconfigure(srcpad);\n \t}\n@@ -888,6 +891,7 @@ gst_libcamera_src_task_leave([[maybe_unused]] GstTask *task,\n \t\tfor (GstPad *srcpad : state->srcpads_) {\n \t\t\tgst_libcamera_pad_set_latency(srcpad, GST_CLOCK_TIME_NONE);\n \t\t\tgst_libcamera_pad_set_pool(srcpad, nullptr);\n+\t\t\tgst_libcamera_pad_set_stream(srcpad, nullptr);\n \t\t}\n \t}\n \n", "prefixes": [ "v4", "1/3" ] }