Patch Detail
Show a patch.
GET /api/1.1/patches/24952/?format=api
{ "id": 24952, "url": "https://patchwork.libcamera.org/api/1.1/patches/24952/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24952/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251103140325.88535-3-antoine.bouyer@nxp.com>", "date": "2025-11-03T14:03:25", "name": "[v4,2/2] pipeline: imx8-isi: Delay ISI routes config to acquire() time", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "1f4f451242b6757057951d214b52d4a33b1dbad3", "submitter": { "id": 218, "url": "https://patchwork.libcamera.org/api/1.1/people/218/?format=api", "name": "Antoine Bouyer", "email": "antoine.bouyer@nxp.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24952/mbox/", "series": [ { "id": 5556, "url": "https://patchwork.libcamera.org/api/1.1/series/5556/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5556", "date": "2025-11-03T14:03:23", "name": "imx8-isi: Move isi routing into acquireDevice", "version": 4, "mbox": "https://patchwork.libcamera.org/series/5556/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24952/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24952/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5263EBDE4C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 3 Nov 2025 14:02:00 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 032E160A85;\n\tMon, 3 Nov 2025 15:02:00 +0100 (CET)", "from DB3PR0202CU003.outbound.protection.outlook.com\n\t(mail-northeuropeazlp170100001.outbound.protection.outlook.com\n\t[IPv6:2a01:111:f403:c200::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EF0E660A81\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 3 Nov 2025 15:01:57 +0100 (CET)", "from GVXPR04MB9831.eurprd04.prod.outlook.com (2603:10a6:150:11c::8)\n\tby GV1PR04MB10559.eurprd04.prod.outlook.com (2603:10a6:150:20b::7)\n\twith Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9275.16;\n\tMon, 3 Nov 2025 14:01:54 +0000", "from GVXPR04MB9831.eurprd04.prod.outlook.com\n\t([fe80::4634:3d9c:c4a:641a]) by\n\tGVXPR04MB9831.eurprd04.prod.outlook.com\n\t([fe80::4634:3d9c:c4a:641a%6]) with mapi id 15.20.9275.015;\n\tMon, 3 Nov 2025 14:01:54 +0000" ], "Authentication-Results": [ "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"HCTdCSxn\";\n\tdkim-atps=neutral", "dkim=none (message not signed)\n\theader.d=none;dmarc=none action=none header.from=nxp.com;" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n\tb=MWC/955b+s+CzTqeyNE9rhgr3qLpfb43Zl9Enw/wzOkppYfBtvXhF13F/cpmdGTL5gZHpz3mYRuKbyYPAoksjB5FXd5dchs3J6uP/S+ROrK5uTLZIR5AftmLgCDwtRt7oFLu5yYUCh0lOzd4o9tCfBNIibYSYPQ32ioD4We6L5T2yWTgA84EaZWsajE66UbwTuOB1PTlCeDhz8MgoW3pyd/1kSfSqqhTS4qwfDLgywNAO5HSfDSk+O6ym/D2PGhtGrHFE/XO0L4AabriZQmogqE81EsGb/hLGvNKeDuZqp4fKWfCREYkVR9PasaTmpwjcKZY4m1iNzzH/8tpR8vABw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n\ts=arcselector10001;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n\tbh=Jya8rzY4LuRMKHF/D2ciBqbmsS+0M4efiOwPtmVkQss=;\n\tb=FkZKsn6kb16j7cYDDJUvaQXYvpeffRTdnxTbjOTFoFughNUfuvsH670bAv4PQ433WPO9ht9Op/qrwAEAE8sjAq/WTFR4U5xHgwYrUTLxt9B+uygOrocZ0y4gbkZDAz/Bt6JyBgbndUXOX3sjUZXyRbk6LjIToXkjrxaJzAygRt4tzoytJcajHL9cqL7ll+qYswee9Jk4SEzZh4UbTw2Ap63ML1LvAZ4mqNhECItSNkCqTggJYAom+Qc+VV16+Qo0PyXuMtHKdCzrE2RfzhP7jO4z8C0VPrQ46IFyPEEuhzEofq639c0vFSWXroN3kUfyT7K7Tnm8q4phIf/gv+aPzQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n\tsmtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com;\n\tdkim=pass header.d=nxp.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=Jya8rzY4LuRMKHF/D2ciBqbmsS+0M4efiOwPtmVkQss=;\n\tb=HCTdCSxnLjbdCxoBZHn8DFCI2yYSXBMJk6mL1+BuMGJW8ulI8zVut6HLF17fwrLD7xKL3NyZEeb1FDSpo6b6congrDE1nH4B8yWMQZzZ50Vp8WC7ISLFUxIeiMFaK+Rafd0KlEd3EKrpsq8/0jIbTmbher/gkVgMs4Cx3C0uCoFKFvhcTWjdSHiOzF7s9+IMn7YcJLL/ES39lsPrahAFUk3bhkO3MJsunYAD2sgJDgxIGkEtwvlnQU1aw3haFrplwnD4aEjD5S5+8+x3HaTyUoL/YZDGHALmNrtp+MUzsvRbMn6uHjYpn1GoA1UR2nfIr6S5QI6ca+lusNv17sleUw==", "From": "Antoine Bouyer <antoine.bouyer@nxp.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "julien.vuillaumier@nxp.com, Andrei Gansari <andrei.gansari@nxp.com>,\n\tAntoine Bouyer <antoine.bouyer@nxp.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v4 2/2] pipeline: imx8-isi: Delay ISI routes config to\n\tacquire() time", "Date": "Mon, 3 Nov 2025 15:03:25 +0100", "Message-Id": "<20251103140325.88535-3-antoine.bouyer@nxp.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20251103140325.88535-1-antoine.bouyer@nxp.com>", "References": "<20251103140325.88535-1-antoine.bouyer@nxp.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "CH0PR03CA0302.namprd03.prod.outlook.com\n\t(2603:10b6:610:118::24) To GVXPR04MB9831.eurprd04.prod.outlook.com\n\t(2603:10a6:150:11c::8)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "GVXPR04MB9831:EE_|GV1PR04MB10559:EE_", "X-MS-Office365-Filtering-Correlation-Id": "845100fd-bae7-4e6c-b4ab-08de1ae18b8f", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;\n\tARA:13230040|366016|19092799006|52116014|376014|1800799024|38350700014;", "X-Microsoft-Antispam-Message-Info": "VYZ7JHByUQFBR7nzLlJ3g2KwUKmsRA+zcfdkebpbSSQDoquKtMcHKeBTGbP8qVpj1qMWmgKwau5Wr15QurhlqpmpJVl4yr8lVPQuWWIJL7S9WF83sBLoVE/23J3AY5/iYrZyKzI8RXgQ0HrBZP5hRgO9HhBMFRG8s2ENncId4Y30OKDVwe0zdqCR72Wg99OJ13tQJOr399JIN2trCZxSAlZEfG5syZWqXcdqfe2s1XfqoABsVdh6ldR9LamnAHfB4t56/WGWAWXECH0UMwot9ze+x5P6cebWPYKqcGiaXr3TRPX54cECvCWxYnIk/9qaCp3fZu24BWcKIIV+F5AgTXVZG1eu89Ng3I7VzjyuLDYvda8TrGmuLXYoad94vI+2VTPdnnre4Dg3GjoL4Yb8f9TRfMOHIS0xr44Xw0mF2AVEb3cAmVtXzwen5o8Z2mVaZMM5QMlDFYhnkwHhqKTC1LaA3W4/hN5IVyGoEcJSR8n3ZyvqhkpnLXqd45UxfCMqaQzxl4Vtp94rYtzXEvNvQofvf+BuVi+8ZxAPcTrSCSVwlUR1XhxGsBYDg7TakDbHjfPLtIQ6CsyMXw717j9PTK4UKT9So/tHhjJnwWTv7Cv6NTofR8aqmbeqZYUkkSjL8zjZetlEv3oYnmo5Zj/VkVBj9JT3zjuZBGdCYLP6+aWpkxnGaIDSQPgAu0nuCtvyCA9ieI+Z/FctqyEGBT4o0sqKtcQhHYX8MHISX+59C+EH5wyqCkrPTExi0nN4gWea7+4wr8jIBqmvbYreYAD8807HwqxdbbNFkgIwmGwyxPpgmxfEhlReL050FLd87Thpzr1sP9I3T24qwlxDNNPcvHidtWA+LuV3lnnDS+TcT1D0MPABVG3UsmgxGieVNme6eaWeNwVQOaXVA9ahmPZ/a9rpZsZNCBYYVM+KRdhGv1Fffi43QKK6muNayE43rdbNuQc/mq3JsEChmbzvccUpvG2mho1OvDFA0tuI9aaT49TBeFbzd1r3H4Kq3kU+Nl+Rh687DKyY4j+V7CuBgkzMwgpo1lr78mAZKNV+d/924N2VImTTC3Yc2szsgbNj/f4HfkxnZzkZyKVy8e0XncplPNZPNJuDvGFFsXOCCVOImOlmSac/9/ksb52HSx6Y65IqJAgURAoNBZ8vbK2h7nPEcZX3q/Zsy3LVt3tUePBZ6Saq0A1Qajzic+XE6tWhoRJsyGT3oXMkx/eJswU9b79feiNwlHOMiAfo1Bupg9992KQ3Nf1JK6PRWhS9X+3HEhekDPrrC3CIIrOxsSFctUiwrISHUmgdboDlaw1oobq92aPQ64GX35yZYKbzyfg6iKoMiujoQ+Q0hzn6TF8ZXNBlDmr3APh2VpRqJ8Bvceiz6b/OhrSbkbcgLir6omAwyERoL+IGIFwXwgeG41Na9fOJfbRn6rxnPR/jNfxrGrDPPyCO4DnLtjtJKVBGCe+FBV71aKjy/w0H4Owv3B+sScCxqTpPIP9LUOIgxbBmklkyx1Ana5gZL6SXBKdod2ngYoR8", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n\tIPV:NLI; SFV:NSPM; H:GVXPR04MB9831.eurprd04.prod.outlook.com; PTR:;\n\tCAT:NONE; \n\tSFS:(13230040)(366016)(19092799006)(52116014)(376014)(1800799024)(38350700014);\n\tDIR:OUT; SFP:1101; ", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "BKOyRy0FIpbJ2P+KF6i3CoQ6fifoUARNcF8u5YxqeLZrXV9k3RFZQ4s7/hMNPsls6qQcfRBT7mYElsyrwX1wxNQPJwykf7klgaGNAftvdnctQzrPYGVOBTNMlCIcBdvwR1tSrDv/X+kRNCqGGnxp8N/xof5tToK2t+3Ee3ptoun9ZtcOe1lxydbc5OuLfPzj7v48lzbMNx3HdPUqPlWdFMC5nDxIcggJPOUBT/YsDN0FaAWK0rS3ZVzJDx6sAB01wB1vAUyJfS66o6eB5JDjC8YvV4thkgaVMAvsmgMymWebqo39k1gvYlJ2apBbo4KKG7/59KXR2cncoS0Ms5cMGQp0Vq/cozs5RjaNwa/IPFqgLDDFb7jvHMB43v1vKNhr3qELz9/R1un8hChjEBfUZt/Na7qPU4ahUyrY3Y4BjN4p377ZXRvmlaRsSz5zULJP5TJGJPRIU6RHJ45KpdvDQEysIiehMzlAtJGNFc8XFKD/00KvrkPyritb8N0zsIYkgeoGWMW/WwPylLs613hvRPg+xESw/nrMHKBwRvC9HV6XXOAbsqQemHKG1ig7wcyCrJlnyEvUkg15zEC8ymPCpnA18xu88xkXfpV8Lzjt0Bpw4mT930vY8+7DB2DeLEbzIdCGU08k26g6pmL8rc+3zsz4zIkEUVnV4dIDSKNflOKmUtJj7/m9jEy6C4zC3XJosrL6JEgYNxM3+cbMpdeD+BBoHUNIkE1pdlu1Ss0wvUmWLq69I2FzFgDViiRme1UXiRrKBekDp3a4JWvmlBGik3qdCQbYlKnljikeTl50/CfJzufLXEvXJ9aYCiNqCNaXiZu9a8hhbzytQUNYY3CK+m2I1/thNJL99bL2dvF6z77Ql3yym941u7tf5erAsuWaoeBIXljZC2g1qlgI6Mby+r1YwzInii3l+cN+EouxDb2WelAz8TivX3FRmsPlUIAE9Zy0jl/NBL1ZfCul/yfg3+ecx1BwdAxmDhyPhhLA8ADALB28ocL4Cw3ub4R1/APG7T+U/njYjtr+I139wUyvFMNLfWjzMf5OMqETtijA4k6XMGsTtfaZyPOLnxhmxGkWtBsT7GqBHUDrfgOWidME9GejEa47Se97G8J9iRwPSDqpyHvNqG2PTNJmN1IhoKM5GuslniHS39CBDbSmIVQkyj9E3uAYEVeNqZb2FARzkLIrUhIhqWgMWyt8ctweM8IXy6fZVhlbuHFS6EuSK9TWbSntVo6fhwnzrLxSK8bmUnFXImhHA3qg9DzheoCAsmfuKSV/KFSm33/mz91S/ZrYR33v1DnJlOzunP4LDUJJDEnafZjUxv+M1+K3Le5t8ScGTNS//kIuyd5+rxu/TsgNG87YOayMy5a9Da33Z/oKWTS68kKEw+kJfFtxxGSE3WX8ijWDkkWAtd+RPjK7U0Idnd5PObxHl1ijD/Jd/qdqAJ5/vE2rbWNToCu2iJOU/Za/wnBkrgxf79+UkVNRF7uVAEaPFEM+5vQckwR8A9xd2qGOzFozBnLCUVhE2U1UzP3AOnJXoj9Il1MrC3AqZdIbHuBgnKV47/FUHB34iRma3M6fUVy9x3pGP+8jxZcEEXogDhbo4MjWRnZGMOY/PiCwjA==", "X-OriginatorOrg": "nxp.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "845100fd-bae7-4e6c-b4ab-08de1ae18b8f", "X-MS-Exchange-CrossTenant-AuthSource": "GVXPR04MB9831.eurprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "03 Nov 2025 14:01:54.8086\n\t(UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "zJcXmmBqU5NfrwS/vnesvUn+94CWTNbshFpf9PIfMKtc3ZqSdkAVDiIja6V2+yWtQ0GI6KhT3HAM/P720eIQew==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "GV1PR04MB10559", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Andrei Gansari <andrei.gansari@nxp.com>\n\nFixes behavior when calling 'cam -l' during a live stream from a camera\nin another process.\n\nIssue is that multiple process should be able to list (match procedure)\nthe camera supported. But only the unique process that lock the media\ndevices in order to be able to configure then start the pipeline should\nsetup the routes, graphs, etc.\n\nThus, the setRouting() is to be moved to a PipelineHandlerISI::acquireDevice()\nimplementation to override the default Pipeline::acquireDevice() function.\n\nFixes: 92df79112fb2 (\"pipeline: imx8-isi: Add multicamera support\")\nSigned-off-by: Andrei Gansari <andrei.gansari@nxp.com>\nSigned-off-by: Antoine Bouyer <antoine.bouyer@nxp.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/pipeline/imx8-isi/imx8-isi.cpp | 30 ++++++++++++++++----\n 1 file changed, 24 insertions(+), 6 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\nindex de09431cb9b9..91541505e3ae 100644\n--- a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n+++ b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n@@ -71,6 +71,8 @@ public:\n \n \tunsigned int xbarSink_ = 0;\n \tunsigned int xbarSourceOffset_ = 0;\n+\n+\tconst std::string &cameraName() const { return sensor_->entity()->name(); }\n };\n \n class ISICameraConfiguration : public CameraConfiguration\n@@ -117,6 +119,8 @@ protected:\n \n \tint queueRequestDevice(Camera *camera, Request *request) override;\n \n+\tbool acquireDevice(Camera *camera) override;\n+\n private:\n \tstatic constexpr Size kPreviewSize = { 1920, 1080 };\n \tstatic constexpr Size kMinISISize = { 1, 1 };\n@@ -143,6 +147,8 @@ private:\n \n \tstd::unique_ptr<V4L2Subdevice> crossbar_;\n \tstd::vector<Pipe> pipes_;\n+\n+\tV4L2Subdevice::Routing routing_ = {};\n };\n \n /* -----------------------------------------------------------------------------\n@@ -950,6 +956,23 @@ int PipelineHandlerISI::queueRequestDevice(Camera *camera, Request *request)\n \treturn 0;\n }\n \n+bool PipelineHandlerISI::acquireDevice(Camera *camera)\n+{\n+\tISICameraData *data = cameraData(camera);\n+\n+\tLOG(ISI, Debug) << \"acquireDevice \" << data->cameraName()\n+\t\t\t<< \" count \" << useCount();\n+\n+\tif (useCount() == 0) {\n+\t\t/* Enable routing for all available sensors once */\n+\t\tint ret = crossbar_->setRouting(&routing_, V4L2Subdevice::ActiveFormat);\n+\t\tif (ret)\n+\t\t\treturn false;\n+\t}\n+\n+\treturn true;\n+}\n+\n bool PipelineHandlerISI::match(DeviceEnumerator *enumerator)\n {\n \tDeviceMatch dm(\"mxc-isi\");\n@@ -1034,7 +1057,6 @@ bool PipelineHandlerISI::match(DeviceEnumerator *enumerator)\n \tunsigned int numSinks = 0;\n \tconst unsigned int xbarFirstSource = crossbar_->entity()->pads().size() - pipes_.size();\n \tconst unsigned int maxStreams = pipes_.size() / cameraCount;\n-\tV4L2Subdevice::Routing routing = {};\n \n \tfor (MediaPad *pad : crossbar_->entity()->pads()) {\n \t\tunsigned int sink = numSinks;\n@@ -1104,7 +1126,7 @@ bool PipelineHandlerISI::match(DeviceEnumerator *enumerator)\n \t\t/* Add routes to the crossbar switch routing table. */\n \t\tfor (unsigned i = 0; i < data->streams_.size(); i++) {\n \t\t\tunsigned int sourcePad = xbarFirstSource + data->xbarSourceOffset_ + i;\n-\t\t\trouting.emplace_back(V4L2Subdevice::Stream{ data->xbarSink_, 0 },\n+\t\t\trouting_.emplace_back(V4L2Subdevice::Stream{ data->xbarSink_, 0 },\n \t\t\t\t\t V4L2Subdevice::Stream{ sourcePad, 0 },\n \t\t\t\t\t V4L2_SUBDEV_ROUTE_FL_ACTIVE);\n \t\t}\n@@ -1116,10 +1138,6 @@ bool PipelineHandlerISI::match(DeviceEnumerator *enumerator)\n \t\tnumCameras++;\n \t}\n \n-\tret = crossbar_->setRouting(&routing, V4L2Subdevice::ActiveFormat);\n-\tif (ret)\n-\t\treturn false;\n-\n \treturn numCameras > 0;\n }\n \n", "prefixes": [ "v4", "2/2" ] }