Patch Detail
Show a patch.
GET /api/1.1/patches/2491/?format=api
{ "id": 2491, "url": "https://patchwork.libcamera.org/api/1.1/patches/2491/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2491/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200104001414.12755-2-paul.elder@ideasonboard.com>", "date": "2020-01-04T00:14:09", "name": "[libcamera-devel,v6,1/5] libcamera: utils: Add strlcpy", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "77a60c2915381ac7b3749eb7634bee71d57ad30f", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2491/mbox/", "series": [ { "id": 599, "url": "https://patchwork.libcamera.org/api/1.1/series/599/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=599", "date": "2020-01-04T00:14:08", "name": "V4L2 compatibility layer", "version": 6, "mbox": "https://patchwork.libcamera.org/series/599/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2491/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2491/checks/", "tags": {}, "headers": { "Return-Path": "<paul.elder@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9B035605CD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 4 Jan 2020 01:14:21 +0100 (CET)", "from neptunite.amanokami.net (unknown [96.44.9.94])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 00007A3C;\n\tSat, 4 Jan 2020 01:14:20 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1578096861;\n\tbh=1lZxjm3xWwEbemKW0g/mKeNajsQnkPWILjS0yntCsFQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=AW1km2VQ828WJNe/n/paxWCxbETTt3aBK+I0vMOul73fGu/xFbAQp1ItvtddX3UP8\n\txvppbHSJauqYfOyiXR52+zHyy3N6YvDcq5AvIAZtFz5QyVqIqfp8i3i/9vD6fO67Do\n\tQojHCO9e2e4DavhNaN0Dw1zoszTmhI65ykaahetw=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 3 Jan 2020 19:14:09 -0500", "Message-Id": "<20200104001414.12755-2-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.24.1", "In-Reply-To": "<20200104001414.12755-1-paul.elder@ideasonboard.com>", "References": "<20200104001414.12755-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v6 1/5] libcamera: utils: Add strlcpy", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Sat, 04 Jan 2020 00:14:21 -0000" }, "content": "strlcpy is available in libbsd, bionic, musl, and ulibc, but not in glibc.\nInstead of checking for strlcpy availability and modifying dependencies,\nimplement it in utils, as a wrapper around strncpy.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\nNew in v6\n---\n src/libcamera/include/utils.h | 3 +++\n src/libcamera/utils.cpp | 19 +++++++++++++++++++\n 2 files changed, 22 insertions(+)", "diff": "diff --git a/src/libcamera/include/utils.h b/src/libcamera/include/utils.h\nindex a80f7d09..badc7753 100644\n--- a/src/libcamera/include/utils.h\n+++ b/src/libcamera/include/utils.h\n@@ -12,6 +12,7 @@\n #include <memory>\n #include <ostream>\n #include <string>\n+#include <string.h>\n #include <sys/time.h>\n \n #define ARRAY_SIZE(a)\t(sizeof(a) / sizeof(a[0]))\n@@ -112,6 +113,8 @@ inline _hex hex<uint64_t>(uint64_t value, unsigned int width)\n }\n #endif\n \n+size_t strlcpy(char *dst, const char *src, size_t size);\n+\n } /* namespace utils */\n \n } /* namespace libcamera */\ndiff --git a/src/libcamera/utils.cpp b/src/libcamera/utils.cpp\nindex d632f6e6..2d6e082e 100644\n--- a/src/libcamera/utils.cpp\n+++ b/src/libcamera/utils.cpp\n@@ -182,6 +182,25 @@ operator<<(std::basic_ostream<char, std::char_traits<char>> &stream, const _hex\n * otherwise. The \\a os stream configuration is not modified.\n */\n \n+/**\n+ * \\brief Copy a string with a size limit\n+ * \\param[in] dst The destination string\n+ * \\param[in] src The source string\n+ * \\param[in] size The size of the destination string\n+ *\n+ * strlcpy is available in libbsd, bionic, musl, and ulibc, but not in glibc.\n+ * Instead of checking for strlcpy availability and modifying dependencies,\n+ * it is implemented here as a wrapper around strncpy.\n+ *\n+ * \\return The size of \\a src\n+ */\n+size_t strlcpy(char *dst, const char *src, size_t size)\n+{\n+\tstrncpy(dst, src, size);\n+\tdst[size - 1] = '\\0';\n+\treturn strlen(src);\n+}\n+\n } /* namespace utils */\n \n } /* namespace libcamera */\n", "prefixes": [ "libcamera-devel", "v6", "1/5" ] }