Patch Detail
Show a patch.
GET /api/1.1/patches/24855/?format=api
{ "id": 24855, "url": "https://patchwork.libcamera.org/api/1.1/patches/24855/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24855/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251028170847.2673396-3-rui.wang@ideasonboard.com>", "date": "2025-10-28T17:08:32", "name": "[v1,03/16] ipa: rkisp1: algorithms: add Denoise state toggles", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "31ef706078e575f18247a564e6cb6546559b483b", "submitter": { "id": 241, "url": "https://patchwork.libcamera.org/api/1.1/people/241/?format=api", "name": "Rui Wang", "email": "rui.wang@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24855/mbox/", "series": [ { "id": 5539, "url": "https://patchwork.libcamera.org/api/1.1/series/5539/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5539", "date": "2025-10-28T17:08:30", "name": "[v1,01/16] ipa: rkisp1: algorithms: add Denoise base class shell", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5539/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24855/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24855/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3D218BE080\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 28 Oct 2025 17:09:10 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C8B75607F9;\n\tTue, 28 Oct 2025 18:09:09 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 569A0607F9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 28 Oct 2025 18:09:07 +0100 (CET)", "from rui-Precision-7560.local (unknown [209.216.122.90])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 50FEB16CD;\n\tTue, 28 Oct 2025 18:07:18 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"q9fZfeUd\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761671238;\n\tbh=SsvWV+xB3JRGT/WULtXjRSmec9iz3gykbMx1sCx7sMg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=q9fZfeUd2LjzQIwOw/zso8WqbGz9MnZw6n0hPKCiAhvDO+QQY3cU47FYut6Ae022z\n\talgfT4q31DigwJar7Nn2YYY32GWkqOWRZd3r/W6SKABDP+SAInoOrFo2qk+4LYqbyr\n\t7ZVOUKtUkfmHZzbapTaYlbzmqqWFT8dAykTTMyNk=", "From": "Rui Wang <rui.wang@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Rui Wang <rui.wang@ideasonboard.com>", "Subject": "[PATCH v1 03/16] ipa: rkisp1: algorithms: add Denoise state toggles", "Date": "Tue, 28 Oct 2025 13:08:32 -0400", "Message-ID": "<20251028170847.2673396-3-rui.wang@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20251028170847.2673396-1-rui.wang@ideasonboard.com>", "References": "<20251028170847.2673396-1-rui.wang@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add state management helpers to DenoiseBaseAlgorithm:\n- EnableState struct to track enable/disable state changes\n- processEnableToggle() to detect state transitions\n- Manual mode setters/getters (setManualMode, isManualMode)\n- Developer mode setters/getters (setDevMode, isDevMode)\n- Private member variables for mode tracking\n\nThese helpers provide shared state management for derived DPF and\nFilter algorithms.\n\nSigned-off-by: Rui Wang <rui.wang@ideasonboard.com>\n---\n src/ipa/rkisp1/algorithms/denoise.h | 31 ++++++++++++++++++++---------\n 1 file changed, 22 insertions(+), 9 deletions(-)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/denoise.h b/src/ipa/rkisp1/algorithms/denoise.h\nindex d97301f0..f40e5aa1 100644\n--- a/src/ipa/rkisp1/algorithms/denoise.h\n+++ b/src/ipa/rkisp1/algorithms/denoise.h\n@@ -15,27 +15,40 @@ namespace libcamera {\n \n namespace ipa::rkisp1::algorithms {\n \n-/**\n- * \\class DenoiseBaseAlgorithm\n- * \\brief Base class for RkISP1 denoising algorithms\n- *\n- * This abstract base class provides common functionality for denoising algorithms\n- * in the RkISP1 Image Processing Algorithm (IPA).\n- *\n- * Derived classes must implement algorithm-specific behavior.\n- */\n class DenoiseBaseAlgorithm : public ipa::rkisp1::Algorithm\n {\n protected:\n \tDenoiseBaseAlgorithm() = default;\n \t~DenoiseBaseAlgorithm() = default;\n+\tstruct EnableState {\n+\t\tbool enabled = true; /**< Current enable state */\n+\t\tbool lastEnabled = true; /**< Previous enable state for change detection */\n+\t};\n+\tbool processEnableToggle(bool value, EnableState &state);\n+\n+\tvoid setManualMode(bool manual) { manualMode_ = manual; }\n+\n+\tvoid setDevMode(bool dev) { devMode_ = dev; }\n \n+\tbool isManualMode() const { return manualMode_; }\n+\tbool isDevMode() const { return devMode_; }\n \tunsigned computeIso(const IPAContext &context,\n \t\t\t const IPAFrameContext &frameContext) const;\n \ttemplate<typename LevelContainer>\n \tint selectIsoBand(unsigned iso, const LevelContainer &levels) const;\n+\n+private:\n+\tbool manualMode_ = false; /**< Current manual/auto mode state */\n+\tbool devMode_ = false; /**< Developer mode state for advanced controls */\n };\n \n+inline bool DenoiseBaseAlgorithm::processEnableToggle(bool value, EnableState &state)\n+{\n+\tstate.lastEnabled = state.enabled;\n+\tstate.enabled = value;\n+\treturn state.enabled != state.lastEnabled;\n+}\n+\n inline unsigned DenoiseBaseAlgorithm::computeIso(const IPAContext &context,\n \t\t\t\t\t\t const IPAFrameContext &frameContext) const\n {\n", "prefixes": [ "v1", "03/16" ] }