Patch Detail
Show a patch.
GET /api/1.1/patches/24787/?format=api
{ "id": 24787, "url": "https://patchwork.libcamera.org/api/1.1/patches/24787/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24787/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251024085130.995967-22-stefan.klug@ideasonboard.com>", "date": "2025-10-24T08:50:45", "name": "[v1,21/35] libcamera: v4l2_videodevice: Do not hide frame drops", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "bc0b92fba53590d761a6026ceaa995494d1fdeaf", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24787/mbox/", "series": [ { "id": 5524, "url": "https://patchwork.libcamera.org/api/1.1/series/5524/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5524", "date": "2025-10-24T08:50:24", "name": "rkisp1: pipeline rework for PFC", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5524/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24787/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24787/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B8648C3259\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 24 Oct 2025 08:52:42 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7A0D3608DE;\n\tFri, 24 Oct 2025 10:52:42 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C7F71608C7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 24 Oct 2025 10:52:40 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:7edc:62f4:c118:1549])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 50CF22363; \n\tFri, 24 Oct 2025 10:50:55 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"p9Xl02pI\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761295855;\n\tbh=+A7vLf/5UBvL9imx4XgnsJtAZ49G47f8GYrh/QP/5sg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=p9Xl02pIQTYk66lbfAA3qiHK4EPQyLHlsc3JtLpLJQ1+w1ptPp076FjV/Z+2HD5rg\n\t1YDJQ96p435adQ1HXB1G9uFqCuRFzNL0VYLk2BLN9uz5TbJfTgSWgU2xhz03PrD9hr\n\tDTz5T7QV1+RkHm7yRtrX8wbnV7dWG5M/ASmmqzzo=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>,\n\tJacopo Mondi <jacopo.mondi@ideasonboard.com>", "Subject": "[PATCH v1 21/35] libcamera: v4l2_videodevice: Do not hide frame\n\tdrops", "Date": "Fri, 24 Oct 2025 10:50:45 +0200", "Message-ID": "<20251024085130.995967-22-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.48.1", "In-Reply-To": "<20251024085130.995967-1-stefan.klug@ideasonboard.com>", "References": "<20251024085130.995967-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n\nWe want to be able to identify them correctly.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n include/libcamera/internal/v4l2_videodevice.h | 1 -\n src/libcamera/v4l2_videodevice.cpp | 15 ---------------\n 2 files changed, 16 deletions(-)", "diff": "diff --git a/include/libcamera/internal/v4l2_videodevice.h b/include/libcamera/internal/v4l2_videodevice.h\nindex 2d290971a0ee..a19fca1719d3 100644\n--- a/include/libcamera/internal/v4l2_videodevice.h\n+++ b/include/libcamera/internal/v4l2_videodevice.h\n@@ -286,7 +286,6 @@ private:\n \tEventNotifier *fdBufferNotifier_;\n \n \tState state_;\n-\tstd::optional<unsigned int> firstFrame_;\n \n \tTimer watchdog_;\n \tutils::Duration watchdogDuration_;\ndiff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\nindex 8ce739f4bc65..56a9f0ab546f 100644\n--- a/src/libcamera/v4l2_videodevice.cpp\n+++ b/src/libcamera/v4l2_videodevice.cpp\n@@ -1904,19 +1904,6 @@ FrameBuffer *V4L2VideoDevice::dequeueBuffer()\n \tif (V4L2_TYPE_IS_OUTPUT(buf.type))\n \t\treturn buffer;\n \n-\t/*\n-\t * Detect kernel drivers which do not reset the sequence number to zero\n-\t * on stream start.\n-\t */\n-\tif (!firstFrame_.has_value()) {\n-\t\tif (buf.sequence)\n-\t\t\tLOG(V4L2, Info)\n-\t\t\t\t<< \"Zero sequence expected for first frame (got \"\n-\t\t\t\t<< buf.sequence << \")\";\n-\t\tfirstFrame_ = buf.sequence;\n-\t}\n-\tmetadata.sequence -= firstFrame_.value();\n-\n \tSpan<const FrameBuffer::Plane> framebufferPlanes = buffer->planes();\n \tunsigned int numV4l2Planes = multiPlanar ? buf.length : 1;\n \n@@ -1993,8 +1980,6 @@ int V4L2VideoDevice::streamOn()\n {\n \tint ret;\n \n-\tfirstFrame_.reset();\n-\n \tret = ioctl(VIDIOC_STREAMON, &bufferType_);\n \tif (ret < 0) {\n \t\tLOG(V4L2, Error)\n", "prefixes": [ "v1", "21/35" ] }