Patch Detail
Show a patch.
GET /api/1.1/patches/24749/?format=api
{ "id": 24749, "url": "https://patchwork.libcamera.org/api/1.1/patches/24749/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24749/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251023144841.403689-23-stefan.klug@ideasonboard.com>", "date": "2025-10-23T14:48:23", "name": "[v2,22/35] libcamera: rkisp1: Use the dw100 class instead of the generic v4l2 converter", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "b3d2e11b0b9c491195235fc0ae4a7f1d7a9aa83c", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24749/mbox/", "series": [ { "id": 5520, "url": "https://patchwork.libcamera.org/api/1.1/series/5520/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5520", "date": "2025-10-23T14:48:01", "name": "Full dewarper support on imx8mp", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5520/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24749/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24749/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1D973C333F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 23 Oct 2025 14:49:53 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7EE3060837;\n\tThu, 23 Oct 2025 16:49:53 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A49896082F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 23 Oct 2025 16:49:52 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:7328:357b:4ce1:72b6])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id AF56B1127; \n\tThu, 23 Oct 2025 16:48:07 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"c4nnMWGO\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761230887;\n\tbh=B3Raujcg+ETvVR9IhtXNlejI19RXE7D07mOmJSXM8nY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=c4nnMWGOZPEu3fGzEWV92VvMrZKv5+cx0tWqxLlFBfnVK2w/8KN22LNEe5JLye2Sx\n\tZyx5pit+T/faI7AvplZ3gJz+k8tdRGlP4GrVIZA0MT5dFYnpMpOIm0HXiecKs3AJO6\n\t4OwMpu/UTD9Gl0799+QYnDwvjquzUw2VyfiHKs8w=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH v2 22/35] libcamera: rkisp1: Use the dw100 class instead of\n\tthe generic v4l2 converter", "Date": "Thu, 23 Oct 2025 16:48:23 +0200", "Message-ID": "<20251023144841.403689-23-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.48.1", "In-Reply-To": "<20251023144841.403689-1-stefan.klug@ideasonboard.com>", "References": "<20251023144841.403689-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "To be able to access the dw100 specific functions and as there is no\nknown other dewarper in combination with the rkisp1, use the dw100\nspecific converter directly.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 77442b25b809..e22f05408931 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -36,7 +36,7 @@\n #include \"libcamera/internal/camera.h\"\n #include \"libcamera/internal/camera_sensor.h\"\n #include \"libcamera/internal/camera_sensor_properties.h\"\n-#include \"libcamera/internal/converter/converter_v4l2_m2m.h\"\n+#include \"libcamera/internal/converter/converter_dw100.h\"\n #include \"libcamera/internal/delayed_controls.h\"\n #include \"libcamera/internal/device_enumerator.h\"\n #include \"libcamera/internal/framebuffer.h\"\n@@ -234,7 +234,7 @@ private:\n \tRkISP1MainPath mainPath_;\n \tRkISP1SelfPath selfPath_;\n \n-\tstd::unique_ptr<V4L2M2MConverter> dewarper_;\n+\tstd::unique_ptr<ConverterDW100> dewarper_;\n \tRectangle scalerMaxCrop_;\n \n \tstd::optional<Rectangle> activeCrop_;\n@@ -1500,7 +1500,7 @@ bool PipelineHandlerRkISP1::match(DeviceEnumerator *enumerator)\n \n \tstd::shared_ptr<MediaDevice> dwpMediaDevice = enumerator->search(dwp);\n \tif (dwpMediaDevice) {\n-\t\tdewarper_ = std::make_unique<V4L2M2MConverter>(dwpMediaDevice);\n+\t\tdewarper_ = std::make_unique<ConverterDW100>(dwpMediaDevice);\n \t\tif (dewarper_->isValid()) {\n \t\t\tdewarper_->outputBufferReady.connect(\n \t\t\t\tthis, &PipelineHandlerRkISP1::dewarpBufferReady);\n", "prefixes": [ "v2", "22/35" ] }