Patch Detail
Show a patch.
GET /api/1.1/patches/24723/?format=api
{ "id": 24723, "url": "https://patchwork.libcamera.org/api/1.1/patches/24723/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24723/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251023105651.78395-3-isaac.scott@ideasonboard.com>", "date": "2025-10-23T10:56:49", "name": "[2/4] libcamera: controls: Add CAMERA_MODULE_IDENTIFIER", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "3e579d6a3ec36818bb90d438e037c02160cab756", "submitter": { "id": 215, "url": "https://patchwork.libcamera.org/api/1.1/people/215/?format=api", "name": "Isaac Scott", "email": "isaac.scott@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24723/mbox/", "series": [ { "id": 5518, "url": "https://patchwork.libcamera.org/api/1.1/series/5518/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5518", "date": "2025-10-23T10:56:47", "name": "libcamera: controls: Add support for camera module identifiers", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5518/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24723/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24723/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2B788C3331\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 23 Oct 2025 10:57:09 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0DFDB607DD;\n\tThu, 23 Oct 2025 12:57:09 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2358F607B3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 23 Oct 2025 12:57:05 +0200 (CEST)", "from isaac-ThinkPad-T16-Gen-2.infra.iob\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 32D77591;\n\tThu, 23 Oct 2025 12:55:20 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"uHcool1f\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761216920;\n\tbh=ZT1EbruWzhvbayV7rJvu0dBT8JZzRGSCkee99VVXE7c=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=uHcool1fG/oo10GjCpkZByzum5WgJIhLJ9OY7XkyCT3Lk8i/58hQqOvm2UvpAYnWL\n\tY/uGZp2WEUKQtfn0QQAusTfGTJoQqxdYbiPPtnU39MauPkkud6tbvzTMfvs2rgnEzU\n\tzP0xW6d7T8vhMWcUzVyYG8goZSFAzPNfU4PUH9fc=", "From": "Isaac Scott <isaac.scott@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Isaac Scott <isaac.scott@ideasonboard.com>", "Subject": "[PATCH 2/4] libcamera: controls: Add CAMERA_MODULE_IDENTIFIER", "Date": "Thu, 23 Oct 2025 11:56:49 +0100", "Message-ID": "<20251023105651.78395-3-isaac.scott@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20251023105651.78395-1-isaac.scott@ideasonboard.com>", "References": "<20251023105651.78395-1-isaac.scott@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a string control, and the necessary V4L2_CID to support a read-only\nstring payload. This can be used to store a string identifying a variant\nof a camera sensor (more accurately, a unique module including that\ncamera sensor).\n\nThe addition to v4l2-controls.h to add V4L2_CID_CAMERA_MODULE_IDENTIFIER has\nbeen posted upstream here:\n\nhttps://lore.kernel.org/linux-media/aPi9c_c9f0dkduLA@kekkonen.localdomain/\n\nSigned-off-by: Isaac Scott <isaac.scott@ideasonboard.com>\n---\n include/linux/v4l2-controls.h | 2 ++\n src/libcamera/property_ids_core.yaml | 8 ++++++++\n 2 files changed, 10 insertions(+)", "diff": "diff --git a/include/linux/v4l2-controls.h b/include/linux/v4l2-controls.h\nindex 4cfae0414..b96142c46 100644\n--- a/include/linux/v4l2-controls.h\n+++ b/include/linux/v4l2-controls.h\n@@ -1095,6 +1095,8 @@ enum v4l2_auto_focus_range {\n \n #define V4L2_CID_HDR_SENSOR_MODE\t\t(V4L2_CID_CAMERA_CLASS_BASE+36)\n \n+#define V4L2_CID_CAMERA_MODULE_IDENTIFIER\t(V4L2_CID_CAMERA_CLASS_BASE+37)\n+\n /* FM Modulator class control IDs */\n \n #define V4L2_CID_FM_TX_CLASS_BASE\t\t(V4L2_CTRL_CLASS_FM_TX | 0x900)\ndiff --git a/src/libcamera/property_ids_core.yaml b/src/libcamera/property_ids_core.yaml\nindex 834454a4e..5f47a4ea7 100644\n--- a/src/libcamera/property_ids_core.yaml\n+++ b/src/libcamera/property_ids_core.yaml\n@@ -701,4 +701,12 @@ controls:\n \n Different cameras may report identical devices.\n \n+ - CameraModuleIdentifier:\n+ type: string\n+ description: |\n+ Specify the camera module identifier.\n+\n+ The camera module identifier is a string that uniquely identifies the\n+ camera module. It is used to select the appropriate tuning file for\n+ the camera device.\n ...\n", "prefixes": [ "2/4" ] }