Patch Detail
Show a patch.
GET /api/1.1/patches/24703/?format=api
{ "id": 24703, "url": "https://patchwork.libcamera.org/api/1.1/patches/24703/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24703/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251017154412.41430-1-mzamazal@redhat.com>", "date": "2025-10-17T15:44:12", "name": "libcamera: software_isp: Apply CCM swap also on green", "commit_ref": "06aee9135f9fd135a8c0bc0b55971b29f7617d02", "pull_url": null, "state": "accepted", "archived": false, "hash": "61e45956d04417de2060864b0fe04a55daa32429", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/1.1/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24703/mbox/", "series": [ { "id": 5510, "url": "https://patchwork.libcamera.org/api/1.1/series/5510/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5510", "date": "2025-10-17T15:44:12", "name": "libcamera: software_isp: Apply CCM swap also on green", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5510/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24703/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24703/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A87A5C3259\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 17 Oct 2025 15:44:25 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A5C5A606CD;\n\tFri, 17 Oct 2025 17:44:24 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 17AF1606B2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 17 Oct 2025 17:44:21 +0200 (CEST)", "from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-37-uy8C7I27PwOgUxFTeGyRQw-1;\n\tFri, 17 Oct 2025 11:44:18 -0400", "from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.17])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS\n\tid 9700F1956094 for <libcamera-devel@lists.libcamera.org>;\n\tFri, 17 Oct 2025 15:44:17 +0000 (UTC)", "from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.45.224.66])\n\tby mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 6F5291956056; Fri, 17 Oct 2025 15:44:16 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"LzvYrbkE\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1760715860;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding;\n\tbh=NAGMMrq8fYXVMiA0fQOwHuXILdPRnvAZ68a+RO/iZxo=;\n\tb=LzvYrbkETGQykMeJRA+Sw8EH3rrP085hZOUpR3exhyV6ldHwGOLAhs5Bc/J7Ld6Tgw+0Bi\n\teHWO4st/xrFsMCS61DmMfY0WgXhEcmyAxNvNaEdUcXHvdcKu8oil8OP5RAQ0snmLK69RH5\n\tq7LRDPIl3JUVsdXmgY0LVBTOFCuepNg=", "X-MC-Unique": "uy8C7I27PwOgUxFTeGyRQw-1", "X-Mimecast-MFC-AGG-ID": "uy8C7I27PwOgUxFTeGyRQw_1760715857", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>", "Subject": "[PATCH] libcamera: software_isp: Apply CCM swap also on green", "Date": "Fri, 17 Oct 2025 17:44:12 +0200", "Message-ID": "<20251017154412.41430-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.17", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "C7_bBpeCAX1qIZGhCqh1lQB3mD3w76xFxnzInCYyIkE_1760715857", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When CPU ISP is asked to apply the CCM matrix\n\n [0 1 0]\n [0 0 0]\n [0 0 0]\n\nfor a format that requires swapping red and blue channels, the resulting\nimage has a wrong colour. The CCM matrix above should take green from\npixels and make it red. Instead, the image is blue.\n\nThe problem is that the lookup tables setup in CPU debayering swaps red\nand blue in the lookup tables for red and blue, but not for green. The\ncolours must be swapped also in the lookup table for green, which this\npatch adds.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/libcamera/software_isp/debayer_cpu.cpp | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/src/libcamera/software_isp/debayer_cpu.cpp b/src/libcamera/software_isp/debayer_cpu.cpp\nindex c2fb11bae..67a303c65 100644\n--- a/src/libcamera/software_isp/debayer_cpu.cpp\n+++ b/src/libcamera/software_isp/debayer_cpu.cpp\n@@ -803,6 +803,7 @@ void DebayerCpu::process(uint32_t frame, FrameBuffer *input, FrameBuffer *output\n \t\tblueCcm_ = params.redCcm;\n \t\tfor (unsigned int i = 0; i < 256; i++) {\n \t\t\tstd::swap(redCcm_[i].r, redCcm_[i].b);\n+\t\t\tstd::swap(greenCcm_[i].r, greenCcm_[i].b);\n \t\t\tstd::swap(blueCcm_[i].r, blueCcm_[i].b);\n \t\t}\n \t} else {\n", "prefixes": [] }