Patch Detail
Show a patch.
GET /api/1.1/patches/24684/?format=api
{ "id": 24684, "url": "https://patchwork.libcamera.org/api/1.1/patches/24684/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24684/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251015012251.17508-40-bryan.odonoghue@linaro.org>", "date": "2025-10-15T01:22:51", "name": "[v3,39/39] libcamera: software_isp: Add a gpuisp todo list", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "f01a647225d31b1e58537e0a907e0236cc568a95", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/1.1/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24684/mbox/", "series": [ { "id": 5503, "url": "https://patchwork.libcamera.org/api/1.1/series/5503/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5503", "date": "2025-10-15T01:22:12", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5503/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24684/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24684/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 96ACDC3331\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 15 Oct 2025 01:23:49 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0ECDD60693;\n\tWed, 15 Oct 2025 03:23:49 +0200 (CEST)", "from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com\n\t[IPv6:2a00:1450:4864:20::62c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 40EE460677\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 15 Oct 2025 03:23:35 +0200 (CEST)", "by mail-ej1-x62c.google.com with SMTP id\n\ta640c23a62f3a-b48d8deafaeso1242439466b.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 14 Oct 2025 18:23:35 -0700 (PDT)", "from inspiron14p-linux.nxsw.local (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-b5ccd7b202dsm98348466b.82.2025.10.14.18.23.33\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 14 Oct 2025 18:23:33 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"xrsXp1TH\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1760491414; x=1761096214;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=vWBqVaFe6+Z55hicVVGDke3oD9foA7KiH/lYfdfC2lw=;\n\tb=xrsXp1THbMSb4H/MpIJLQS4sRmGDNXANlYFOpQYDl19MEKi0WqwaBavljdD8Ru9rd7\n\tLoJGCPsyldlf2oDpc3b15QTUrd69rPoYNMO37hOyU9iTs3SFKhHJlH3rFER3Sa1DF/PE\n\tM+eX0vvC7kYR6re1capm/uWY9djhHoEpfeC5V2dtxYBlCafCYcc//r4OKdI2xyyvvItX\n\tSpJO/1RQjDRZifWB4sx+uQ+6WHAjfPt9e6mxaMRgIJbY1aknN/OI22kqG+S1i+0aGLZo\n\tKZGtfCNFzyAAi7AQTqFqy0kXawJDx3wtesrZy2iMguwd62Z8lU5D8GoOpLcD+aUn0uFw\n\tNPGg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1760491414; x=1761096214;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=vWBqVaFe6+Z55hicVVGDke3oD9foA7KiH/lYfdfC2lw=;\n\tb=QFtW5hl7fTMQuaXe3zYGBFVjjf62YHApzVRqfmniSp+heLXBIhqjqpu/8dt2WXA6+D\n\tXYhns+1CkOV8zhGv/zjWyI6jLpQPokcP2c47IxEWdj/bTa6AHwVl3qIDPJkvoekCXm51\n\t2qyhEbqTcYK20y8hXlrbwvxseO0ITxbQBS6eK98FfRKQsqRE8snGkikV7rqz3UfNQzD+\n\tx/UWSpY4cSR7Cw24eyUz5pkxFPXimc1Ic7mICa1QEbbpNTyXjtQYXRWg1NOzv/GUp+Wn\n\tDU70g0ZSb73gqeJ9JIf4Oq/uz2beKqB7sYLEjVa9RltefMEWj0uTWThAhPdK4olJtfuq\n\t2fTw==", "X-Gm-Message-State": "AOJu0YyMgYWTu3VNpxzR2gSbvQ6AM8OABqnwBRLkK33LAMx4LM8fwp65\n\tIW1j85sV754VJJ9a6pXLl6rk5yRbQol7duFvM2eaG0Bm/4vxKjgPIiAsPOEgwPDpZIyWXQaieNs\n\tPE8oo", "X-Gm-Gg": "ASbGnctL8AArHkZDLp9SKRW0yGl8A17BffvchQmWgHwuM9tx0EHgWOBR7E+5pyslVmi\n\teks4+U7Q0LcZU1ojHOd6ahJm1bqgYwynI4Y4sCjv6bOTtOLnaiDfTB3/Q+8fVKLlaU6UPqjsuyk\n\tzkFAdiKrdyEW6kbA01gpA/8ACxz2AYy1SdvOIrs/ZkGtobqymQXiYzhZL/OTQncC1Q1sjKZksqJ\n\tklviaKnlTEIvSgvtlpZ2LyVCFhP7ISNv/YzFKDJm5aKk1WDCkpQrhxLsPrIVox2uiAsz6WYPlas\n\tm/9oQUnBr1DZnsoTl7+ZD4Vj/hvwawIx6/pyAJJBbRb7GtNE/tJMyTqmheTwHf1UDgIGwcQJNCj\n\t96PazAPy3RKBIKBA28vJLQ1bEAs1FHRtLMyH9ywE/SsYTI7ZcSGTYHwglRL+tOyk2ropR2Q2E87\n\tcwestSTaHiRtCY1UnM3W/YpxmcH/YajtbDpCsJu230", "X-Google-Smtp-Source": "AGHT+IEQU46biLgCtkvKLNH2VkF99O8caZLeOx8kDAz3Q/h7/6hShQeungPCg8sMoyi9Hr//2LpDxA==", "X-Received": "by 2002:a17:906:7949:b0:b04:25e6:2dbe with SMTP id\n\ta640c23a62f3a-b50acb0bdc5mr2844157566b.63.1760491414429; \n\tTue, 14 Oct 2025 18:23:34 -0700 (PDT)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "hdegoede@redhat.com, mzamazal@redhat.com, bryan.odonoghue@linaro.org,\n\tbod.linux@nxsw.ie", "Subject": "[PATCH v3 39/39] libcamera: software_isp: Add a gpuisp todo list", "Date": "Wed, 15 Oct 2025 02:22:51 +0100", "Message-ID": "<20251015012251.17508-40-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20251015012251.17508-1-bryan.odonoghue@linaro.org>", "References": "<20251015012251.17508-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "List the series of things to do in GPU ISP in perceived order of\ndifficulty.\n\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/software_isp/gpuisp-todo.txt | 83 ++++++++++++++++++++++\n 1 file changed, 83 insertions(+)\n create mode 100644 src/libcamera/software_isp/gpuisp-todo.txt", "diff": "diff --git a/src/libcamera/software_isp/gpuisp-todo.txt b/src/libcamera/software_isp/gpuisp-todo.txt\nnew file mode 100644\nindex 00000000..768dcc32\n--- /dev/null\n+++ b/src/libcamera/software_isp/gpuisp-todo.txt\n@@ -0,0 +1,83 @@\n+List the TODOs in perceived order of ease.\n+\n+Version 3:\n+Use dma-buf handle to generate upload texture:\n+\t- eglCreateImageKHR can be used to generate the upload texture i.e.\n+\t to feed the bayer data into the GPU.\n+\n+Denoising:\n+\t- As below still TBD\n+\n+Dead pixel correction:\n+\t- As below still TBD\n+\n+Lense shading correction:\n+\t- This is WIP but as yet still TBD\n+\n+Lense flare correction:\n+\t- Not WIP still TBD\n+\n+processFrame() to run in its own thread:\n+\t- processFrame() runs in the context of the Debayer::process()\n+\t thread. Robert Mader suggested and it seems like a good\n+\t suggestion too to run processFrame() in its own thread.\n+\n+Version 2:\n+Make GPUISP default:\n+\t- Right now the environment variable allows over-riding to swtich\n+\t from CPU to GPU.\n+\t- Once we support 24 BPP output on GPUISP we will have the same\n+\t pixel format support as CPU and can set the default to GPU without\n+\t regressing functionality\n+\n+glTexture1D:\n+\t- Initial code was developed for < GLES 2.O but since we have fixed\n+\t on GLES >= 2.0 this means we can use glTexture1D\n+\t- Provided this is so amend the shaders to do val = texture(x, y, 0);\n+\t not texture(x, y, 0.5) the 0.5 is because of using glTexture2D\n+\n+Denoising:\n+\t- Run a denoise algorithm in the shaders\n+\t- Supply a control to influence the noise-floor ?\n+\n+Dead pixel correction:\n+\t- Add logic to correct dead pixels in the fragment shaders\n+\n+Version 1:\n+24 bit output support:\n+\t- Take the BPP we already capture and get a 24 bit GBM surface\n+\t- Pass a compile-time parameter to the shaders to tell them to do\n+\t gl_FragColor = rgb not gl_FragColor = rgba\n+\t- Version 2:\n+\t This is not possible.\n+\t gl_FragColor expects vec4 not vec3 on the output.\n+\t If you really want RGB888 run cpuisp.\n+\n+Surfaceless GBM:\n+\t- We get a GBM surface and then have to swap buffers\n+\t If we rework for surfaceless GBM and EGL then the swap buffer can\n+\t be dropped.\n+\t- Version 2:\n+\t Complete GBM surface removed, memcpy() phase removed also\n+\n+dma-buf texture upload:\n+\t- Currently we pass the input buffer to glCreateTexture2D.\n+\t We should be able to make the upload of the input buffer go faster\n+\t by using eglCreateImageKHR and enumerated the dma-buf contents.\n+\t- Version 2:\n+\t Complete sm8250 test platform shows 20x performance increase\n+\t with CCM.\n+\n+Render-to-texture:\n+\t- Right now we render to the GBM provided surface framebuffer\n+\t and then memcpy from that buffer to the target output buffer.\n+\t This necessitates flushing the cache on the target buffer in\n+\t addition to the memcpy().\n+\t- Render-to-texture where we generate the target framebuffer\n+\t directly from a dma-buf handle will mitigate the memcpy() phase.\n+\t- It should be the case then that the consumer of the output buffer\n+\t i.e. the thing that's not libcamera is responsible to flush the cache\n+\t if-and-only-if that user writes to the buffer.\n+\t- We need to flush the cache on the buffer because we are memcpying() to it.\n+\t- Version 2:\n+\t Done in version 2\n", "prefixes": [ "v3", "39/39" ] }