Patch Detail
Show a patch.
GET /api/1.1/patches/24680/?format=api
{ "id": 24680, "url": "https://patchwork.libcamera.org/api/1.1/patches/24680/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24680/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251015012251.17508-36-bryan.odonoghue@linaro.org>", "date": "2025-10-15T01:22:47", "name": "[v3,35/39] libcamera: software_isp: debayer_egl: Make gpuisp default softisp mode", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "002007a9212a1baac5762bcc194153c71830726f", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/1.1/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24680/mbox/", "series": [ { "id": 5503, "url": "https://patchwork.libcamera.org/api/1.1/series/5503/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5503", "date": "2025-10-15T01:22:12", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5503/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24680/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24680/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 79570C3338\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 15 Oct 2025 01:23:46 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 077D860685;\n\tWed, 15 Oct 2025 03:23:46 +0200 (CEST)", "from mail-ej1-x632.google.com (mail-ej1-x632.google.com\n\t[IPv6:2a00:1450:4864:20::632])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 521CA6066B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 15 Oct 2025 03:23:31 +0200 (CEST)", "by mail-ej1-x632.google.com with SMTP id\n\ta640c23a62f3a-b54f55a290cso845497766b.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 14 Oct 2025 18:23:31 -0700 (PDT)", "from inspiron14p-linux.nxsw.local (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-b5ccd7b202dsm98348466b.82.2025.10.14.18.23.29\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 14 Oct 2025 18:23:30 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"WX4v6XQe\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1760491410; x=1761096210;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=jGlXm/7XgWsn9FwtAXFr/l1QF6QrEX1+nuiuAdNesgo=;\n\tb=WX4v6XQeCmI7CY5heHP43qv6gmgcXwkZatENA7d2vz8N3vMj/SJit0zLSsu+CMX3I/\n\t2uBu8OxtiE7edw4wgfldtUQ/u3vlVG+UoYw76Px0L0X/1001dEH97h/YlL/bc057qTWT\n\tP0A2Qzw6B6qEMDmCJsEN3wyRrAX6hC4UpYK75CwAYRNaWFIfveQd3L+hE1PUyYJT9ZT/\n\tcztxM4G+pvCwOxRfZSvHyBLhGtS4CT7Ad0PHAxsSbi5LAmnYxFVAEqGLl9Vltl8iL/Vp\n\tGdo58fckSNYjOKXmu+8uHGYxNvbwv+EpVzihyhqaRfNFl5uUElGXvwz2Rm1E98d1zxh4\n\ttV5g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1760491410; x=1761096210;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=jGlXm/7XgWsn9FwtAXFr/l1QF6QrEX1+nuiuAdNesgo=;\n\tb=TjM6vC91GCPtxHOjReFQCy1jr7Pxu6varIXp0HtOhYLcYQTs3SMb1T0v99D9i7lJnm\n\tL5PhxUwq1V4qM8y78OuOYmxGfrIvq2qXsbE78p/YTioc33xHCsGSWq8u2C0sAbKS/Dqc\n\trlytRTVvF9BCQwCA7sASnkah1B9UR2xPpNuPouTgq2RwD0KorKTpa0YELEK4pmhJ7Jvm\n\tIG4MOZ2Am2wrySlVTxbd13ICoDq8y2MIALGZb2tWCiwVF+SYl24q0ggTQDMRXNx9iLGv\n\t214F1h8Fsuol3PHwfs4xP47O3w0B+QEli2MLvTtVHx/kcJRc0hhLCvTLsoqGz8RfkZJd\n\tJFzg==", "X-Gm-Message-State": "AOJu0Ywp4FUoo6zfPhi+wEtdsdH0ejZ9IvBUDQIXrs8uhEHFsVP4+btS\n\t1oc2pdvjADXEstlWLiUWh/EE/1UIZ7rGSSLx3Rbq/f3dV6xRnXO+fFsppwbVCtWb1T4Lhu1wdWE\n\tbEOeB", "X-Gm-Gg": "ASbGnctG5XWfCDXF+AXlpthG6iFzfpmkm6LoAWtNbaT2qV7tDuLvLGikbU6fPf73lu4\n\tt79hRtwX6BqzI9Kh7S9Xe+HmOImNFyy5fimDZpxOLjgjisfF0/vSH/st0o2CJorDhvWaGtyBIrQ\n\tsyi9sLOAHUNuvjAxqNaQxMFw6LlNpzuyH1iy9ae40Jzjz3flWtv7vuBzrE6ktbuVpQDM4dpqqky\n\tQYijToi6J0BzVe+iIZw5PH6xCirxqvyh0XOCeI9HYi+hgkoC0YtBgAcVg2GGQclBRI+zrCalqI5\n\t3TvOdLKzIoC7xADJiocbLpgtxusD8zuUsh8mFUN/L0GHDCab/Jqu7HPdy90UcUquU96NddT4+fU\n\tIvYFEdE6xvP5aUwzvXQxFsuQiVz7uvJH1MdHMTmchmLvyWlumDtOI3M6wRW7mLsdN4/1e8sQrfu\n\tF+McgtO3DFp+5QVzGUj+dVLsX2I5mdaprQdReAZvSV", "X-Google-Smtp-Source": "AGHT+IHdeDat27yR3zphe4/V6yOpdb41J/6Ex/FZv/iL2MhCxG0ItMnBMVag3P/4R2w3XxgHcMau2Q==", "X-Received": "by 2002:a17:907:94c3:b0:b3e:d492:d7b8 with SMTP id\n\ta640c23a62f3a-b50acc1aa45mr2470377066b.64.1760491410524; \n\tTue, 14 Oct 2025 18:23:30 -0700 (PDT)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "hdegoede@redhat.com, mzamazal@redhat.com, bryan.odonoghue@linaro.org,\n\tbod.linux@nxsw.ie", "Subject": "[PATCH v3 35/39] libcamera: software_isp: debayer_egl: Make gpuisp\n\tdefault softisp mode", "Date": "Wed, 15 Oct 2025 02:22:47 +0100", "Message-ID": "<20251015012251.17508-36-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20251015012251.17508-1-bryan.odonoghue@linaro.org>", "References": "<20251015012251.17508-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "In some cases the GPU can deliver 15x performance in Debayer with the\nCCM on, reference hardware Qualcomm RB5 with IMX512 sensor.\n\nGiven this large performance difference it makes sense to make GPUISP\nthe default for the Software ISP.\n\nIf LIBCAMERA_SOFTISP_MODE is omitted gpu will be the default. If\nlibcamera is compiled without gpuisp support, CPU Debayer will be used.\n\nIt is still possible to select CPU mode with LIBCAMERA_SOFISP_MODE=cpu.\n\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/software_isp/software_isp.cpp | 11 +++++++++--\n 1 file changed, 9 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex 869f7320..1b4a29fd 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -120,10 +120,17 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,\n \t}\n \tstats->statsReady.connect(this, &SoftwareIsp::statsReady);\n \n-#if HAVE_DEBAYER_EGL\n \tconst char *softISPMode = utils::secure_getenv(\"LIBCAMERA_SOFTISP_MODE\");\n+\tif (softISPMode) {\n+\t\tif (strcmp(softISPMode, \"gpu\") && strcmp(softISPMode, \"cpu\")) {\n+\t\t\tLOG(SoftwareIsp, Error) << \"LIBCAMERA_SOFISP_MODE \" << softISPMode << \" invalid. \"\n+\t\t\t\t\t\t<< \"must be \\\"cpu\\\" or \\\"gpu\\\"\";\n+\t\t\treturn;\n+\t\t}\n+\t}\n \n-\tif (softISPMode && !strcmp(softISPMode, \"gpu\"))\n+#if HAVE_DEBAYER_EGL\n+\tif (!softISPMode || !strcmp(softISPMode, \"gpu\"))\n \t\tdebayer_ = std::make_unique<DebayerEGL>(std::move(stats), configuration);\n #endif\n \tif (!debayer_)\n", "prefixes": [ "v3", "35/39" ] }