Patch Detail
Show a patch.
GET /api/1.1/patches/24666/?format=api
{ "id": 24666, "url": "https://patchwork.libcamera.org/api/1.1/patches/24666/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24666/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251015012251.17508-22-bryan.odonoghue@linaro.org>", "date": "2025-10-15T01:22:33", "name": "[v3,21/39] libcamera: software_isp: ccm: Populate CCM table to Debayer params structure", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "3f4be1ea7b9772f798bbce3fe46ad17095ae498d", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/1.1/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24666/mbox/", "series": [ { "id": 5503, "url": "https://patchwork.libcamera.org/api/1.1/series/5503/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5503", "date": "2025-10-15T01:22:12", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5503/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24666/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24666/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 41C55C3333\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 15 Oct 2025 01:23:30 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DB4D360650;\n\tWed, 15 Oct 2025 03:23:29 +0200 (CEST)", "from mail-ej1-x632.google.com (mail-ej1-x632.google.com\n\t[IPv6:2a00:1450:4864:20::632])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 73CE160631\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 15 Oct 2025 03:23:16 +0200 (CEST)", "by mail-ej1-x632.google.com with SMTP id\n\ta640c23a62f3a-b48d8deafaeso1242407466b.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 14 Oct 2025 18:23:16 -0700 (PDT)", "from inspiron14p-linux.nxsw.local (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-b5ccd7b202dsm98348466b.82.2025.10.14.18.23.14\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 14 Oct 2025 18:23:15 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"MVkb1HL1\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1760491396; x=1761096196;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=6Peo5/k8P8OiLfg/4ofwrT2kHhOPQ2yyIlXqRLA27yY=;\n\tb=MVkb1HL1Y7byLthH0cCT23XHze4vqmlQZ4os2zQyI3mb/RLrTZ/RnqsItE4BNyWEmc\n\t10nPzxqiTZGlwphDFf8TuAIEHej6EL9leohGOkZ1W5Hh+fYaRhM3iYDFn/sQ25PfG4WE\n\tEEzBfFt7jUkUC7ZtGBdY+Hol/2xE72wnQr2h8ZRZu/hpMww+XrKDRHzjhqM8IQD7wkcE\n\tL9Mk+PHTLLp9RG91BjbDAqME41kRCEXpeRmgCM/H5hL/fsUoVdk+7G+BMwh5SBOO74e0\n\tppJx9vzS/L8v8rMZy4errolAO2Vd5ICbf60zjBlYTGjNi+tRApoEkMznTXno4rTSUv+S\n\tDotw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1760491396; x=1761096196;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=6Peo5/k8P8OiLfg/4ofwrT2kHhOPQ2yyIlXqRLA27yY=;\n\tb=ILsb2RF9XE1E2mcP7JQM0Z0dRzaqu5ppILtna3uw2kp/ZmHJLZ/pXudZVZTmr+rlXf\n\tPLXT6LDrGL1MA52axkDXtp7HQtYwhTxQ4iiQ/ebx53Hoefc7YbHWa5k9o0+VKKKJnERk\n\tsuwElseND4A6HdwBvj28bVH6KQgl/WxV6b4O7iJmAwo9sP+x243gC8QYvMKnpJjt1WLq\n\t55K1ES8tThmmKTMEf5logVyUS1WosNXtCQVoj+iVkMm/RJXLi61gp0JJr0CyOZH/F9qC\n\txM43IBVoZBBobhnLidBranhuaLblTFRrj8uKpyLIucgYE0yGEvludbbTcfaASFlDoBZZ\n\tjDJg==", "X-Gm-Message-State": "AOJu0Yyds4aPhWY62Jo7Cty2Hw/3Pfy4zo0Sexw+w2reWo+Vx84nc4sL\n\txLbfGq2MDeuFGcbu69fV3grz2RZljM3wIeAMhpHw8HownwZAF+hC9/WucS13w1BKfkZDZbvjSN/\n\tpFy4d", "X-Gm-Gg": "ASbGnct8OCmP+jsj2ecixddGaYC+F6XgrqCXQ0YNXP9r9KZDV1R3afqWNMxvmkXcXgS\n\tEALXUJ2npzAVU/MuqObzUQtIyx0+nGq+06nSy1FY+87Cr0Tj+mwnVwFVy18GVpAdbODYpTDAOiG\n\t3iprA9t0bO+WWa3n6PByHJmM9HEmB1xg87Ubkz7LwaVJfGhm1ZEMGDyn3FiNQuCVQW0VqhB+Dv6\n\t3HtSBBn0w11jXDQ9G1y89OdqJzD1AB+nt2hH85pajTTTiiOYZOiTO3CA5KPEvT6SJV0LI0EA/aS\n\tx7bwDAeI3YuHHQKTubk6ryxmGPINb8TlLeyoPuf1bfG8fnZJayleeB7rXDVPeoagZ2vS7TcG+GP\n\tbvGJ+iNIW3jGj3NRCDlkB0y1Imiw2r2NEO67iv4fMINMBhvJcjq6ricxH9nlGpoiSYUzG3PAY/u\n\t9E1g54EM75Nyo8XEbcYGc4md78jpEmsA==", "X-Google-Smtp-Source": "AGHT+IFeQd6HKRU1a49yLU6jNq4p8+hRum+XXgRWl85j5r5nBNhZSm0J0G9C7/GFNC/tKf0odw6O4A==", "X-Received": "by 2002:a17:907:94c8:b0:b47:de64:df1b with SMTP id\n\ta640c23a62f3a-b50abfd6d92mr2822960266b.39.1760491395799; \n\tTue, 14 Oct 2025 18:23:15 -0700 (PDT)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "hdegoede@redhat.com, mzamazal@redhat.com, bryan.odonoghue@linaro.org,\n\tbod.linux@nxsw.ie", "Subject": "[PATCH v3 21/39] libcamera: software_isp: ccm: Populate CCM table to\n\tDebayer params structure", "Date": "Wed, 15 Oct 2025 02:22:33 +0100", "Message-ID": "<20251015012251.17508-22-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20251015012251.17508-1-bryan.odonoghue@linaro.org>", "References": "<20251015012251.17508-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Populate the DebayerParams CCM table during ccm::prepare(). A copy is made\nof the CCM into the DebayerParams structure.\n\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/ipa/simple/algorithms/ccm.cpp | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/simple/algorithms/ccm.cpp b/src/ipa/simple/algorithms/ccm.cpp\nindex 0a98406c..cb023878 100644\n--- a/src/ipa/simple/algorithms/ccm.cpp\n+++ b/src/ipa/simple/algorithms/ccm.cpp\n@@ -14,6 +14,7 @@\n #include <libcamera/control_ids.h>\n \n #include \"libcamera/internal/matrix.h\"\n+#include \"libcamera/internal/software_isp/debayer_params.h\"\n \n namespace {\n \n@@ -84,7 +85,7 @@ void Ccm::applySaturation(Matrix<float, 3, 3> &ccm, float saturation)\n }\n \n void Ccm::prepare(IPAContext &context, const uint32_t frame,\n-\t\t IPAFrameContext &frameContext, [[maybe_unused]] DebayerParams *params)\n+\t\t IPAFrameContext &frameContext, DebayerParams *params)\n {\n \tauto &saturation = context.activeState.knobs.saturation;\n \n@@ -108,6 +109,7 @@ void Ccm::prepare(IPAContext &context, const uint32_t frame,\n \tcontext.activeState.ccm.ccm = ccm;\n \tframeContext.ccm.ccm = ccm;\n \tframeContext.saturation = saturation;\n+\tparams->ccm = ccm;\n \tcontext.activeState.ccm.changed = true;\n }\n \n", "prefixes": [ "v3", "21/39" ] }