Patch Detail
Show a patch.
GET /api/1.1/patches/24661/?format=api
{ "id": 24661, "url": "https://patchwork.libcamera.org/api/1.1/patches/24661/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24661/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251015012251.17508-17-bryan.odonoghue@linaro.org>", "date": "2025-10-15T01:22:28", "name": "[v3,16/39] libcamera: software_isp: Move configure to worker thread", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "e843334eee03f6e4e74c0af75b16b9052ae9e8ab", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/1.1/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24661/mbox/", "series": [ { "id": 5503, "url": "https://patchwork.libcamera.org/api/1.1/series/5503/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5503", "date": "2025-10-15T01:22:12", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5503/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24661/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24661/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 08A1CC3333\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 15 Oct 2025 01:23:22 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6FEE260651;\n\tWed, 15 Oct 2025 03:23:22 +0200 (CEST)", "from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com\n\t[IPv6:2a00:1450:4864:20::62c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 087F960620\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 15 Oct 2025 03:23:12 +0200 (CEST)", "by mail-ej1-x62c.google.com with SMTP id\n\ta640c23a62f3a-b457d93c155so936404566b.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 14 Oct 2025 18:23:12 -0700 (PDT)", "from inspiron14p-linux.nxsw.local (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-b5ccd7b202dsm98348466b.82.2025.10.14.18.23.10\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 14 Oct 2025 18:23:10 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"anWPih9n\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1760491391; x=1761096191;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=7OmT6mS4N4Yc2DUHOdjqndL86dhxexJ/+HXKOIxa6QI=;\n\tb=anWPih9nDanXcCV/kF446YmYWNne/i9FV324nTFuyXjRs67+Jl+nlcSJdK5LioqOiK\n\tN1qQcYyKToBT8fNvDMM0BHmqSEMihpEOZO3zR2FBzJLLvIQgZDUcsHk2BA+DC8jEuhlk\n\t8zA8Bwsp174/HMTnv8l9mA5UEz0O3v+etQZxmY39sil+GlSL1CCyy6Qrc35J+gWF1AlC\n\tEYuuK5mco5+/T32iPu/hJgfwx54Nia5j5ekEsN7OZRKvr2e0BE7qitPVVfsRH2T/Ju/p\n\tXeogKZ8kMnxPGMBLmaoEcFH6yznGduSbhuSGMI7blSXPjjNAp5doYZq31vq3AQ9+Bh+2\n\tEFsQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1760491391; x=1761096191;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=7OmT6mS4N4Yc2DUHOdjqndL86dhxexJ/+HXKOIxa6QI=;\n\tb=uVNhR3ztFTLnd1k1qqqYgzaWPPe+t6KH6wJi4Jazs7KWIzVVAiADGl+t7Poe8rZEgp\n\tL3xZ58TIj53iSOL5A5B6TYBi05jN9daywBhF0cGKtAsbtpvpBwyE9p9Lr3/DhcmVFf4I\n\tipECPuIVjmL21b/xfgiTSypUlVtFTOdqtLjp3yoYZ879Ji2pfYhh95f1a/cIvcDk3fWf\n\timkdcf8ZP3mousQoBgKXPJhadTcZmnoXJeZF+IqYWbS2TUJwdDVHX2m2Nabrv55NJUC3\n\tAelBa2dvCEg0IfAVYgljPcldkBskCtTf7Y+d2Q+tUwFKZOc3xir3JiUdNRcMo+MRCdB2\n\t/JiA==", "X-Gm-Message-State": "AOJu0YwY9iIuJnDltbh9ZDr/NHMZfXad9m7agi3lJyx2BLGgRuiWcgJv\n\tXZRc4ccVWyhvOOBPtitUik8A6/hceA0uv/jIYzeoilEUmGaD5q7uXUDmRH33vQyy1PK+SawjR0y\n\tqXYyj", "X-Gm-Gg": "ASbGncvkAZijf6Ruj0gjj3fM4qpRixiG6aSXTy0X2+8KcnYguhwYxjM6nTANgu+FEWz\n\tBcHBMef1z2QZwS4w9pcqlk2wLC1TTmDqZfLDXPxcYOnjgKiYC1sNc5b/QHr/0SoXO0YbmzevO/A\n\tkrRJO6vlJ6SlsbLEUrGmDiJett+/hqyhctypnC4WodMr5MAzl28h4kqMiuM4UVxYM/pWJNlWTK1\n\tSWGDawAd3MdJui+EdakauWICGixcPpswtLDtRx8aVGNZ1hjLg4yYcXorXYqrXkM3pBcnoxtDP2+\n\tWE3IUyUjrj1gLKu1PDvDrpGlUCcVIc+0nn2v3C7RMARHDNSL1mJYEhtbVnm1AhZLBXjHAnQRnbL\n\tRh1eq9kKRvT6oNsQLcjLDgSE1eT0LM2c6Ey1j5oLR9rp2+KcM9Oc/JP5s4AOktirxSzUfQYcjoJ\n\txgFuz5oCoCuL3X8ZXMfoPVZZULF2o2mfz2kknKIwO4", "X-Google-Smtp-Source": "AGHT+IHweHJZPJ0VYMMh5jPx1WD09ivFRx8vrxC8VbNMMhM5YP0tgXmcPOp2/RRElqcVJt8wJ190Bg==", "X-Received": "by 2002:a17:907:3e22:b0:b3e:b226:5bad with SMTP id\n\ta640c23a62f3a-b50a9a6d8a3mr2754453866b.8.1760491391273; \n\tTue, 14 Oct 2025 18:23:11 -0700 (PDT)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "hdegoede@redhat.com, mzamazal@redhat.com, bryan.odonoghue@linaro.org,\n\tbod.linux@nxsw.ie", "Subject": "[PATCH v3 16/39] libcamera: software_isp: Move configure to worker\n\tthread", "Date": "Wed, 15 Oct 2025 02:22:28 +0100", "Message-ID": "<20251015012251.17508-17-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20251015012251.17508-1-bryan.odonoghue@linaro.org>", "References": "<20251015012251.17508-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "EGL requires both configure() and process() to operate on the same\nthread. As preparation for that, move current CPU configure into the\nWorkerThread with a ConnectionTypeBlocking invocation of\n&DebayerCpu::configure.\n\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/software_isp/software_isp.cpp | 12 ++++++++++--\n 1 file changed, 10 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex 500858ab..df72b1c3 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -266,7 +266,15 @@ int SoftwareIsp::configure(const StreamConfiguration &inputCfg,\n \n \tispWorkerThread_.start();\n \n-\treturn debayer_->configure(inputCfg, outputCfgs, ccmEnabled_);\n+\tret = debayer_->invokeMethod(&Debayer::configure,\n+\t\t\t\t ConnectionTypeBlocking, inputCfg,\n+\t\t\t\t outputCfgs, ccmEnabled_);\n+\tif (ret) {\n+\t\tispWorkerThread_.exit();\n+\t\tispWorkerThread_.wait();\n+\t}\n+\n+\treturn ret;\n }\n \n /**\n@@ -389,7 +397,7 @@ void SoftwareIsp::stop()\n void SoftwareIsp::process(uint32_t frame, FrameBuffer *input, FrameBuffer *output)\n {\n \tipa_->computeParams(frame);\n-\tdebayer_->invokeMethod(&DebayerCpu::process,\n+\tdebayer_->invokeMethod(&Debayer::process,\n \t\t\t ConnectionTypeQueued, frame, input, output, debayerParams_);\n }\n \n", "prefixes": [ "v3", "16/39" ] }