Patch Detail
Show a patch.
GET /api/1.1/patches/24647/?format=api
{ "id": 24647, "url": "https://patchwork.libcamera.org/api/1.1/patches/24647/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24647/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251015012251.17508-3-bryan.odonoghue@linaro.org>", "date": "2025-10-15T01:22:14", "name": "[v3,02/39] utils: gen-shader-headers: Add a utility to generate headers from shaders", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "272e0b02b0e89ff5247aa2924f3bd52c1f097477", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/1.1/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24647/mbox/", "series": [ { "id": 5503, "url": "https://patchwork.libcamera.org/api/1.1/series/5503/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5503", "date": "2025-10-15T01:22:12", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5503/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24647/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24647/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C3525C3264\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 15 Oct 2025 01:23:01 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C0D7D6060F;\n\tWed, 15 Oct 2025 03:22:59 +0200 (CEST)", "from mail-ej1-x629.google.com (mail-ej1-x629.google.com\n\t[IPv6:2a00:1450:4864:20::629])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D41C060607\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 15 Oct 2025 03:22:57 +0200 (CEST)", "by mail-ej1-x629.google.com with SMTP id\n\ta640c23a62f3a-b3e234fcd4bso979181066b.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 14 Oct 2025 18:22:57 -0700 (PDT)", "from inspiron14p-linux.nxsw.local (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-b5ccd7b202dsm98348466b.82.2025.10.14.18.22.55\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 14 Oct 2025 18:22:56 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"SYhWRjwU\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1760491377; x=1761096177;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=E0I6fpsyuvLC5j5cYAtQaKP7gWF3/fw1mtSWmqaMPpk=;\n\tb=SYhWRjwU5GnralHZMqSwSeluT9X2METGkxyltB3oUtC0fN/53moc+S2fO4Xrr5LHM9\n\ttyEFZwp9Dph92cqpxIH+7AryXkrr2UeMehsZgr9bWi2aRFBZiE2+ugQy3Mi6ty7nSZdJ\n\tZktUlBeL3UnINstQTXE2L1ck+AC7TFUhp1mdrKke6F4WPZV+kwscENahd/ATwp7v67a8\n\ttpNd+EOZRxBRlJar03bhAcyFDODdk2Xd4kvqFFGa0tnjqGhFu7NcFsLlhFfyH4TaecWZ\n\ttcmupsmMNqX2yQFsA8PMnMqK2lBz0ER5q3/2+R580L2XwO22tHoNMS6YfVd7OMK6vfGg\n\t6IKQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1760491377; x=1761096177;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=E0I6fpsyuvLC5j5cYAtQaKP7gWF3/fw1mtSWmqaMPpk=;\n\tb=h3f1vYvzXGJwzrk5wmzKb+o+jpMb1uAhdXuW5YAg7R2LZT4GF966wD4BX4tpe5g/PH\n\tgoMCOCKRJPKF8OSIFLpaEB5Voe0d3gzT9c6MCtTV9sh2O7Js3u8Ib01CnA8b3hNMHyZR\n\t2tD8zQaffubOmFmzTlfFwoQaL/mkWLPYFlIsTUKqSvuRytNBKQmLYrHYHeK95S7lDyCa\n\tKnDgNjdY/YTwdji9I7LIcteulyEsXPjbPnVWKn91ZIHgLHwTr/TZFcYqnILgyvJqrO82\n\t3UoLPs1XPhb/DWX0Lo4Tkd5m+6pWdssWND1mMLjBoIsA1/Xu4Wty/z1x8CqIH3I0A/6b\n\ttUjg==", "X-Gm-Message-State": "AOJu0YyUldmHYjKSAXznLDDIAKyfDoXOKRyvryMacmef1ZeCRAjyKmJQ\n\t+T+LaXp5vBnj/Z+QdOMNSSyzC7dZ1NP2qozzDEQOXesnqCdi/z8H0C0bQXN9aw0lH5+76DNeFJv\n\tNCAr+", "X-Gm-Gg": "ASbGncvVhzZLkRlUMrLtPMUeE+uIWlA5NgmAoHNlNLOYIsY+KvjS31PmUrX/6FPxdT0\n\tIJ8ZUKinrn9hbQ2pfAWN9pcYQyd0q7EkWU+i97Nd6UNbpad0kcoNEEMuBPm3WGwSNbTe/d2bHcn\n\tmhRCaojZ2NjJxbbEBmCeQLuVzQLWLDofKm8MOtqLsR6ZfpJkUiJxErRkD2d+2aUkH7QWGgtYqSN\n\tnnfOKV9rQwHNHqOgye19s3jQ+6BgE3Knid2+WzzX+LAaKkIFG9z9jMuNJBtEFb8IduFlnlRm1qa\n\tLGowHPUzbMKTOOPl2w94PYA5U9Pa1jg/JOkn1sYYe6OvlmzQEcQpQImMqxtdYyTkLdjDfIRLMWl\n\tUB293YX/Q/8xXY9oaEeTpEtScq7CRCKk93Y+UEV5tawLR4ACOiGQ6KfpNlfPUKSkryUzvba602A\n\txyAhHCxTv8FpJWOd4XhDMIRdgxvRbouQ==", "X-Google-Smtp-Source": "AGHT+IEmygicqZQs2B4rDcyQ4/Mg9shrxCvPjJIcpzLhQeAsTl3qan8vinx1vX/P1/0SO9BfBnJ3Mg==", "X-Received": "by 2002:a17:907:c03:b0:b46:31be:e8ea with SMTP id\n\ta640c23a62f3a-b50a76da212mr2724915466b.0.1760491376823; \n\tTue, 14 Oct 2025 18:22:56 -0700 (PDT)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "hdegoede@redhat.com, mzamazal@redhat.com, bryan.odonoghue@linaro.org,\n\tbod.linux@nxsw.ie", "Subject": "[PATCH v3 02/39] utils: gen-shader-headers: Add a utility to\n\tgenerate headers from shaders", "Date": "Wed, 15 Oct 2025 02:22:14 +0100", "Message-ID": "<20251015012251.17508-3-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20251015012251.17508-1-bryan.odonoghue@linaro.org>", "References": "<20251015012251.17508-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Two simple script to generate a header that contains GLSL shaders translated\nto C arrays.\n\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n utils/gen-shader-header.py | 38 ++++++++++++++++++++++++++++++++\n utils/gen-shader-headers.sh | 44 +++++++++++++++++++++++++++++++++++++\n 2 files changed, 82 insertions(+)\n create mode 100755 utils/gen-shader-header.py\n create mode 100755 utils/gen-shader-headers.sh", "diff": "diff --git a/utils/gen-shader-header.py b/utils/gen-shader-header.py\nnew file mode 100755\nindex 00000000..6668e648\n--- /dev/null\n+++ b/utils/gen-shader-header.py\n@@ -0,0 +1,38 @@\n+#!/usr/bin/env python3\n+# SPDX-License-Identifier: GPL-2.0-or-later\n+# Copyright (C) 2025, Bryan O'Donoghue.\n+#\n+# Author: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n+#\n+# A python script which takes a list of shader files and converts into a C\n+# header.\n+#\n+import sys\n+\n+try:\n+ with open(sys.argv[2]) as file:\n+ data = file.read()\n+ data_len = len(data)\n+\n+ name = sys.argv[1].replace(\".\", \"_\")\n+ name_len = name + \"_len\"\n+\n+ j = 0\n+ print(\"unsigned char\", name, \"[] = {\")\n+ for ch in data:\n+ print(f\"0x{ord(ch):02x}, \", end=\"\")\n+ j = j + 1\n+ if j == 16:\n+ print()\n+ j = 0\n+ if j != 0:\n+ print()\n+ print(\"};\")\n+\n+ print()\n+ print(f\"const unsigned int {name_len}={data_len};\")\n+\n+except FileNotFoundError:\n+ print(f\"File {sys.argv[2]} not found\", file=sys.stderr)\n+except IOError:\n+ print(f\"Unable to read {sys.argv[2]}\", file=sys.stderr)\ndiff --git a/utils/gen-shader-headers.sh b/utils/gen-shader-headers.sh\nnew file mode 100755\nindex 00000000..ca4f19f0\n--- /dev/null\n+++ b/utils/gen-shader-headers.sh\n@@ -0,0 +1,44 @@\n+#!/bin/sh\n+set -x\n+\n+if [ $# -lt 4 ]; then\n+\techo \"Invalid arg count must be >= 5\"\n+\texit 1\n+fi\n+src_dir=\"$1\"; shift\n+build_dir=\"$1\"; shift\n+build_path=$build_dir/\"$1\"; shift\n+\n+cat <<EOF > \"$build_path\"\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/* This file is auto-generated, do not edit! */\n+/*\n+ * Copyright (C) 2025, Linaro Ltd.\n+ *\n+ */\n+\n+#pragma once\n+\n+EOF\n+\n+cat <<EOF >> \"$build_path\"\n+/*\n+ * List the names of the shaders at the top of\n+ * header for readability's sake\n+ *\n+EOF\n+\n+for file in \"$@\"; do\n+\techo \"file is $file\"\n+\tname=$(basename \"$build_dir/$file\" | tr '.' '_')\n+\techo \" * unsigned char $name;\" >> \"$build_path\"\n+done\n+\n+echo \"*/\" >> \"$build_path\"\n+\n+echo \"/* Hex encoded shader data */\" >> \"$build_path\"\n+for file in \"$@\"; do\n+\tname=$(basename \"$build_dir/$file\")\n+\t\"$src_dir/utils/gen-shader-header.py\" \"$name\" \"$build_dir/$file\" >> \"$build_path\"\n+\techo >> \"$build_path\"\n+done\n", "prefixes": [ "v3", "02/39" ] }