Patch Detail
Show a patch.
GET /api/1.1/patches/24631/?format=api
{ "id": 24631, "url": "https://patchwork.libcamera.org/api/1.1/patches/24631/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24631/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251014-v4l2-params-v6-2-caf5fa69eb29@ideasonboard.com>", "date": "2025-10-14T10:55:37", "name": "[v6,2/5] include: linux: Add v4l2-isp.h", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f9fe8f49a723adf6bd875fd7df579bdb413af56e", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/1.1/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24631/mbox/", "series": [ { "id": 5499, "url": "https://patchwork.libcamera.org/api/1.1/series/5499/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5499", "date": "2025-10-14T10:55:35", "name": "ipa: libipa: Introduce V4L2Params", "version": 6, "mbox": "https://patchwork.libcamera.org/series/5499/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24631/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24631/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 07AC3C3264\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 14 Oct 2025 10:55:56 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D450A605EC;\n\tTue, 14 Oct 2025 12:55:55 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8F2F4605E4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 14 Oct 2025 12:55:52 +0200 (CEST)", "from [192.168.1.182] (93-46-82-201.ip106.fastwebnet.it\n\t[93.46.82.201])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 92512E70;\n\tTue, 14 Oct 2025 12:54:12 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YtNgpXhi\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1760439252;\n\tbh=B04XQR2HsXyiHyqtqII3W7XT9inNJ/kKeKMlTQUnZ0Q=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=YtNgpXhiPe8C7nPxPCOHlshugem2zw5kExb2jDMDWR5HGcEy0HGaawAKipZPmymdH\n\tZuhJkYK6nOvOcZXNcO+E8l8xO7eYPhe5pZ2mYkGejd6BNGVQwM3jA7GbVnA5eowW39\n\tArXrS5t/yLF+Zxu16X+SUIIslcT8iCEoKEbeifiE=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Date": "Tue, 14 Oct 2025 12:55:37 +0200", "Subject": "[PATCH v6 2/5] include: linux: Add v4l2-isp.h", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20251014-v4l2-params-v6-2-caf5fa69eb29@ideasonboard.com>", "References": "<20251014-v4l2-params-v6-0-caf5fa69eb29@ideasonboard.com>", "In-Reply-To": "<20251014-v4l2-params-v6-0-caf5fa69eb29@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>, \n\tAntoine Bouyer <antoine.bouyer@nxp.com>, \n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>, \n\tKieran Bingham <kieran.bingham@ideasonboard.com>, \n\tDaniel Scally <dan.scally@ideasonboard.com>", "X-Mailer": "b4 0.14.2", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=5849;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=B04XQR2HsXyiHyqtqII3W7XT9inNJ/kKeKMlTQUnZ0Q=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBo7iw15AMIh7D0Q0L1oqmgrkXFgPnTcSdleNwQg\n\tDuYqN67MO6JAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCaO4sNQAKCRByNAaPFqFW\n\tPI4aD/9My1oXnu04Ke6JDMW+QdiUkEUKfJtmhfIZJGqIPJYfFvWh8Jffz3K8NKEXu+HGs4fw0S4\n\tiC7gZb3XnBda1mWey1HqSUUy4qTrzfkTV04FDZhzR66eiq2x3SuUFWS6+WEaoakxH+/vQE1nh44\n\ts+9Uu+Dw6yH+X+lcX5u8R/UgTz/9jaM5UQ5gAryPfWAb0hLPTANuLVIiyZKGXecWFGp8au4FkqF\n\txcM2KIrrECj047//qiOA74fVfPN9F/bucdF6T5wJGwZmx/1w+WPQy8JnWno8hPxryX+MSu1huGK\n\tSbpeBUysdGJ4oeie84UI4Jz9Vqp9p1khz7rIMTpwyduln0xFIlVj2XAPe8bx4G5uPLCYjgPzo8z\n\tqib2zvwQnBs8oaOZSzR+G5dKdrNUUnxC6WCDaEj5Q5LX9csm1DkBsBb20DFC878H0R3UAN4au10\n\teHfMoYMBOjBGR4TVovx4+H+R9brrQwKMJuiSmQZEVy+DeATOmeOFqGAXTMrzMxrJH4hhzTIa0d7\n\txKlalSLhpey0xJ5+0RRbkol6rlWFN/Pou9KRytd48raU/dF2hjDYcRBYO2RnSKXf5NXQQdl9tUE\n\tGRNY+TM8Y5jAjfAW1VBIE2iAKmksAPAqGSRlc0xw3/oEWzxnuvsSfNrpiy9QK4WP0+Yjc/Tz0JD\n\tUutKFtYLU9EeTUg==", "X-Developer-Key": "i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Import the v4l2-isp.h header from the Linux kernel sources.\n\nThe file has not been merged in mainline Linux yet but is available\nat v7:\nhttps://lore.kernel.org/all/20251014-extensible-parameters-validation-v7-0-6628bed5ca98@ideasonboard.com/\n\nCreate the include/linux/media/ directory so that header files\nexported from the kernel which include this file do not need\nto be adjusted when imported in libcamera.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nTested-by: Antoine Bouyer <antoine.bouyer@nxp.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nAcked-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Daniel Scally <dan.scally@ideasonboard.com>\n---\n include/linux/media/v4l2-isp.h | 102 +++++++++++++++++++++++++++++++++++++++++\n utils/update-kernel-headers.sh | 1 +\n 2 files changed, 103 insertions(+)", "diff": "diff --git a/include/linux/media/v4l2-isp.h b/include/linux/media/v4l2-isp.h\nnew file mode 100644\nindex 0000000000000000000000000000000000000000..0cfc4ab94967ae796e9d9fc755dbbe072c1e82e2\n--- /dev/null\n+++ b/include/linux/media/v4l2-isp.h\n@@ -0,0 +1,102 @@\n+/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */\n+/*\n+ * Video4Linux2 generic ISP parameters and statistics support\n+ *\n+ * Copyright (C) 2025 Ideas On Board Oy\n+ * Author: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n+ */\n+\n+#ifndef _V4L2_ISP_H_\n+#define _V4L2_ISP_H_\n+\n+#include <linux/stddef.h>\n+#include <linux/types.h>\n+\n+/**\n+ * enum v4l2_isp_params_version - V4L2 ISP parameters versioning\n+ *\n+ * @V4L2_ISP_PARAMS_VERSION_V0: First version of the V4L2 ISP parameters format\n+ *\t\t\t\t(for compatibility)\n+ * @V4L2_ISP_PARAMS_VERSION_V1: First version of the V4L2 ISP parameters format\n+ *\n+ * V0 and V1 are identical in order to support drivers compatible with the V4L2\n+ * ISP parameters format already upstreamed which use either 0 or 1 as their\n+ * versioning identifier. Both V0 and V1 refers to the first version of the\n+ * V4L2 ISP parameters format.\n+ *\n+ * Future revisions of the V4L2 ISP parameters format should start from the\n+ * value of 2.\n+ */\n+enum v4l2_isp_params_version {\n+\tV4L2_ISP_PARAMS_VERSION_V0 = 0,\n+\tV4L2_ISP_PARAMS_VERSION_V1\n+};\n+\n+#define V4L2_ISP_PARAMS_FL_BLOCK_DISABLE\t(1U << 0)\n+#define V4L2_ISP_PARAMS_FL_BLOCK_ENABLE\t\t(1U << 1)\n+\n+/*\n+ * Reserve the first 8 bits for V4L2_ISP_PARAMS_FL_* flag.\n+ *\n+ * Driver-specific flags should be defined as:\n+ * #define DRIVER_SPECIFIC_FLAG0 ((1U << V4L2_ISP_PARAMS_FL_DRIVER_FLAGS(0))\n+ * #define DRIVER_SPECIFIC_FLAG1 ((1U << V4L2_ISP_PARAMS_FL_DRIVER_FLAGS(1))\n+ */\n+#define V4L2_ISP_PARAMS_FL_DRIVER_FLAGS(n) ((n) + 8)\n+\n+/**\n+ * struct v4l2_isp_params_block_header - V4L2 extensible parameters block header\n+ * @type: The parameters block type (driver-specific)\n+ * @flags: A bitmask of block flags (driver-specific)\n+ * @size: Size (in bytes) of the parameters block, including this header\n+ *\n+ * This structure represents the common part of all the ISP configuration\n+ * blocks. Each parameters block shall embed an instance of this structure type\n+ * as its first member, followed by the block-specific configuration data.\n+ *\n+ * The @type field is an ISP driver-specific value that identifies the block\n+ * type. The @size field specifies the size of the parameters block.\n+ *\n+ * The @flags field is a bitmask of per-block flags V4L2_PARAMS_ISP_FL_* and\n+ * driver-specific flags specified by the driver header.\n+ */\n+struct v4l2_isp_params_block_header {\n+\t__u16 type;\n+\t__u16 flags;\n+\t__u32 size;\n+} __attribute__((aligned(8)));\n+\n+/**\n+ * struct v4l2_isp_params_buffer - V4L2 extensible parameters configuration\n+ * @version: The parameters buffer version (driver-specific)\n+ * @data_size: The configuration data effective size, excluding this header\n+ * @data: The configuration data\n+ *\n+ * This structure contains the configuration parameters of the ISP algorithms,\n+ * serialized by userspace into a data buffer. Each configuration parameter\n+ * block is represented by a block-specific structure which contains a\n+ * :c:type:`v4l2_isp_params_block_header` entry as first member. Userspace\n+ * populates the @data buffer with configuration parameters for the blocks that\n+ * it intends to configure. As a consequence, the data buffer effective size\n+ * changes according to the number of ISP blocks that userspace intends to\n+ * configure and is set by userspace in the @data_size field.\n+ *\n+ * The parameters buffer is versioned by the @version field to allow modifying\n+ * and extending its definition. Userspace shall populate the @version field to\n+ * inform the driver about the version it intends to use. The driver will parse\n+ * and handle the @data buffer according to the data layout specific to the\n+ * indicated version and return an error if the desired version is not\n+ * supported.\n+ *\n+ * For each ISP block that userspace wants to configure, a block-specific\n+ * structure is appended to the @data buffer, one after the other without gaps\n+ * in between. Userspace shall populate the @data_size field with the effective\n+ * size, in bytes, of the @data buffer.\n+ */\n+struct v4l2_isp_params_buffer {\n+\t__u32 version;\n+\t__u32 data_size;\n+\t__u8 data[] __counted_by(data_size);\n+};\n+\n+#endif /* _V4L2_ISP_H_ */\ndiff --git a/utils/update-kernel-headers.sh b/utils/update-kernel-headers.sh\nindex 666624f9972ea61067e5b5695237ab7a17c61664..749c9e0345e7b8f40fece720a3fbfcd428eeab7f 100755\n--- a/utils/update-kernel-headers.sh\n+++ b/utils/update-kernel-headers.sh\n@@ -51,6 +51,7 @@ headers=\"\n \tlinux/dma-heap.h\n \tlinux/media-bus-format.h\n \tlinux/media.h\n+\tlinux/media/v4l2-isp.h\n \tlinux/rkisp1-config.h\n \tlinux/stddef.h\n \tlinux/udmabuf.h\n", "prefixes": [ "v6", "2/5" ] }