Patch Detail
Show a patch.
GET /api/1.1/patches/24622/?format=api
{ "id": 24622, "url": "https://patchwork.libcamera.org/api/1.1/patches/24622/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24622/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251014075252.2876485-7-stefan.klug@ideasonboard.com>", "date": "2025-10-14T07:52:28", "name": "[v1,06/12] ipa: rkisp1: lsc: Rename res to samples", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "7d680e9facf116abc0cb0f0374c98d165b8b7f24", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24622/mbox/", "series": [ { "id": 5498, "url": "https://patchwork.libcamera.org/api/1.1/series/5498/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5498", "date": "2025-10-14T07:52:22", "name": "Add resampling support for polynomial LSC data", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5498/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24622/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24622/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A6735BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 14 Oct 2025 07:53:18 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5D7F1605D7;\n\tTue, 14 Oct 2025 09:53:18 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E34146052F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 14 Oct 2025 09:53:16 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:61fb:8e55:ff1e:be62])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id AE836741;\n\tTue, 14 Oct 2025 09:51:38 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Y5VqH4Gt\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1760428298;\n\tbh=Or5s/Vj6mdT0Vr3n+H+YktJqaQ/C57C4uaOKClLD6OI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Y5VqH4GtsN97YsZVA9DYzfsQZHnS+4D4PX91LSPYgOC+6GIwiKqWrv6zuGHwtiApp\n\ttgV7CHJeCDW+zAhi9UMqvz+RktvvkpIdo2FbZf4hsWl5+7lRLGtsTXIGf1K/Axvrsv\n\tDuYZ1oNqWP/qUGcqnDGP6MvkoaQbzdiTnUHKFs+M=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH v1 06/12] ipa: rkisp1: lsc: Rename res to samples", "Date": "Tue, 14 Oct 2025 09:52:28 +0200", "Message-ID": "<20251014075252.2876485-7-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.48.1", "In-Reply-To": "<20251014075252.2876485-1-stefan.klug@ideasonboard.com>", "References": "<20251014075252.2876485-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Rename res to samples to better describe the intent. This was noted in\nreview after the series was merged.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n---\n src/ipa/rkisp1/algorithms/lsc.cpp | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp\nindex e4938dbd657c..e46943f4bae0 100644\n--- a/src/ipa/rkisp1/algorithms/lsc.cpp\n+++ b/src/ipa/rkisp1/algorithms/lsc.cpp\n@@ -166,12 +166,12 @@ private:\n \t\tdouble y0 = cropRectangle_.y / m;\n \t\tdouble w = cropRectangle_.width / m;\n \t\tdouble h = cropRectangle_.height / m;\n-\t\tstd::vector<uint16_t> res;\n+\t\tstd::vector<uint16_t> samples;\n \n \t\tASSERT(xSizes_.size() * 2 + 1 == k);\n \t\tASSERT(ySizes_.size() * 2 + 1 == k);\n \n-\t\tres.reserve(k * k);\n+\t\tsamples.reserve(k * k);\n \n \t\tstd::vector<double> xPos(sizesListToPositions(xSizes_));\n \t\tstd::vector<double> yPos(sizesListToPositions(ySizes_));\n@@ -189,10 +189,10 @@ private:\n \t\t\t\t\tpoly.sampleAtNormalizedPixelPos(xp, yp) *\n \t\t\t\t\t1024);\n \t\t\t\tv = std::min(std::max(v, 1024), 4095);\n-\t\t\t\tres.push_back(v);\n+\t\t\t\tsamples.push_back(v);\n \t\t\t}\n \t\t}\n-\t\treturn res;\n+\t\treturn samples;\n \t}\n \n \tSize sensorSize_;\n", "prefixes": [ "v1", "06/12" ] }