Patch Detail
Show a patch.
GET /api/1.1/patches/24599/?format=api
{ "id": 24599, "url": "https://patchwork.libcamera.org/api/1.1/patches/24599/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24599/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251012142052.90611-4-robert.mader@collabora.com>", "date": "2025-10-12T14:20:52", "name": "[v5,3/3] pipeline: simple: Allow buffer counts from 1 to 32", "commit_ref": "05bfebed2657cc1d032c9796efd9041bfbdc881c", "pull_url": null, "state": "accepted", "archived": false, "hash": "31340b2c2da44e1e17af0524f765d66b9eb1c85a", "submitter": { "id": 140, "url": "https://patchwork.libcamera.org/api/1.1/people/140/?format=api", "name": "Robert Mader", "email": "robert.mader@collabora.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24599/mbox/", "series": [ { "id": 5487, "url": "https://patchwork.libcamera.org/api/1.1/series/5487/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5487", "date": "2025-10-12T14:20:49", "name": "pipeline: simple: Allow buffer counts from 1 to 32", "version": 5, "mbox": "https://patchwork.libcamera.org/series/5487/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24599/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24599/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B6631BE080\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 12 Oct 2025 14:21:35 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7556F6045F;\n\tSun, 12 Oct 2025 16:21:35 +0200 (CEST)", "from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com\n\t[136.143.188.112])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 298A76045F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 12 Oct 2025 16:21:33 +0200 (CEST)", "by mx.zohomail.com with SMTPS id 1760278888871375.30270435389764; \n\tSun, 12 Oct 2025 07:21:28 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=collabora.com\n\theader.i=robert.mader@collabora.com header.b=\"PqDsIjOS\"; \n\tdkim-atps=neutral", "ARC-Seal": "i=1; a=rsa-sha256; t=1760278890; cv=none; \n\td=zohomail.com; s=zohoarc; \n\tb=O+WZCT1aWlyh6/voGoOdVJADp4oTBPcqQNgDu2bAULmBSGyFlAgWuz4N0prdpjEjOVURSUfM6yhWBxUeRqTJe/faIko0Bob/5qWmYi89Od0aQrGKaIvSVV6CxmmJmyeSAav2KR9qjeBr51okl55ZY97MG79qAyjw7mEYlhobjZE=", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; \n\ts=zohoarc; t=1760278890;\n\th=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;\n\tbh=MVdorEZF3w4k/okJMdLRjxnNcpqLw/QK87S/YbiqTdY=; \n\tb=KvaTwrcRYR1+EJEUaky0uRbvhcSQ9MLyzKys5YvNAeYrY7qcVOcMv+Is01LNhUJjlJmsPwwo1EvUVkzjb5gNhMTgy9/5v6LmPnw5ud3Tg/3pAODdoUnt1cOQ4SnIVy1lYJzgPFkSd8wfopzh9nczItCbIn8m9FJ4cIVwBT8dosE=", "ARC-Authentication-Results": "i=1; mx.zohomail.com;\n\tdkim=pass header.i=collabora.com;\n\tspf=pass smtp.mailfrom=robert.mader@collabora.com;\n\tdmarc=pass header.from=<robert.mader@collabora.com>", "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1760278890;\n\ts=zohomail; d=collabora.com; i=robert.mader@collabora.com;\n\th=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To;\n\tbh=MVdorEZF3w4k/okJMdLRjxnNcpqLw/QK87S/YbiqTdY=;\n\tb=PqDsIjOSVNCHAjXtcHy/9FyO226ChijlHz4NmIBqgt6mBJ8ozseFS+vvJJHBOSff\n\tTXsc2rM2Qvai7R1cSO3eoZ5lZRrokS5ceEXHusGFw1djUWuZ9UtCpFWpVNfxlumzFta\n\t5XwAirGTpY4fkVa0d9dv07d3Xy6BulsInfj48e+E=", "From": "Robert Mader <robert.mader@collabora.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Robert Mader <robert.mader@collabora.com>,\n\tMilan Zamazal <mzamazal@redhat.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v5 3/3] pipeline: simple: Allow buffer counts from 1 to 32", "Date": "Sun, 12 Oct 2025 16:20:52 +0200", "Message-ID": "<20251012142052.90611-4-robert.mader@collabora.com>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20251012142052.90611-1-robert.mader@collabora.com>", "References": "<20251012142052.90611-1-robert.mader@collabora.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "While a default value of 4 buffers appears to be a good default that is\nused by other pipelines as well, allowing both higher and lower values\ncan be desirable, notably for:\n1. Video encoding, e.g. encoding multiple buffers in parallel.\n2. Clients requesting a single buffer - e.g. in multi-stream scenarios.\n\nThus allow buffer counts between 1 and 32 buffers - following the default\nmaximum from vb2 core - while keeping the default to the previous 4.\n\nWhile on it mark the config as adjusted when appropriate.\n\nSigned-off-by: Robert Mader <robert.mader@collabora.com>\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/pipeline/simple/simple.cpp | 18 ++++++++++++++++--\n 1 file changed, 16 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 6a2ffe624..dec9f6514 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -378,6 +378,9 @@ public:\n \tconst Transform &combinedTransform() const { return combinedTransform_; }\n \n private:\n+\tstatic constexpr unsigned int kNumBuffersDefault = 4;\n+\tstatic constexpr unsigned int kNumBuffersMax = 32;\n+\n \t/*\n \t * The SimpleCameraData instance is guaranteed to be valid as long as\n \t * the corresponding Camera instance is valid. In order to borrow a\n@@ -1240,7 +1243,7 @@ CameraConfiguration::Status SimpleCameraConfiguration::validate()\n \t\t cfg.size != pipeConfig_->captureSize)\n \t\t\tneedConversion_ = true;\n \n-\t\t/* Set the stride, frameSize and bufferCount. */\n+\t\t/* Set the stride and frameSize. */\n \t\tif (needConversion_) {\n \t\t\tstd::tie(cfg.stride, cfg.frameSize) =\n \t\t\t\tdata_->converter_\n@@ -1263,7 +1266,18 @@ CameraConfiguration::Status SimpleCameraConfiguration::validate()\n \t\t\tcfg.frameSize = format.planes[0].size;\n \t\t}\n \n-\t\tcfg.bufferCount = 4;\n+\t\tconst auto bufferCount = cfg.bufferCount;\n+\t\tif (bufferCount <= 0)\n+\t\t\tcfg.bufferCount = kNumBuffersDefault;\n+\t\telse if (bufferCount > kNumBuffersMax)\n+\t\t\tcfg.bufferCount = kNumBuffersMax;\n+\n+\t\tif (cfg.bufferCount != bufferCount) {\n+\t\t\tLOG(SimplePipeline, Debug)\n+\t\t\t\t<< \"Adjusting bufferCount from \" << bufferCount\n+\t\t\t\t<< \" to \" << cfg.bufferCount;\n+\t\t\tstatus = Adjusted;\n+\t\t}\n \t}\n \n \treturn status;\n", "prefixes": [ "v5", "3/3" ] }