Patch Detail
Show a patch.
GET /api/1.1/patches/24593/?format=api
{ "id": 24593, "url": "https://patchwork.libcamera.org/api/1.1/patches/24593/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24593/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251011160335.50578-6-kieran.bingham@ideasonboard.com>", "date": "2025-10-11T16:03:33", "name": "[RFC,5/7] ipa: softipa: Pass IPACameraSensorInfo to configure", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "18727bd16af4e62e1ae07e5f26b168c87f2604c5", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24593/mbox/", "series": [ { "id": 5486, "url": "https://patchwork.libcamera.org/api/1.1/series/5486/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5486", "date": "2025-10-11T16:03:28", "name": "Preparatory cleanup for libipa rework.", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5486/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24593/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24593/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B5FECC3331\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 11 Oct 2025 16:03:51 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 92D3860461;\n\tSat, 11 Oct 2025 18:03:48 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7E9FC60443\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 11 Oct 2025 18:03:43 +0200 (CEST)", "from charm.hippo-penny.ts.net\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2E6BAF0F;\n\tSat, 11 Oct 2025 18:02:07 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"TLqXATX+\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1760198527;\n\tbh=Ha/BSR0e6IO1ScJhvHZHHgbiYlSuK3dxK9DL3yf6IJ4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=TLqXATX+j8s0fjx8nLwwuy//9sKIt9TNdUaZQ/2c+f2OhkMyXtsopTNAudyOnWitG\n\tcH+4O3Hv3ef4Y0XhawEmHR1OShItSTYproxkO88gj1kKrFZ+qJIZx30gadC7+IqMU/\n\t3x1lxaCwmXpKiQRWyhf/q+8TvZVMMpm0lfBEcdPw=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Cc": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[RFC PATCH 5/7] ipa: softipa: Pass IPACameraSensorInfo to configure", "Date": "Sat, 11 Oct 2025 17:03:33 +0100", "Message-ID": "<20251011160335.50578-6-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20251011160335.50578-1-kieran.bingham@ideasonboard.com>", "References": "<20251011160335.50578-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Pass the CameraSensorInfo in to the configure phase of the IPA from the\nCameraSensor class, allowing the context to be used when configuring the\nIPA.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n include/libcamera/ipa/soft.mojom | 1 +\n src/libcamera/pipeline/simple/simple.cpp | 10 ++++++++--\n 2 files changed, 9 insertions(+), 2 deletions(-)", "diff": "diff --git a/include/libcamera/ipa/soft.mojom b/include/libcamera/ipa/soft.mojom\nindex 3acac53981e7..7bdbb65b4458 100644\n--- a/include/libcamera/ipa/soft.mojom\n+++ b/include/libcamera/ipa/soft.mojom\n@@ -9,6 +9,7 @@ module ipa.soft;\n import \"include/libcamera/ipa/core.mojom\";\n \n struct IPAConfigInfo {\n+\tlibcamera.IPACameraSensorInfo sensorInfo;\n \tlibcamera.ControlInfoMap sensorControls;\n };\n \ndiff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex a7e7ac25bac2..7d56effec50b 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -1412,8 +1412,14 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n \tif (data->converter_) {\n \t\treturn data->converter_->configure(inputCfg, outputCfgs);\n \t} else {\n-\t\tipa::soft::IPAConfigInfo configInfo;\n-\t\tconfigInfo.sensorControls = data->sensor_->controls();\n+\t\tIPACameraSensorInfo sensorInfo;\n+\t\tret = data->sensor_->sensorInfo(&sensorInfo);\n+\t\tif (ret)\n+\t\t\treturn ret;\n+\n+\t\tipa::soft::IPAConfigInfo configInfo{ sensorInfo,\n+\t\t\t\t\t\t data->sensor_->controls() };\n+\n \t\treturn data->swIsp_->configure(inputCfg, outputCfgs, configInfo, &data->controlInfo_);\n \t}\n }\n", "prefixes": [ "RFC", "5/7" ] }