Patch Detail
Show a patch.
GET /api/1.1/patches/24584/?format=api
{ "id": 24584, "url": "https://patchwork.libcamera.org/api/1.1/patches/24584/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24584/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251010141826.42995-4-uajain@igalia.com>", "date": "2025-10-10T14:18:26", "name": "[3/3] gstreamer: Improve logging for buffer pool activation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "228460638239fca10565514251434254eecded2f", "submitter": { "id": 232, "url": "https://patchwork.libcamera.org/api/1.1/people/232/?format=api", "name": "Umang Jain", "email": "uajain@igalia.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24584/mbox/", "series": [ { "id": 5484, "url": "https://patchwork.libcamera.org/api/1.1/series/5484/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5484", "date": "2025-10-10T14:18:23", "name": "gstreamer: some assorted fixes", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5484/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24584/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24584/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 43B3CC3331\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 10 Oct 2025 14:18:21 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 97B6F6B626;\n\tFri, 10 Oct 2025 16:18:18 +0200 (CEST)", "from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F1CA76B599\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 10 Oct 2025 16:18:15 +0200 (CEST)", "from [49.36.127.56] (helo=uajain)\n\tby fanzine2.igalia.com with esmtpsa \n\t(Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)\n\t(Exim) id 1v7Dwl-007uJd-2Y; Fri, 10 Oct 2025 16:18:15 +0200" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=igalia.com header.i=@igalia.com\n\theader.b=\"nivqOuIB\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;\n\ts=20170329;\n\th=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=9XbOup754exRgtaqVxJCK4dfG7uRNLtEtiev6PZTboI=;\n\tb=nivqOuIBA6pFpi4W46+wi64unF\n\tqA1BZFMNEbdd1XxIbc0X1ttekjv90nst8frFmuZhtd0FFEqp7fu7y2cZ0too7jQHFQsw+zlX8soJR\n\tNckQMktE8R0j9vD9AT8Aa42aKZ0qec8SwBo2fZIrL39xSRR0pAhSHbYLNra3GbYdJ4bTwwLtpR42l\n\tHQfaTXUG+WmVPwVX4EVJ766hFsvKSgKHRmMUQVPjLvYkgZ1HZLLoG5Y7BYeromeD0G345+o8nR+3k\n\tU4fZ+TGSucav4YqSt6Qud5PlRAeW7gHmGL5aauqyEAwgAvp38jkS5kYkeGI9afKprb3j91UGBBwhq\n\trlQzBgeA==;", "From": "Umang Jain <uajain@igalia.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Nicolas Dufresne <nicolas.dufresne@collabora.com>,\n\tUmang Jain <uajain@igalia.com>", "Subject": "[PATCH 3/3] gstreamer: Improve logging for buffer pool activation", "Date": "Fri, 10 Oct 2025 19:48:26 +0530", "Message-ID": "<20251010141826.42995-4-uajain@igalia.com>", "X-Mailer": "git-send-email 2.50.1", "In-Reply-To": "<20251010141826.42995-1-uajain@igalia.com>", "References": "<20251010141826.42995-1-uajain@igalia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "If the negotiation is going to fail, log the GST_ELEMENT_ERROR in\ngst_libcamera_src_negotiate(), instead of logging in downstream method\nchain.\n\nSigned-off-by: Umang Jain <uajain@igalia.com>\n---\n src/gstreamer/gstlibcamerasrc.cpp | 10 ++++++----\n 1 file changed, 6 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\nindex a5dbdfd4..5a1b2676 100644\n--- a/src/gstreamer/gstlibcamerasrc.cpp\n+++ b/src/gstreamer/gstlibcamerasrc.cpp\n@@ -581,9 +581,7 @@ gst_libcamera_create_video_pool(GstLibcameraSrc *self, GstPad *srcpad,\n \t}\n \n \tif (!gst_buffer_pool_set_active(pool, true)) {\n-\t\tGST_ELEMENT_ERROR(self, RESOURCE, SETTINGS,\n-\t\t\t\t (\"Failed to active buffer pool\"),\n-\t\t\t\t (\"gst_libcamera_src_negotiate() failed.\"));\n+\t\tGST_ERROR(\"Failed to activate buffer pool\");\n \t\treturn { nullptr, -EINVAL };\n \t}\n \n@@ -686,8 +684,12 @@ gst_libcamera_src_negotiate(GstLibcameraSrc *self)\n \t\t\tstd::tie(video_pool, ret) =\n \t\t\t\tgst_libcamera_create_video_pool(self, srcpad,\n \t\t\t\t\t\t\t\tcaps, &info);\n-\t\t\tif (ret)\n+\t\t\tif (ret) {\n+\t\t\t\tGST_ELEMENT_ERROR(self, RESOURCE, SETTINGS,\n+\t\t\t\t\t\t (\"Failed to create video pool: %s\", g_strerror(-ret)),\n+\t\t\t\t\t\t (\"gst_libcamera_src_negotiate() failed.\"));\n \t\t\t\treturn false;\n+\t\t\t}\n \t\t}\n \n \t\tGstLibcameraPool *pool = gst_libcamera_pool_new(self->allocator,\n", "prefixes": [ "3/3" ] }