Patch Detail
Show a patch.
GET /api/1.1/patches/2457/?format=api
{ "id": 2457, "url": "https://patchwork.libcamera.org/api/1.1/patches/2457/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2457/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20191230120510.938333-8-niklas.soderlund@ragnatech.se>", "date": "2019-12-30T12:04:52", "name": "[libcamera-devel,v2,07/25] libcamera: v4l2_videodevice: Align which type variable is used in queueBuffer()", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "84e468fc782d740957b029b7e3604c5b4df20edb", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/1.1/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2457/mbox/", "series": [ { "id": 593, "url": "https://patchwork.libcamera.org/api/1.1/series/593/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=593", "date": "2019-12-30T12:04:45", "name": "libcamera: Rework buffer API", "version": 2, "mbox": "https://patchwork.libcamera.org/series/593/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2457/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2457/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net\n\t[195.74.38.228])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1E2936046B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 30 Dec 2019 13:05:55 +0100 (CET)", "from bismarck.berto.se (p4fca2fd0.dip0.t-ipconnect.de\n\t[79.202.47.208]) by bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA\n\tid baa976e1-2afc-11ea-a00b-005056917a89;\n\tMon, 30 Dec 2019 13:05:54 +0100 (CET)" ], "X-Halon-ID": "baa976e1-2afc-11ea-a00b-005056917a89", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 30 Dec 2019 13:04:52 +0100", "Message-Id": "<20191230120510.938333-8-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.24.1", "In-Reply-To": "<20191230120510.938333-1-niklas.soderlund@ragnatech.se>", "References": "<20191230120510.938333-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 07/25] libcamera: v4l2_videodevice:\n\tAlign which type variable is used in queueBuffer()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 30 Dec 2019 12:05:55 -0000" }, "content": "Reading V4L2VideoDevice::queueBuffer() is confusing since buf.type is\nfirst set to bufferType_ but then both variables are used in V4L2 macros\nto operate based on which type of buffer is being processed. Align on\nonly using buf.type since it has the most existing users.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/v4l2_videodevice.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\nindex f3f5303b7f470f63..2e3f6d00d4aae6ff 100644\n--- a/src/libcamera/v4l2_videodevice.cpp\n+++ b/src/libcamera/v4l2_videodevice.cpp\n@@ -1003,7 +1003,7 @@ int V4L2VideoDevice::queueBuffer(Buffer *buffer)\n \t\tbuf.m.planes = v4l2Planes;\n \t}\n \n-\tif (V4L2_TYPE_IS_OUTPUT(bufferType_)) {\n+\tif (V4L2_TYPE_IS_OUTPUT(buf.type)) {\n \t\tbuf.bytesused = buffer->bytesused_;\n \t\tbuf.sequence = buffer->sequence_;\n \t\tbuf.timestamp.tv_sec = buffer->timestamp_ / 1000000000;\n", "prefixes": [ "libcamera-devel", "v2", "07/25" ] }