Patch Detail
Show a patch.
GET /api/1.1/patches/24569/?format=api
{ "id": 24569, "url": "https://patchwork.libcamera.org/api/1.1/patches/24569/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24569/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251007-v4l2-params-v5-2-8db451a81398@ideasonboard.com>", "date": "2025-10-07T18:17:44", "name": "[v5,2/5] include: linux: Add v4l2-isp.h", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "2fd8a2ff462b805217233838b44596e407f28c4b", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/1.1/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24569/mbox/", "series": [ { "id": 5480, "url": "https://patchwork.libcamera.org/api/1.1/series/5480/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5480", "date": "2025-10-07T18:17:42", "name": "ipa: libipa: Introduce V4L2Params", "version": 5, "mbox": "https://patchwork.libcamera.org/series/5480/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24569/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24569/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BA913BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 7 Oct 2025 18:18:01 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A347E6B5AA;\n\tTue, 7 Oct 2025 20:17:57 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0E1EA6B5AA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 7 Oct 2025 20:17:54 +0200 (CEST)", "from [192.168.1.102] (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 14DA06DF;\n\tTue, 7 Oct 2025 20:16:20 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rP70+HhP\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1759860980;\n\tbh=Xn18toPmvYwkT3H1mYGXtvtgr+abkKDv+2itl2J4ueU=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=rP70+HhP50R31HKGJ6kWmKNUIG5psYNTARCh+Nt6E0y2rRDgfVGOV65JH6qGVZKOO\n\tjQVK2N/Q25Dg/0/wpHDXG/yA/zzu+hJv04bLX+0AMLJuPhjKLQB+SvVNsrvO3oj2+b\n\tqkVWHccACEYbceKtXKmoN5N0xsJxcWu7xlUvFkJY=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Date": "Tue, 07 Oct 2025 20:17:44 +0200", "Subject": "[PATCH v5 2/5] include: linux: Add v4l2-isp.h", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20251007-v4l2-params-v5-2-8db451a81398@ideasonboard.com>", "References": "<20251007-v4l2-params-v5-0-8db451a81398@ideasonboard.com>", "In-Reply-To": "<20251007-v4l2-params-v5-0-8db451a81398@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>, \n\tAntoine Bouyer <antoine.bouyer@nxp.com>, \n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "X-Mailer": "b4 0.14.2", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=4970;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=Xn18toPmvYwkT3H1mYGXtvtgr+abkKDv+2itl2J4ueU=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBo5VlPB76vOReh1tcmMk51bR6RRr74JJu8hTTd6\n\taS9agGucy6JAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCaOVZTwAKCRByNAaPFqFW\n\tPNHDEAClTCkNL0KXEUkhKLD2nZCCFNZ4WvEnYu2kNQcHJ2tXidm7oP7nNJPIVn7H5kzprg1cxT3\n\tFDBCW6ZyV1GLedJ4uR9o8Yi0uCdlKMF42+phxb4KXWWUEJY9tQRfs8Y3fho6qfgVe40CfGsB0o4\n\tlozka3vNH46N/eunUgcrgR0ANDblVRZ5Fnj/U06mKlljALTFgnJ3AMR5zRkpdbdKaYOh+NIdo17\n\tQsrAtpM1kGmZUs4keqUKkeZVT0mVKivfip5TRqzr+X4h0smcs9h/LFu+YJ79Mf8GJN2quRMQGNP\n\to9NdO6rqrH6l5DLBftIGTdwTm05b9pLEnU7PBaUyT2zhTBwxm2ZQt9A6foO77kDcwtJfSHlStVy\n\tpWzhw5t1fR03AXRn3OXoWM4HoEsQGJUjw4gG0fuwd1d8By+3oTrgAjlfiJAMsAswzxdbOETuRuC\n\tuunjBMQSlWQa3P/KiL4Vmd8baqZZzh2wQqL0xpiDKRb3lnTYZl5TimJaqTR1UHQ1T6pl6rI7CoT\n\tFF0YzpzlW81FuWee6E1ja8ZrcrbMLpUJe6ezUQTFUZL9BZ1nBCHOOCMKHS7Z5aOQeflGhRvp9pS\n\txst3tsazDDqgPEsdErjaydiLOucBD9HSB/vd+PMwoBBSsABlwV83F46ix1Cc0X10E/yiJeOktQN\n\tvlchy4xXS1k7R1A==", "X-Developer-Key": "i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Import the v4l2-isp.h header from the Linux kernel sources.\n\nThe file has not been merged in mainline Linux yet but is available\nat v6:\nhttps://lore.kernel.org/all/20251007-extensible-parameters-validation-v6-1-5f719d9f39e5@ideasonboard.com\n\nCreate the include/linux/media/ directory so that header files\nexported from the kernel which include this file do not need\nto be adjusted when imported in libcamera.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nTested-by: Antoine Bouyer <antoine.bouyer@nxp.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n include/linux/media/v4l2-isp.h | 82 ++++++++++++++++++++++++++++++++++++++++++\n utils/update-kernel-headers.sh | 1 +\n 2 files changed, 83 insertions(+)", "diff": "diff --git a/include/linux/media/v4l2-isp.h b/include/linux/media/v4l2-isp.h\nnew file mode 100644\nindex 0000000000000000000000000000000000000000..49b451e30d88cce7d15ab40e6a3d533c7bb7a12c\n--- /dev/null\n+++ b/include/linux/media/v4l2-isp.h\n@@ -0,0 +1,82 @@\n+/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */\n+/*\n+ * Video4Linux2 generic ISP parameters and statistics support\n+ *\n+ * Copyright (C) 2025 Ideas On Board Oy\n+ * Author: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n+ */\n+\n+#ifndef _V4L2_ISP_H_\n+#define _V4L2_ISP_H_\n+\n+#include <linux/stddef.h>\n+#include <linux/types.h>\n+\n+#define V4L2_ISP_PARAMS_FL_BLOCK_DISABLE\t(1U << 0)\n+#define V4L2_ISP_PARAMS_FL_BLOCK_ENABLE\t(1U << 1)\n+\n+/*\n+ * Reserve the first 8 bits for V4L2_ISP_PARAMS_FL_* flag.\n+ *\n+ * Driver-specific flags should be defined as:\n+ * #define DRIVER_SPECIFIC_FLAG0 ((1U << V4L2_ISP_PARAMS_FL_DRIVER_FLAGS(0))\n+ * #define DRIVER_SPECIFIC_FLAG1 ((1U << V4L2_ISP_PARAMS_FL_DRIVER_FLAGS(1))\n+ */\n+#define V4L2_ISP_PARAMS_FL_DRIVER_FLAGS(n) ((n) + 8)\n+\n+/**\n+ * struct v4l2_isp_params_block_header - V4L2 extensible parameters block header\n+ * @type: The parameters block type (driver-specific)\n+ * @flags: A bitmask of block flags (driver-specific)\n+ * @size: Size (in bytes) of the parameters block, including this header\n+ *\n+ * This structure represents the common part of all the ISP configuration\n+ * blocks. Each parameters block shall embed an instance of this structure type\n+ * as its first member, followed by the block-specific configuration data.\n+ *\n+ * The @type field is an ISP driver-specific value that identifies the block\n+ * type. The @size field specifies the size of the parameters block.\n+ *\n+ * The @flags field is a bitmask of per-block flags V4L2_PARAMS_ISP_FL_* and\n+ * driver-specific flags specified by the driver header.\n+ */\n+struct v4l2_isp_params_block_header {\n+\t__u16 type;\n+\t__u16 flags;\n+\t__u32 size;\n+} __attribute__((aligned(8)));\n+\n+/**\n+ * struct v4l2_isp_params_buffer - V4L2 extensible parameters configuration\n+ * @version: The parameters buffer version (driver-specific)\n+ * @data_size: The configuration data effective size, excluding this header\n+ * @data: The configuration data\n+ *\n+ * This structure contains the configuration parameters of the ISP algorithms,\n+ * serialized by userspace into a data buffer. Each configuration parameter\n+ * block is represented by a block-specific structure which contains a\n+ * :c:type:`v4l2_isp_params_block_header` entry as first member. Userspace\n+ * populates the @data buffer with configuration parameters for the blocks that\n+ * it intends to configure. As a consequence, the data buffer effective size\n+ * changes according to the number of ISP blocks that userspace intends to\n+ * configure and is set by userspace in the @data_size field.\n+ *\n+ * The parameters buffer is versioned by the @version field to allow modifying\n+ * and extending its definition. Userspace shall populate the @version field to\n+ * inform the driver about the version it intends to use. The driver will parse\n+ * and handle the @data buffer according to the data layout specific to the\n+ * indicated version and return an error if the desired version is not\n+ * supported.\n+ *\n+ * For each ISP block that userspace wants to configure, a block-specific\n+ * structure is appended to the @data buffer, one after the other without gaps\n+ * in between. Userspace shall populate the @data_size field with the effective\n+ * size, in bytes, of the @data buffer.\n+ */\n+struct v4l2_isp_params_buffer {\n+\t__u32 version;\n+\t__u32 data_size;\n+\t__u8 data[] __counted_by(data_size);\n+};\n+\n+#endif /* _V4L2_ISP_H_ */\ndiff --git a/utils/update-kernel-headers.sh b/utils/update-kernel-headers.sh\nindex 666624f9972ea61067e5b5695237ab7a17c61664..857601df8766c6493e51b62f0f9ca551d7efbd4a 100755\n--- a/utils/update-kernel-headers.sh\n+++ b/utils/update-kernel-headers.sh\n@@ -56,6 +56,7 @@ headers=\"\n \tlinux/udmabuf.h\n \tlinux/v4l2-common.h\n \tlinux/v4l2-controls.h\n+\tlinux/v4l2-isp.h\n \tlinux/v4l2-mediabus.h\n \tlinux/v4l2-subdev.h\n \tlinux/videodev2.h\n", "prefixes": [ "v5", "2/5" ] }