Patch Detail
Show a patch.
GET /api/1.1/patches/24556/?format=api
{ "id": 24556, "url": "https://patchwork.libcamera.org/api/1.1/patches/24556/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24556/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251003-ipa-match-by-name-v1-2-07b796729412@ideasonboard.com>", "date": "2025-10-03T09:27:30", "name": "[2/2] ipa: ipa_module: Remove pipelineName", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "b69ad0df66719c36049d4be386dc3f049b4011ce", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/1.1/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24556/mbox/", "series": [ { "id": 5476, "url": "https://patchwork.libcamera.org/api/1.1/series/5476/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5476", "date": "2025-10-03T09:27:28", "name": "ipa: Allow IPA creation by name", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5476/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24556/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24556/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 94479C3261\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 3 Oct 2025 09:27:48 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 23F4D6B5FE;\n\tFri, 3 Oct 2025 11:27:45 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 787F16B5F0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 3 Oct 2025 11:27:40 +0200 (CEST)", "from [192.168.1.102] (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8EBC219DC;\n\tFri, 3 Oct 2025 11:26:09 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Wwki69jI\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1759483569;\n\tbh=hLwTmOJVVPHSSQUncjmyXZHEHG/cMq3kRVtjAUQ1jPM=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=Wwki69jIEEMqcBJuRuUBTRwItJ5m6EOawhp+nkfa1f7t0ESO2iDq9xQ0gLHQMkl/b\n\tctIYxo+RCReYoShznKD2pvnQUyVwsMSNIqO111vFV360OGRqF8tUkeoTtjW998WLi0\n\tkDXiw2Q73h5bWRzEWUJ5tiWoZh+z5lc+OJNCLsXk=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Date": "Fri, 03 Oct 2025 11:27:30 +0200", "Subject": "[PATCH 2/2] ipa: ipa_module: Remove pipelineName", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20251003-ipa-match-by-name-v1-2-07b796729412@ideasonboard.com>", "References": "<20251003-ipa-match-by-name-v1-0-07b796729412@ideasonboard.com>", "In-Reply-To": "<20251003-ipa-match-by-name-v1-0-07b796729412@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org, =?utf-8?q?Niklas_S=C3=B6derlund?=\n\t<niklas.soderlund+renesas@ragnatech.se>, Hans de Goede <hansg@kernel.org>", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "X-Mailer": "b4 0.14.2", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=6631;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=hLwTmOJVVPHSSQUncjmyXZHEHG/cMq3kRVtjAUQ1jPM=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBo35cKQ2ew+5YL/czJ7tksfo15gqpgOSZV4Z6Nz\n\tk6UoblaxbuJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCaN+XCgAKCRByNAaPFqFW\n\tPGBlEACb5vZXBJMHrwN52XbQsF8b4BmYqBaQDCmjnLr80JRzviqL3Z73gxUVlWMK9PhnQvJ8TkV\n\tzHV2tkiNQoCxEm6T1W8mhTJWzwQbHFhhEwmsyOjakZATzdoB8fN4aKJjnOS5h24Iy0YsXlgYo03\n\tYrV4+lKc2TZr6bY5E6TWwHNx72kJmZwEsA1Ghe1drwLRKvQX7eyFC4l3wdtATMfF8Nc+gCdYRec\n\tplMBHqYXmq8N/mGbThMAKVgo5q+GPHZKjbhWPlrjvDTyoRwmE32U6bXARGKGVA10q+XBfURDMU7\n\tM1Dmh/1sJMvOikxIWjV67wdU56j3wCezbPpr3MNIMRa3cK/N/3HF6v1MD/3pFwCCAYqdAkExots\n\truBS+Qnsk8wU4pxg7d0POo7wYDbzkrlIvqPwcID2mrXQjW0U2G52C36VFA6DS2+hqvRMfB862wi\n\tvYcYGV/DwqC7My96rDkfvhvq6QQpy2QLyDaFjSxdzHa+Hk2PBLOAoe7OMLIIA9N8SZPVF9NdzUG\n\twMMytQWLYgf1RqWsFMHu6NxXPcr7u5Gjd6YsjbRM5hat/i10FhK789RYvaBFPF2j5Tlbb5Y1B53\n\toVak4OEg7gcHA8hghvoCuo+IrB/5TLKOBDz9kzty0Myt7gAxFv+0fwMvcNxD9Rhu1slsL05pQyx\n\tmRm4LN+cgfymFzw==", "X-Developer-Key": "i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "All the IPA modules declare a pipelineName that is identical\nto their name. As we now support creating IPAs by name\n(either explicitly provided by the pipeline handlers or by using the\npipeline name), the duplicated information in IPAModuleInfo is\nredundant.\n\nRemove it.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n include/libcamera/ipa/ipa_module_info.h | 1 -\n src/ipa/ipu3/ipu3.cpp | 1 -\n src/ipa/mali-c55/mali-c55.cpp | 1 -\n src/ipa/rkisp1/rkisp1.cpp | 1 -\n src/ipa/rpi/pisp/pisp.cpp | 1 -\n src/ipa/rpi/vc4/vc4.cpp | 1 -\n src/ipa/simple/soft_simple.cpp | 1 -\n src/ipa/vimc/vimc.cpp | 1 -\n src/libcamera/ipa_module.cpp | 15 ++++++---------\n test/ipa/ipa_module_test.cpp | 3 ---\n 10 files changed, 6 insertions(+), 20 deletions(-)", "diff": "diff --git a/include/libcamera/ipa/ipa_module_info.h b/include/libcamera/ipa/ipa_module_info.h\nindex 3507a6d7678a3fd171c9239967d4667381ac3ea6..436ec82d7750d1ab7901499f4c4d88f0a173b563 100644\n--- a/include/libcamera/ipa/ipa_module_info.h\n+++ b/include/libcamera/ipa/ipa_module_info.h\n@@ -16,7 +16,6 @@ namespace libcamera {\n struct IPAModuleInfo {\n \tint moduleAPIVersion;\n \tuint32_t pipelineVersion;\n-\tchar pipelineName[256];\n \tchar name[256];\n } __attribute__((packed));\n \ndiff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex 1cae08bf255f6f53a0ebee02ba3aadda5a650ae3..a714024129b688b0579662ac7d6d9c3ffc15b62a 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -672,7 +672,6 @@ const struct IPAModuleInfo ipaModuleInfo = {\n \tIPA_MODULE_API_VERSION,\n \t1,\n \t\"ipu3\",\n-\t\"ipu3\",\n };\n \n /**\ndiff --git a/src/ipa/mali-c55/mali-c55.cpp b/src/ipa/mali-c55/mali-c55.cpp\nindex 7d45e7310aecdae0e47655e6d2e8830e776d74cd..e52e89be7c7e34310ca866bcbea2134833e967db 100644\n--- a/src/ipa/mali-c55/mali-c55.cpp\n+++ b/src/ipa/mali-c55/mali-c55.cpp\n@@ -387,7 +387,6 @@ const struct IPAModuleInfo ipaModuleInfo = {\n \tIPA_MODULE_API_VERSION,\n \t1,\n \t\"mali-c55\",\n-\t\"mali-c55\",\n };\n \n IPAInterface *ipaCreate()\ndiff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex fa22bfc349043002345d275b11a60ac983e329d7..a8e46094bdb9c431eb9143cccfa88e8ae7a3c04f 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -480,7 +480,6 @@ const struct IPAModuleInfo ipaModuleInfo = {\n \tIPA_MODULE_API_VERSION,\n \t1,\n \t\"rkisp1\",\n-\t\"rkisp1\",\n };\n \n IPAInterface *ipaCreate()\ndiff --git a/src/ipa/rpi/pisp/pisp.cpp b/src/ipa/rpi/pisp/pisp.cpp\nindex 829b912585223a0296a9709aca433d5240caea1b..9424cb4d129dda541a3cc5f9bacac56dc44f15da 100644\n--- a/src/ipa/rpi/pisp/pisp.cpp\n+++ b/src/ipa/rpi/pisp/pisp.cpp\n@@ -1089,7 +1089,6 @@ const IPAModuleInfo ipaModuleInfo = {\n \tIPA_MODULE_API_VERSION,\n \t1,\n \t\"rpi/pisp\",\n-\t\"rpi/pisp\",\n };\n \n IPAInterface *ipaCreate()\ndiff --git a/src/ipa/rpi/vc4/vc4.cpp b/src/ipa/rpi/vc4/vc4.cpp\nindex b2fec934480487c0c0566d510afd7a72129e441c..dc3455642ec71865d73662e6cd2d42bba61cadb8 100644\n--- a/src/ipa/rpi/vc4/vc4.cpp\n+++ b/src/ipa/rpi/vc4/vc4.cpp\n@@ -606,7 +606,6 @@ const struct IPAModuleInfo ipaModuleInfo = {\n \tIPA_MODULE_API_VERSION,\n \t1,\n \t\"rpi/vc4\",\n-\t\"rpi/vc4\",\n };\n \n IPAInterface *ipaCreate()\ndiff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\nindex b147aca2e3436cd79586063c4ee23f6698f266bf..9122f1c019ce1bb1c6a4d96e3fda664023391464 100644\n--- a/src/ipa/simple/soft_simple.cpp\n+++ b/src/ipa/simple/soft_simple.cpp\n@@ -350,7 +350,6 @@ const struct IPAModuleInfo ipaModuleInfo = {\n \tIPA_MODULE_API_VERSION,\n \t0,\n \t\"simple\",\n-\t\"simple\",\n };\n \n IPAInterface *ipaCreate()\ndiff --git a/src/ipa/vimc/vimc.cpp b/src/ipa/vimc/vimc.cpp\nindex a1351a0f45ce4ce6afed3151001eb74b10090c16..822e00aff2033e42254823b07ec396a50f71f182 100644\n--- a/src/ipa/vimc/vimc.cpp\n+++ b/src/ipa/vimc/vimc.cpp\n@@ -202,7 +202,6 @@ const struct IPAModuleInfo ipaModuleInfo = {\n \tIPA_MODULE_API_VERSION,\n \t0,\n \t\"vimc\",\n-\t\"vimc\",\n };\n \n IPAInterface *ipaCreate()\ndiff --git a/src/libcamera/ipa_module.cpp b/src/libcamera/ipa_module.cpp\nindex 0bd6f14626fe2038072f48b70ca4341b0eb8cef5..53cea6b187e86f20628d3b51c47097836801b094 100644\n--- a/src/libcamera/ipa_module.cpp\n+++ b/src/libcamera/ipa_module.cpp\n@@ -215,18 +215,15 @@ Span<const uint8_t> elfLoadSymbol(Span<const uint8_t> elf, const char *symbol)\n * \\var IPAModuleInfo::pipelineVersion\n * \\brief The pipeline handler version that the IPA module is for\n *\n- * \\var IPAModuleInfo::pipelineName\n- * \\brief The name of the pipeline handler that the IPA module is for\n- *\n- * This name is used to match a pipeline handler with the module.\n- *\n * \\var IPAModuleInfo::name\n * \\brief The name of the IPA module\n *\n- * The name may be used to build file system paths to IPA-specific resources.\n- * It shall only contain printable characters, and may not contain '*', '?' or\n- * '\\'. For IPA modules included in libcamera, it shall match the directory of\n- * the IPA module in the source tree.\n+ * This name is used to match a the IPA module.\n+ *\n+ * The name may also be used to build file system paths to IPA-specific\n+ * resources. It shall only contain printable characters, and may not contain\n+ * '*', '?' or '\\'. For IPA modules included in libcamera, it shall match the\n+ * directory of the IPA module in the source tree.\n *\n * \\todo Allow user to choose to isolate open source IPAs\n */\ndiff --git a/test/ipa/ipa_module_test.cpp b/test/ipa/ipa_module_test.cpp\nindex 1c97da3242a7d558c52dce6ed3bc9b5f76742944..af71c3285328263da71643da97e7b8c440d9a7ad 100644\n--- a/test/ipa/ipa_module_test.cpp\n+++ b/test/ipa/ipa_module_test.cpp\n@@ -37,12 +37,10 @@ protected:\n \t\t\tcerr << \"IPA module information mismatch: expected:\" << endl\n \t\t\t << \"moduleAPIVersion = \" << testInfo.moduleAPIVersion << endl\n \t\t\t << \"pipelineVersion = \" << testInfo.pipelineVersion << endl\n-\t\t\t << \"pipelineName = \" << testInfo.pipelineName << endl\n \t\t\t << \"name = \" << testInfo.name\n \t\t\t << \"got: \" << endl\n \t\t\t << \"moduleAPIVersion = \" << info.moduleAPIVersion << endl\n \t\t\t << \"pipelineVersion = \" << info.pipelineVersion << endl\n-\t\t\t << \"pipelineName = \" << info.pipelineName << endl\n \t\t\t << \"name = \" << info.name << endl;\n \t\t}\n \n@@ -58,7 +56,6 @@ protected:\n \t\t\tIPA_MODULE_API_VERSION,\n \t\t\t0,\n \t\t\t\"vimc\",\n-\t\t\t\"vimc\",\n \t\t};\n \n \t\tcount += runTest(\"src/ipa/vimc/ipa_vimc.so\", testInfo);\n", "prefixes": [ "2/2" ] }