Patch Detail
Show a patch.
GET /api/1.1/patches/24520/?format=api
{ "id": 24520, "url": "https://patchwork.libcamera.org/api/1.1/patches/24520/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24520/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250930122726.1837524-22-stefan.klug@ideasonboard.com>", "date": "2025-09-30T12:26:42", "name": "[v1,21/33] libcamera: converter_dw100: Use vertex map", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "6485e06f22fd4c5a16e12299ab8b65894e075473", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24520/mbox/", "series": [ { "id": 5468, "url": "https://patchwork.libcamera.org/api/1.1/series/5468/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5468", "date": "2025-09-30T12:26:21", "name": "Full dewarper support on imx8mp", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5468/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24520/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24520/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1D45EC324C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 30 Sep 2025 13:17:55 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 22A7669367;\n\tTue, 30 Sep 2025 15:17:54 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C11FE62C35\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 30 Sep 2025 15:17:51 +0200 (CEST)", "from ideasonboard.com (unknown [94.31.94.171])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 72B6E16A;\n\tTue, 30 Sep 2025 15:16:23 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"VxDXJZI7\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1759238183;\n\tbh=6OOK1o9IMeYeiegQx9AWgicb0Xvhn5T5YIoQU0C2fsQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=VxDXJZI71sfkrDMlvneosfZop/1eW8jmEdL8BbhuMnGsFSGhJr6gYHmKvyFyoP+hF\n\tzhnd8g+j9Dku4V022q430qU+CHz39CbWXqF62ZTuuTIs0ljjVusPaNIEnlOrQnQT38\n\tMoSEuuPe+3W2dxu5BwD3KYON7MLxX8nCzP71jWZ0=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH v1 21/33] libcamera: converter_dw100: Use vertex map", "Date": "Tue, 30 Sep 2025 14:26:42 +0200", "Message-ID": "<20250930122726.1837524-22-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.48.1", "In-Reply-To": "<20250930122726.1837524-1-stefan.klug@ideasonboard.com>", "References": "<20250930122726.1837524-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Use the new vertexmap class in the dw100 dewarper implementation.\n\nAs the dw100 kernel driver does not use the requests API, controls can\nnot be tied to a buffer. In the case that the dewarper has buffers\nqueued for which processing has not yet started, applying the dewarp map\nwould apply to an already queued buffer. Warn when this situation\noccurs.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n\n---\n\nChanges in v0.9:\n- Include requests support\n\nChanges in v0.8:\n- Added warning when queue is not empty\n---\n .../internal/converter/converter_dw100.h | 19 +++++++\n .../internal/converter/converter_v4l2_m2m.h | 4 +-\n src/libcamera/converter/converter_dw100.cpp | 56 +++++++++++++++++++\n 3 files changed, 77 insertions(+), 2 deletions(-)", "diff": "diff --git a/include/libcamera/internal/converter/converter_dw100.h b/include/libcamera/internal/converter/converter_dw100.h\nindex deb0125a0dbc..dabd442fcc98 100644\n--- a/include/libcamera/internal/converter/converter_dw100.h\n+++ b/include/libcamera/internal/converter/converter_dw100.h\n@@ -7,6 +7,7 @@\n \n #pragma once\n \n+#include \"libcamera/internal/converter/converter_dw100_vertexmap.h\"\n #include \"libcamera/internal/converter/converter_v4l2_m2m.h\"\n \n namespace libcamera {\n@@ -20,7 +21,25 @@ class ConverterDW100 : public V4L2M2MConverter\n public:\n \tConverterDW100(std::shared_ptr<MediaDevice> media);\n \n+\tint applyVertexMap(const Stream *stream, const V4L2Request *request = nullptr);\n+\tDw100VertexMap &vertexMap(const Stream *stream);\n+\n \tvoid validateSize(Size *size) const;\n+\n+private:\n+\tstd::unique_ptr<V4L2M2MStream> makeStream(const Stream *stream) override;\n+\tclass DW100Stream : public V4L2M2MConverter::V4L2M2MStream\n+\t{\n+\tpublic:\n+\t\tDW100Stream(V4L2M2MConverter *converter, const Stream *stream);\n+\n+\t\tint configure(const StreamConfiguration &inputCfg,\n+\t\t\t const StreamConfiguration &outputCfg) override;\n+\n+\t\tint applyVertexMap(const V4L2Request *request = nullptr);\n+\n+\t\tDw100VertexMap vertexMap_;\n+\t};\n };\n \n } /* namespace libcamera */\ndiff --git a/include/libcamera/internal/converter/converter_v4l2_m2m.h b/include/libcamera/internal/converter/converter_v4l2_m2m.h\nindex 033c4ba42292..41b4fcc4c853 100644\n--- a/include/libcamera/internal/converter/converter_v4l2_m2m.h\n+++ b/include/libcamera/internal/converter/converter_v4l2_m2m.h\n@@ -89,8 +89,8 @@ protected:\n \n \t\tbool isValid() const { return m2m_ != nullptr; }\n \n-\t\tint configure(const StreamConfiguration &inputCfg,\n-\t\t\t const StreamConfiguration &outputCfg);\n+\t\tvirtual int configure(const StreamConfiguration &inputCfg,\n+\t\t\t\t const StreamConfiguration &outputCfg);\n \t\tint exportBuffers(unsigned int count,\n \t\t\t\t std::vector<std::unique_ptr<FrameBuffer>> *buffers);\n \ndiff --git a/src/libcamera/converter/converter_dw100.cpp b/src/libcamera/converter/converter_dw100.cpp\nindex da1d88214a6e..994b31d44d47 100644\n--- a/src/libcamera/converter/converter_dw100.cpp\n+++ b/src/libcamera/converter/converter_dw100.cpp\n@@ -7,9 +7,12 @@\n \n #include \"libcamera/internal/converter/converter_dw100.h\"\n \n+#include <linux/dw100.h>\n+\n #include <libcamera/base/log.h>\n \n #include <libcamera/geometry.h>\n+#include <libcamera/stream.h>\n \n #include \"libcamera/internal/media_device.h\"\n #include \"libcamera/internal/v4l2_videodevice.h\"\n@@ -34,10 +37,63 @@ ConverterDW100::ConverterDW100(std::shared_ptr<MediaDevice> media)\n {\n }\n \n+int ConverterDW100::applyVertexMap(const Stream *stream, const V4L2Request *request)\n+{\n+\tauto iter = streams_.find(stream);\n+\tif (iter == streams_.end())\n+\t\treturn -EINVAL;\n+\n+\treturn dynamic_cast<DW100Stream *>(iter->second.get())->applyVertexMap(request);\n+}\n+\n+Dw100VertexMap &ConverterDW100::vertexMap(const Stream *stream)\n+{\n+\tauto iter = streams_.find(stream);\n+\tV4L2M2MConverter::V4L2M2MStream *s = iter->second.get();\n+\tASSERT(s);\n+\treturn dynamic_cast<DW100Stream *>(s)->vertexMap_;\n+}\n+\n void ConverterDW100::validateSize(Size *size) const\n {\n \tif (size)\n \t\tsize->alignDownTo(8, 8);\n }\n \n+std::unique_ptr<V4L2M2MConverter::V4L2M2MStream> ConverterDW100::makeStream(const Stream *stream)\n+{\n+\treturn std::unique_ptr<V4L2M2MConverter::V4L2M2MStream>(new DW100Stream(this, stream));\n+}\n+\n+ConverterDW100::DW100Stream::DW100Stream(V4L2M2MConverter *converter,\n+\t\t\t\t\t const Stream *stream)\n+\t: V4L2M2MConverter::V4L2M2MStream(converter, stream)\n+{\n+}\n+\n+int ConverterDW100::DW100Stream::configure(const StreamConfiguration &inputCfg,\n+\t\t\t\t\t const StreamConfiguration &outputCfg)\n+{\n+\tint ret;\n+\tret = V4L2M2MConverter::V4L2M2MStream::configure(inputCfg, outputCfg);\n+\tif (ret)\n+\t\treturn ret;\n+\n+\t/* Todo: is that comment still valid?\n+\t For actual dewarping we need the active area of the sensor mode here. */\n+\tvertexMap_.setInputSize(inputCfg.size);\n+\tvertexMap_.setOutputSize(outputCfg.size);\n+\treturn 0;\n+}\n+\n+int ConverterDW100::DW100Stream::applyVertexMap(const V4L2Request *request)\n+{\n+\tstd::vector<uint32_t> map = vertexMap_.getVertexMap();\n+\tauto value = Span<const int32_t>(reinterpret_cast<const int32_t *>(&map[0]), map.size());\n+\n+\tControlList ctrls;\n+\tctrls.set(V4L2_CID_DW100_DEWARPING_16x16_VERTEX_MAP, value);\n+\treturn applyControls(ctrls, request);\n+}\n+\n } /* namespace libcamera */\n", "prefixes": [ "v1", "21/33" ] }