Patch Detail
Show a patch.
GET /api/1.1/patches/24504/?format=api
{ "id": 24504, "url": "https://patchwork.libcamera.org/api/1.1/patches/24504/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24504/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250930124208.14391-2-robert.mader@collabora.com>", "date": "2025-09-30T12:42:08", "name": "[v3,2/2] pipeline: simple: Increase internal buffers for software ISP to 4", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "6c655b93548d91b318ce54ca2dbd15d3f5d92f43", "submitter": { "id": 140, "url": "https://patchwork.libcamera.org/api/1.1/people/140/?format=api", "name": "Robert Mader", "email": "robert.mader@collabora.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24504/mbox/", "series": [ { "id": 5469, "url": "https://patchwork.libcamera.org/api/1.1/series/5469/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5469", "date": "2025-09-30T12:42:07", "name": "[v3,1/2] pipeline: simple: Allow buffer counts from 1 to 32", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5469/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24504/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24504/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BD37CC324C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 30 Sep 2025 12:42:43 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6C0EA6B5F3;\n\tTue, 30 Sep 2025 14:42:43 +0200 (CEST)", "from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com\n\t[136.143.188.112])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AF8F76936E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 30 Sep 2025 14:42:40 +0200 (CEST)", "by mx.zohomail.com with SMTPS id 1759236155235449.64512151746453; \n\tTue, 30 Sep 2025 05:42:35 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=collabora.com\n\theader.i=robert.mader@collabora.com header.b=\"BvEw4IpS\"; \n\tdkim-atps=neutral", "ARC-Seal": "i=1; a=rsa-sha256; t=1759236157; cv=none; \n\td=zohomail.com; s=zohoarc; \n\tb=Dp2SUJ2reHGfDzavkNgK6YB8GhS3NoewDgVi9YZGxEg595Ti6I0FLF9TOPy+IOJeNqDkNQMQmLywdY7bYBoMe4a3iCk3O+JDWCcq2IDNWoSdwfNnfyXxUVgPqOi3VB9yQVlBSK0AeEDjCdm60iQ/xyST1BmrZrVnPXZgY9ljKQM=", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; \n\ts=zohoarc; t=1759236157;\n\th=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;\n\tbh=lewmQ3pFJYZKfPVu8AxdW3PwJ4VBMHRhi6uMLIuh9Uo=; \n\tb=eI+Unyhn8rAR/IOyRDOX8HUHHqPRSGhKOyQwR71S5+2iK/VApt5b52CdTRCaH3BVRiyCCYuJaLjcAllLBukPObOulGzv4dv3E/eaZSriiSmxuAatubdz44ibyBaT/gjtUtq0WEiiNWA0JyMFTt4xrq9S31WykTQRoZaGb0GU9gI=", "ARC-Authentication-Results": "i=1; mx.zohomail.com;\n\tdkim=pass header.i=collabora.com;\n\tspf=pass smtp.mailfrom=robert.mader@collabora.com;\n\tdmarc=pass header.from=<robert.mader@collabora.com>", "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1759236157;\n\ts=zohomail; d=collabora.com; i=robert.mader@collabora.com;\n\th=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To;\n\tbh=lewmQ3pFJYZKfPVu8AxdW3PwJ4VBMHRhi6uMLIuh9Uo=;\n\tb=BvEw4IpSSybc/AThLwvMvmm6IwNIZIIRDwXHpVTWK3jLXmG3tkcZJUrR597hFDdD\n\tYuy19u3g3i09pAUWBHgWhTDCSOF77JcPEV/sccw3LBOkzwbLGcS0UP4jUxwHE2Y0OM+\n\t2iW0p/HZN2+VOVNvs7y7isfwjXycqML3hU5mOJPM=", "From": "Robert Mader <robert.mader@collabora.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Robert Mader <robert.mader@collabora.com>,\n\tMilan Zamazal <mzamazal@redhat.com>", "Subject": "[PATCH v3 2/2] pipeline: simple: Increase internal buffers for\n\tsoftware ISP to 4", "Date": "Tue, 30 Sep 2025 14:42:08 +0200", "Message-ID": "<20250930124208.14391-2-robert.mader@collabora.com>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20250930124208.14391-1-robert.mader@collabora.com>", "References": "<20250930124208.14391-1-robert.mader@collabora.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This has been shipped downstream in postmarketOS for a while and, in\nsome cases, seems to improve stability on not-so-great drivers. It also\nbrings the software ISP in line with the default used otherwise.\n\nSigned-off-by: Robert Mader <robert.mader@collabora.com>\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/libcamera/pipeline/simple/simple.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 2dcba04ec..c4cb7c391 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -420,7 +420,7 @@ protected:\n \tint queueRequestDevice(Camera *camera, Request *request) override;\n \n private:\n-\tstatic constexpr unsigned int kNumInternalBuffers = 3;\n+\tstatic constexpr unsigned int kNumInternalBuffers = 4;\n \n \tstruct EntityData {\n \t\tstd::unique_ptr<V4L2VideoDevice> video;\n", "prefixes": [ "v3", "2/2" ] }