Patch Detail
Show a patch.
GET /api/1.1/patches/24420/?format=api
{ "id": 24420, "url": "https://patchwork.libcamera.org/api/1.1/patches/24420/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24420/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250919094041.183031-12-stefan.klug@ideasonboard.com>", "date": "2025-09-19T09:40:26", "name": "[v5,11/19] pipeline: rkisp1: Add error log when parameter queuing fails", "commit_ref": "96d346c935ae9d5b1da3ab347bc82681ce0da824", "pull_url": null, "state": "accepted", "archived": false, "hash": "9c86de3ce4c5050a0f99bbcb6733be129f414363", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24420/mbox/", "series": [ { "id": 5450, "url": "https://patchwork.libcamera.org/api/1.1/series/5450/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5450", "date": "2025-09-19T09:40:15", "name": "Implement WDR algorithm", "version": 5, "mbox": "https://patchwork.libcamera.org/series/5450/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24420/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24420/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0C474C328C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 19 Sep 2025 09:41:30 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A97606B5C4;\n\tFri, 19 Sep 2025 11:41:29 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8E6AF6B5BF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 19 Sep 2025 11:41:25 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:4d54:eab8:98ca:163b])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 2052E99F;\n\tFri, 19 Sep 2025 11:40:05 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"TnuiEtUL\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1758274805;\n\tbh=ZEdXfHFpaIB4O0iiGoYtfIMWXOEazI7FHupCfh9Hz/c=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=TnuiEtUL6PQZ8YQDV0ji+LtoCzaZSmXqu8hcqCWMkfGnqEcHl4UJUB1HYtTLYa3sl\n\tHqBO0q0mYkWmJKIbjK1vNibTL0OXLRG2myIS/LW/hZQOEQA7w/0JdDfMkps6ygQEwR\n\t0GJrxN8lwOVqX8ogqtEcPl+2c8kGeuTYwpjTGXwU=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tPaul Elder <paul.elder@ideasonboard.com>,\n\tDaniel Scally <dan.scally@ideasonboard.com>", "Subject": "[PATCH v5 11/19] pipeline: rkisp1: Add error log when parameter\n\tqueuing fails", "Date": "Fri, 19 Sep 2025 11:40:26 +0200", "Message-ID": "<20250919094041.183031-12-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.48.1", "In-Reply-To": "<20250919094041.183031-1-stefan.klug@ideasonboard.com>", "References": "<20250919094041.183031-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When the extensible parameters queued to the kernel contain an unknown\nblock type it fails with -EINVAL. This should not happen as user land is\nsupposed to check for the supported parameter types. But it took a while\nto figure out where things went wrong. Add a error statement when\nqueuing of the parameter buffer fails for whatever reason.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Daniel Scally <dan.scally@ideasonboard.com>\n\n---\n\nChanges in v3:\n- Collected tag\n\nChangelog from former series:\nChanges in v4:\n- Improved commit message\n\nChanges in v3:\n- Collected tags\n- Removed hint regarding unsupported parameter types as this will be\n handled using the now upstreamed RKISP1_CID_SUPPORTED_PARAMS_BLOCKS.\n\nChanges in v2:\n- Also print the error code in case of failure\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 9 ++++++++-\n 1 file changed, 8 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex cfcbb3b2590a..a91a443aeaf7 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -422,7 +422,14 @@ void RkISP1CameraData::paramsComputed(unsigned int frame, unsigned int bytesused\n \t\treturn;\n \n \tinfo->paramBuffer->_d()->metadata().planes()[0].bytesused = bytesused;\n-\tpipe->param_->queueBuffer(info->paramBuffer);\n+\n+\tint ret = pipe->param_->queueBuffer(info->paramBuffer);\n+\tif (ret < 0) {\n+\t\tLOG(RkISP1, Error) << \"Failed to queue parameter buffer: \"\n+\t\t\t\t << strerror(-ret);\n+\t\treturn;\n+\t}\n+\n \tpipe->stat_->queueBuffer(info->statBuffer);\n \n \tif (info->mainPathBuffer)\n", "prefixes": [ "v5", "11/19" ] }