Patch Detail
Show a patch.
GET /api/1.1/patches/24417/?format=api
{ "id": 24417, "url": "https://patchwork.libcamera.org/api/1.1/patches/24417/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24417/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250919094041.183031-9-stefan.klug@ideasonboard.com>", "date": "2025-09-19T09:40:23", "name": "[v5,08/19] libipa: agc_mean_luminance: Configure the exposure mode helpers", "commit_ref": "0ba6d930def82efbea78acbb6c8225f687b08b05", "pull_url": null, "state": "accepted", "archived": false, "hash": "13ca149f114e10d907990eefc0947321c3528bdb", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24417/mbox/", "series": [ { "id": 5450, "url": "https://patchwork.libcamera.org/api/1.1/series/5450/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5450", "date": "2025-09-19T09:40:15", "name": "Implement WDR algorithm", "version": 5, "mbox": "https://patchwork.libcamera.org/series/5450/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24417/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24417/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 772B6C328C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 19 Sep 2025 09:41:21 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C08716B5B2;\n\tFri, 19 Sep 2025 11:41:20 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 23A166B5A7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 19 Sep 2025 11:41:17 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:4d54:eab8:98ca:163b])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id EED6C819;\n\tFri, 19 Sep 2025 11:39:56 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"oQQQBmaE\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1758274797;\n\tbh=0vf3lFwYoPER+hvWa/iUoCJV/5mJeZC6GD89iKVaKnw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=oQQQBmaEAK7lNmVbPGkvBIl7CXfVRofSkLXxYleAp5/bHL0TmK8wYxrqnR4DdGQSx\n\tjjTk9cJQM4ah7n4eeLAHmDUxrZrOXVX9wTBzMwFlhACSPXKXFtX9Oi/067ZS4TNWnz\n\tvt8M6hM98fEx+Pdr7wIAXkWuJrj8w6D9NWc0+iqg=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>,\n\tDaniel Scally <dan.scally@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tPaul Elder <paul.elder@ideasonboard.com>", "Subject": "[PATCH v5 08/19] libipa: agc_mean_luminance: Configure the exposure\n\tmode helpers", "Date": "Fri, 19 Sep 2025 11:40:23 +0200", "Message-ID": "<20250919094041.183031-9-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.48.1", "In-Reply-To": "<20250919094041.183031-1-stefan.klug@ideasonboard.com>", "References": "<20250919094041.183031-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a function to configure the exposure mode helpers with the line\nlength and sensor helper to take quantization effects into account.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\nReviewed-by: Daniel Scally <dan.scally@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\n\nChanges in v4:\n- Fixed wrong variable name in configure() documentation\n- Collected tags\n\nChanges in v3:\n- Renamed lineLength to lineDuration\n- Collected tag\n---\n src/ipa/libipa/agc_mean_luminance.cpp | 15 +++++++++++++++\n src/ipa/libipa/agc_mean_luminance.h | 1 +\n 2 files changed, 16 insertions(+)", "diff": "diff --git a/src/ipa/libipa/agc_mean_luminance.cpp b/src/ipa/libipa/agc_mean_luminance.cpp\nindex fce1a5064870..ea4709bf4e49 100644\n--- a/src/ipa/libipa/agc_mean_luminance.cpp\n+++ b/src/ipa/libipa/agc_mean_luminance.cpp\n@@ -311,6 +311,21 @@ int AgcMeanLuminance::parseExposureModes(const YamlObject &tuningData)\n \treturn 0;\n }\n \n+/**\n+ * \\brief Configure the exposure mode helpers\n+ * \\param[in] lineDuration The sensor line length\n+ * \\param[in] sensorHelper The sensor helper\n+ *\n+ * This function configures the exposure mode helpers so they can correctly\n+ * take quantization effects into account.\n+ */\n+void AgcMeanLuminance::configure(utils::Duration lineDuration,\n+\t\t\t\t const CameraSensorHelper *sensorHelper)\n+{\n+\tfor (auto &[id, helper] : exposureModeHelpers_)\n+\t\thelper->configure(lineDuration, sensorHelper);\n+}\n+\n /**\n * \\brief Parse tuning data for AeConstraintMode and AeExposureMode controls\n * \\param[in] tuningData the YamlObject representing the tuning data\ndiff --git a/src/ipa/libipa/agc_mean_luminance.h b/src/ipa/libipa/agc_mean_luminance.h\nindex cad7ef845487..49985481ac51 100644\n--- a/src/ipa/libipa/agc_mean_luminance.h\n+++ b/src/ipa/libipa/agc_mean_luminance.h\n@@ -42,6 +42,7 @@ public:\n \t\tdouble yTarget;\n \t};\n \n+\tvoid configure(utils::Duration lineDuration, const CameraSensorHelper *sensorHelper);\n \tint parseTuningData(const YamlObject &tuningData);\n \n \tvoid setExposureCompensation(double gain)\n", "prefixes": [ "v5", "08/19" ] }