Patch Detail
Show a patch.
GET /api/1.1/patches/24404/?format=api
{ "id": 24404, "url": "https://patchwork.libcamera.org/api/1.1/patches/24404/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24404/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250918144333.108695-16-stefan.klug@ideasonboard.com>", "date": "2025-09-18T14:43:24", "name": "[v4,15/19] libipa: agc_mean_luminance: Introduce effectiveYTarget() accessor", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "e54e7d954e5dc5b726f2c754f2638b33517acf65", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24404/mbox/", "series": [ { "id": 5449, "url": "https://patchwork.libcamera.org/api/1.1/series/5449/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5449", "date": "2025-09-18T14:43:09", "name": "Implement WDR algorithm", "version": 4, "mbox": "https://patchwork.libcamera.org/series/5449/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24404/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24404/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 92763C328C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 18 Sep 2025 14:44:35 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F2BE469387;\n\tThu, 18 Sep 2025 16:44:34 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EE44169385\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Sep 2025 16:44:29 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:ace3:d2c2:5eff:9cc5])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 4A814C77;\n\tThu, 18 Sep 2025 16:43:10 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gmDatuUv\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1758206590;\n\tbh=NiZvUMrY2M4TQbAJAj4uMOM4cpMQWjAcK/qcd89IooM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=gmDatuUvsw5WdrELeK3JbEor7bmNnCqLdG0D/MyvpN0XF3ZEwz0A4pjwZBBxIbMky\n\tt7OaSwtckuX1pfkbQ5/u3jEVf9XCk/uNIz6jfz44IJ4mY6qx5EQcyJSRw4Ms4wLa0R\n\tNxMkIUBRvsI/jMCoGjBbISemw+V4aa32HAKi3ASg=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>,\n\tDaniel Scally <dan.scally@ideasonboard.com>,\n\tPaul ELder <paul.elder@ideasonboard.com>", "Subject": "[PATCH v4 15/19] libipa: agc_mean_luminance: Introduce\n\teffectiveYTarget() accessor", "Date": "Thu, 18 Sep 2025 16:43:24 +0200", "Message-ID": "<20250918144333.108695-16-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.48.1", "In-Reply-To": "<20250918144333.108695-1-stefan.klug@ideasonboard.com>", "References": "<20250918144333.108695-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The upcoming WDR algorithm needs to know the effective y target (Which\nincludes the current ExposureValue). Add an accessor for that.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\nReviewed-by: Daniel Scally <dan.scally@ideasonboard.com>\nReviewed-by: Paul ELder <paul.elder@ideasonboard.com>\n\n---\n\nChanges in v4:\n- Fixed typos in documentation\n- Collected tags\n\nChanges in v3:\n- Added this patch\n---\n src/ipa/libipa/agc_mean_luminance.cpp | 16 ++++++++++++++--\n src/ipa/libipa/agc_mean_luminance.h | 2 ++\n 2 files changed, 16 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/ipa/libipa/agc_mean_luminance.cpp b/src/ipa/libipa/agc_mean_luminance.cpp\nindex 41c7f72de8ed..45eba97516f3 100644\n--- a/src/ipa/libipa/agc_mean_luminance.cpp\n+++ b/src/ipa/libipa/agc_mean_luminance.cpp\n@@ -458,8 +458,7 @@ void AgcMeanLuminance::setLimits(utils::Duration minExposureTime,\n */\n double AgcMeanLuminance::estimateInitialGain() const\n {\n-\tdouble yTarget = std::min(relativeLuminanceTarget_ * exposureCompensation_,\n-\t\t\t\t kMaxRelativeLuminanceTarget);\n+\tdouble yTarget = effectiveYTarget();\n \tdouble yGain = 1.0;\n \n \t/*\n@@ -521,6 +520,19 @@ double AgcMeanLuminance::constraintClampGain(uint32_t constraintModeIndex,\n \treturn gain;\n }\n \n+/**\n+ * \\brief Get the currently effective y target\n+ *\n+ * This function returns the current y target including exposure compensation.\n+ *\n+ * \\return The y target value\n+ */\n+double AgcMeanLuminance::effectiveYTarget() const\n+{\n+\treturn std::min(relativeLuminanceTarget_ * exposureCompensation_,\n+\t\t\tkMaxRelativeLuminanceTarget);\n+}\n+\n /**\n * \\brief Apply a filter on the exposure value to limit the speed of changes\n * \\param[in] exposureValue The target exposure from the AGC algorithm\ndiff --git a/src/ipa/libipa/agc_mean_luminance.h b/src/ipa/libipa/agc_mean_luminance.h\nindex fbb526f6ae8e..950b7b893754 100644\n--- a/src/ipa/libipa/agc_mean_luminance.h\n+++ b/src/ipa/libipa/agc_mean_luminance.h\n@@ -72,6 +72,8 @@ public:\n \tcalculateNewEv(uint32_t constraintModeIndex, uint32_t exposureModeIndex,\n \t\t const Histogram &yHist, utils::Duration effectiveExposureValue);\n \n+\tdouble effectiveYTarget() const;\n+\n \tvoid resetFrameCount()\n \t{\n \t\tframeCount_ = 0;\n", "prefixes": [ "v4", "15/19" ] }