Patch Detail
Show a patch.
GET /api/1.1/patches/24394/?format=api
{ "id": 24394, "url": "https://patchwork.libcamera.org/api/1.1/patches/24394/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24394/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250918144333.108695-6-stefan.klug@ideasonboard.com>", "date": "2025-09-18T14:43:14", "name": "[v4,05/19] libipa: exposure_mode_helper: Remove double calculation of lastStageGain", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "eac1537c25257d3e61b6c45e4e3853e2e356bad4", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24394/mbox/", "series": [ { "id": 5449, "url": "https://patchwork.libcamera.org/api/1.1/series/5449/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5449", "date": "2025-09-18T14:43:09", "name": "Implement WDR algorithm", "version": 4, "mbox": "https://patchwork.libcamera.org/series/5449/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24394/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24394/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 91878C328C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 18 Sep 2025 14:44:04 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2F8346936D;\n\tThu, 18 Sep 2025 16:44:04 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D9BC96937E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Sep 2025 16:44:00 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:ace3:d2c2:5eff:9cc5])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 3F14C842;\n\tThu, 18 Sep 2025 16:42:41 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bpszyUw2\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1758206561;\n\tbh=GMp4tviTO5X+GDxI2B6CSa8Wv63WvQ0SUMM2BTCrffE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=bpszyUw2bklbe8tWQWU4xxmxgEuiRYiK5lIibszPz4MD7L/o9fS0PoVs11MiAs/Yo\n\tW30BMlVp7FBJkeqHhGvmF+/hn7VlzTrWBvIv/WK53o4DiZaXI0AlxfkGp8UfFSeVqs\n\tMaP+spsnY4WcpcLwAb2op+jn7ue2Sz06Eo1lg+VA=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tDaniel Scally <dan.scally@ideasonboard.com>,\n\tPaul Elder <paul.elder@ideasonboard.com>", "Subject": "[PATCH v4 05/19] libipa: exposure_mode_helper: Remove double\n\tcalculation of lastStageGain", "Date": "Thu, 18 Sep 2025 16:43:14 +0200", "Message-ID": "<20250918144333.108695-6-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.48.1", "In-Reply-To": "<20250918144333.108695-1-stefan.klug@ideasonboard.com>", "References": "<20250918144333.108695-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "lastStageGain gets recalculated unconditionally even though it is the\nstageGain of the last stage. Refactor for increased simplicity and\nefficiency.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Daniel Scally <dan.scally@ideasonboard.com>\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\n\nChanges in v4:\n- Collected tag\n\nChanges in v3:\n- Collected tags\n---\n src/ipa/libipa/exposure_mode_helper.cpp | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/libipa/exposure_mode_helper.cpp b/src/ipa/libipa/exposure_mode_helper.cpp\nindex b776a031b441..e806731047cf 100644\n--- a/src/ipa/libipa/exposure_mode_helper.cpp\n+++ b/src/ipa/libipa/exposure_mode_helper.cpp\n@@ -198,10 +198,10 @@ ExposureModeHelper::splitExposure(utils::Duration exposure) const\n \n \tutils::Duration exposureTime;\n \tdouble stageGain = 1.0;\n+\tdouble lastStageGain = 1.0;\n \tdouble gain;\n \n \tfor (unsigned int stage = 0; stage < gains_.size(); stage++) {\n-\t\tdouble lastStageGain = stage == 0 ? 1.0 : clampGain(gains_[stage - 1]);\n \t\tutils::Duration stageExposureTime = clampExposureTime(exposureTimes_[stage]);\n \t\tstageGain = clampGain(gains_[stage]);\n \n@@ -228,6 +228,8 @@ ExposureModeHelper::splitExposure(utils::Duration exposure) const\n \n \t\t\treturn { exposureTime, gain, exposure / (exposureTime * gain) };\n \t\t}\n+\n+\t\tlastStageGain = stageGain;\n \t}\n \n \t/*\n", "prefixes": [ "v4", "05/19" ] }