Patch Detail
Show a patch.
GET /api/1.1/patches/24368/?format=api
{ "id": 24368, "url": "https://patchwork.libcamera.org/api/1.1/patches/24368/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24368/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250916-v4l2-params-v2-1-764471ed6435@ideasonboard.com>", "date": "2025-09-16T12:28:22", "name": "[v2,1/4] include: linux: Add v4l2-isp.h", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "5878ea8aa36e549bf2d5081127ec29f94353e77d", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/1.1/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24368/mbox/", "series": [ { "id": 5445, "url": "https://patchwork.libcamera.org/api/1.1/series/5445/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5445", "date": "2025-09-16T12:28:21", "name": "ipa: libipa: Introduce V4L2Params", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5445/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24368/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24368/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7CF85BE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 16 Sep 2025 12:28:41 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E500169371;\n\tTue, 16 Sep 2025 14:28:40 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 266A269371\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 16 Sep 2025 14:28:38 +0200 (CEST)", "from [192.168.0.172] (mob-5-90-51-255.net.vodafone.it\n\t[5.90.51.255])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BAD64DF3;\n\tTue, 16 Sep 2025 14:27:18 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Gwj2Ci92\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1758025639;\n\tbh=m6UKSto21lH4DyPU8izBwOOwuVC+d0tBZtGMWkTJvDE=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=Gwj2Ci92up1nRJnXpqbV51ALSH2LtrMJVUuq39Qo9ulECneOQGFuOX+Bk8h1s9ppv\n\tCYmwvc81TdLL1FS5d2nVxpNFsNnUbIi2OFSxPTzYdlfD+uzmEVQphZEWgj6x2lw16p\n\t8eS2zBWIN4TvzcD8kHbqfkH0hS/zb82+ewuqgBm4=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Date": "Tue, 16 Sep 2025 14:28:22 +0200", "Subject": "[PATCH v2 1/4] include: linux: Add v4l2-isp.h", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20250916-v4l2-params-v2-1-764471ed6435@ideasonboard.com>", "References": "<20250916-v4l2-params-v2-0-764471ed6435@ideasonboard.com>", "In-Reply-To": "<20250916-v4l2-params-v2-0-764471ed6435@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>, \n\tAntoine Bouyer <antoine.bouyer@nxp.com>", "X-Mailer": "b4 0.14.2", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=5197;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=m6UKSto21lH4DyPU8izBwOOwuVC+d0tBZtGMWkTJvDE=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBoyVfxSEwUApcymPTjAHbZd4mSbHxBl85OsOgtE\n\tSE5QnUfYdWJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCaMlX8QAKCRByNAaPFqFW\n\tPLQuEACnuswjJZj8jnhLhYh3Yh528F8KskvQd094JKdZl+SX6rIOMchdEX8no/9F/9uNEBrWypo\n\tr8X9vJsg569qynYSPixsJP8SfZ/zNJHvUVXxZuQw61f+oyOXs3ayyabWOBvX0kopPmdXxrIM3vM\n\tspq8F65sRfk66QoHmaklPdMeViWfCf7VfintAVjx502/FI3kDC/+HcbBCIZLrJ+Vak/h/QgwGV2\n\t5ylaKAQL6JV7Th9DLJf6oJ0Yjijuvt11bZ9tJnefrXFOS0Ej00sRXf7+B97KwU959OvEzHPSlGj\n\tTnr/UMScxrzhQm7oLwPWbjI/2Om6+8sOaezs/NT8DuhX0k6M6UxkCn9JYcwpkSwg4AND9QCAKVH\n\tWjdYEX7I0rFnmnQpPzVZDxCyJ0/8fV3052PSFj5/T3MLSNuvfg9RDrc/2qfXS6MlVC5zqWTvCtg\n\tprVxXniiKdgJsiPtX1a+j6N0NuaSjttlngwa0iJs3af49uZMSxqhRZ2cZZBf0PJ/2sTBxGBVnhX\n\tCPWq/+C7VeHk9rtXN/SO+euDgL+ZfNy3HhWkoGxSuaa3TUQ8cBdPNdvi9FPsPkde4ckRz46GcSx\n\tTmT/ddML3zwT+uYqzSjPUl1GYBujADGUS7kuJ/l4lVbPWzZ1Zn9cz70svuOdGuLy3ldTi+hQe6P\n\tbVQC8O1orO15N/Q==", "X-Developer-Key": "i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Import the v4l2-isp.h header from the Linux kernel sources.\n\nThe file has not been merged in mainline Linux yet but is available\nat:\nhttps://lore.kernel.org/all/20250915-extensible-parameters-validation-v5-0-e6db94468af3@ideasonboard.com/\n\nCreate the include/linux/media/ directory so that header files\nexported from the kernel which include this file do not need\nto be adjusted when imported in libcamera.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nTested-By: Antoine Bouyer <antoine.bouyer@nxp.com>\n---\n include/linux/media/v4l2-isp.h | 100 +++++++++++++++++++++++++++++++++++++++++\n 1 file changed, 100 insertions(+)", "diff": "diff --git a/include/linux/media/v4l2-isp.h b/include/linux/media/v4l2-isp.h\nnew file mode 100644\nindex 0000000000000000000000000000000000000000..fed89b5678585a3565d33cf873d0313dc089524f\n--- /dev/null\n+++ b/include/linux/media/v4l2-isp.h\n@@ -0,0 +1,100 @@\n+/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */\n+/*\n+ * Video4Linux2 generic ISP parameters and statistics support\n+ *\n+ * Copyright (C) 2025 Ideas On Board Oy\n+ * Author: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n+ */\n+\n+#ifndef _V4L2_ISP_H_\n+#define _V4L2_ISP_H_\n+\n+#include <linux/stddef.h>\n+#include <linux/types.h>\n+\n+#define V4L2_PARAMS_FL_BLOCK_DISABLE\t(1U << 0)\n+#define V4L2_PARAMS_FL_BLOCK_ENABLE\t(1U << 1)\n+\n+/*\n+ * Reserve the first 8 bits for V4L2_PARAMS_FL_* flag.\n+ *\n+ * Driver-specific flags should be defined as:\n+ * #define PLATFORM_SPECIFIC_FLAG0 ((1U << V4L2_PARAMS_FL_DRIVER_FLAGS(0))\n+ * #define PLATFORM_SPECIFIC_FLAG1 ((1U << V4L2_PARAMS_FL_DRIVER_FLAGS(1))\n+ */\n+#define V4L2_PARAMS_FL_DRIVER_FLAGS(n) ((n) + 8)\n+\n+/**\n+ * struct v4l2_params_block_header - V4L2 extensible parameters block header\n+ *\n+ * This structure represents the common part of all the ISP configuration\n+ * blocks. Each parameters block shall embed an instance of this structure type\n+ * as its first member, followed by the block-specific configuration data. The\n+ * driver inspects this common header to discern the block type and its size and\n+ * properly handle the block content.\n+ *\n+ * The @type field is an ISP driver-specific value that identifies the block\n+ * type. The @size field specifies the size of the parameters block.\n+ *\n+ * The @flags field is a bitmask of per-block flags V4L2_PARAMS_FL_* and\n+ * driver-specific flags specified by the driver header.\n+ *\n+ * @type: The parameters block type (driver-specific)\n+ * @flags: A bitmask of block flags (driver-specific)\n+ * @size: Size (in bytes) of the parameters block, including this header\n+ */\n+struct v4l2_params_block_header {\n+\t__u16 type;\n+\t__u16 flags;\n+\t__u32 size;\n+} __attribute__((aligned(8)));\n+\n+/**\n+ * v4l2_params_buffer_size - Calculate size of v4l2_params_buffer for a platform\n+ *\n+ * Users of the v4l2 extensible parameters will have differing sized data arrays\n+ * depending on their specific parameter buffers. Drivers and userspace will\n+ * need to be able to calculate the appropriate size of the struct to\n+ * accommodate all ISP configuration blocks provided by the platform.\n+ * This macro provides a convenient tool for the calculation.\n+ *\n+ * @max_params_size: The total size of the ISP configuration blocks\n+ */\n+#define v4l2_params_buffer_size(max_params_size) \\\n+\t(offsetof(struct v4l2_params_buffer, data) + (max_params_size))\n+\n+/**\n+ * struct v4l2_params_buffer - V4L2 extensible parameters configuration\n+ *\n+ * This struct contains the configuration parameters of the ISP algorithms,\n+ * serialized by userspace into a data buffer. Each configuration parameter\n+ * block is represented by a block-specific structure which contains a\n+ * :c:type:`v4l2_params_block_header` entry as first member. Userspace populates\n+ * the @data buffer with configuration parameters for the blocks that it intends\n+ * to configure. As a consequence, the data buffer effective size changes\n+ * according to the number of ISP blocks that userspace intends to configure and\n+ * is set by userspace in the @data_size field.\n+ *\n+ * The parameters buffer is versioned by the @version field to allow modifying\n+ * and extending its definition. Userspace shall populate the @version field to\n+ * inform the driver about the version it intends to use. The driver will parse\n+ * and handle the @data buffer according to the data layout specific to the\n+ * indicated version and return an error if the desired version is not\n+ * supported.\n+ *\n+ * For each ISP block that userspace wants to configure, a block-specific\n+ * structure is appended to the @data buffer, one after the other without gaps\n+ * in between nor overlaps. Userspace shall populate the @data_size field with\n+ * the effective size, in bytes, of the @data buffer.\n+ *\n+ * @version: The parameters buffer version (driver-specific)\n+ * @data_size: The configuration data effective size, excluding this header\n+ * @data: The configuration data\n+ */\n+struct v4l2_params_buffer {\n+\t__u32 version;\n+\t__u32 data_size;\n+\t__u8 data[] __counted_by(data_size);\n+};\n+\n+#endif /* _V4L2_ISP_H_ */\n", "prefixes": [ "v2", "1/4" ] }