Patch Detail
Show a patch.
GET /api/1.1/patches/24364/?format=api
{ "id": 24364, "url": "https://patchwork.libcamera.org/api/1.1/patches/24364/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24364/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250912142915.53949-14-mzamazal@redhat.com>", "date": "2025-09-12T14:29:14", "name": "[v18,12/12] config: Check configuration file version", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "2b4bfefad483a62b72108f2a495c340280a16456", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/1.1/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24364/mbox/", "series": [ { "id": 5441, "url": "https://patchwork.libcamera.org/api/1.1/series/5441/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5441", "date": "2025-09-12T14:29:01", "name": "Add global configuration file", "version": 18, "mbox": "https://patchwork.libcamera.org/series/5441/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24364/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24364/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E82D4C328C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 12 Sep 2025 14:30:08 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2E44F6938E;\n\tFri, 12 Sep 2025 16:30:08 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6856E6938C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 12 Sep 2025 16:30:06 +0200 (CEST)", "from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-586-O0eIKjQFOICapePLzN8wXw-1;\n\tFri, 12 Sep 2025 10:30:02 -0400", "from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.93])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id E29E618002CA; Fri, 12 Sep 2025 14:30:00 +0000 (UTC)", "from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.45.224.48])\n\tby mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 5E4AA180035C; Fri, 12 Sep 2025 14:29:58 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"EToYWX6b\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1757687405;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=rbANNm4plwPG5bDSMtnDfRVxXNWOc5NL6R3TNDaSP44=;\n\tb=EToYWX6bGkTHJAQrexquj8Jg80lSWCljFy71+PBat3YG/8isnPU0Oyt4cDMjiFTwZQBDmY\n\tcwfNlNigsX2CuFOrO55HGq2LTFOrhbz5FjGHEAcKCqSMRvdCpQYnv8izS/cbx6pOqTEDCf\n\tHPTQmYqxTM4/MWPrLRmZJPd8RTBoVTU=", "X-MC-Unique": "O0eIKjQFOICapePLzN8wXw-1", "X-Mimecast-MFC-AGG-ID": "O0eIKjQFOICapePLzN8wXw_1757687401", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>, Kieran Bingham\n\t<kieran.bingham@ideasonboard.com>, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t<barnabas.pocze@ideasonboard.com>, Laurent Pinchart\n\t<laurent.pinchart@ideasonboard.com>, Paul Elder\n\t<paul.elder@ideasonboard.com>", "Subject": "[PATCH v18 12/12] config: Check configuration file version", "Date": "Fri, 12 Sep 2025 16:29:14 +0200", "Message-ID": "<20250912142915.53949-14-mzamazal@redhat.com>", "In-Reply-To": "<20250912142915.53949-1-mzamazal@redhat.com>", "References": "<20250912142915.53949-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.93", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "DYKTYOVem_NoRT9lOyj62_Dsz0bA-F4ALrurVbR7KzI_1757687401", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "We don't know what the future versions of the configuration file will\nlook like. The current code can process only version 1; let's check\nthat the read configuration is of this version.\n\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/libcamera/global_configuration.cpp | 9 +++++++++\n 1 file changed, 9 insertions(+)", "diff": "diff --git a/src/libcamera/global_configuration.cpp b/src/libcamera/global_configuration.cpp\nindex 8c2670e03..2eec45363 100644\n--- a/src/libcamera/global_configuration.cpp\n+++ b/src/libcamera/global_configuration.cpp\n@@ -67,6 +67,15 @@ bool GlobalConfiguration::loadFile(const std::filesystem::path &fileName)\n \t\treturn true;\n \t}\n \n+\tconst std::optional<int> version = (*configuration)[\"version\"].get<int>();\n+\tif (version != 1) {\n+\t\tLOG(Configuration, Error)\n+\t\t\t<< \"Failed to read configuration file due to unsupported version \"\n+\t\t\t<< (version ? std::to_string(version.value()) : \"\\\"unspecified\\\"\")\n+\t\t\t<< \", expected version 1\";\n+\t\treturn true;\n+\t}\n+\n \tyamlConfiguration_ = std::move(configuration);\n \treturn true;\n }\n", "prefixes": [ "v18", "12/12" ] }