Patch Detail
Show a patch.
GET /api/1.1/patches/24348/?format=api
{ "id": 24348, "url": "https://patchwork.libcamera.org/api/1.1/patches/24348/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24348/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250912-hm1246-v1-1-58c814f52a26@emfend.at>", "date": "2025-09-12T09:13:25", "name": "libcamera: libipa: camera_sensor: Add Himax HM1246 sensor properties", "commit_ref": "e8304bc6c138d03d562bf5e597e02f2f08f5709e", "pull_url": null, "state": "accepted", "archived": false, "hash": "9133f2eb9806f47a01100c51459e0df5cc68c16e", "submitter": { "id": 134, "url": "https://patchwork.libcamera.org/api/1.1/people/134/?format=api", "name": "Matthias Fend", "email": "matthias.fend@emfend.at" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24348/mbox/", "series": [ { "id": 5439, "url": "https://patchwork.libcamera.org/api/1.1/series/5439/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5439", "date": "2025-09-12T09:13:25", "name": "libcamera: libipa: camera_sensor: Add Himax HM1246 sensor properties", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5439/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24348/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24348/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 67771C324E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 12 Sep 2025 09:13:32 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1886869367;\n\tFri, 12 Sep 2025 11:13:32 +0200 (CEST)", "from lx20.hoststar.hosting (lx20.hoststar.hosting [168.119.41.54])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 372F3613A3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 12 Sep 2025 11:13:30 +0200 (CEST)", "from 194-208-208-245.tele.net ([194.208.208.245]:49839\n\thelo=[127.0.1.1]) by lx20.hoststar.hosting with esmtpsa (TLS1.3) tls\n\tTLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93)\n\t(envelope-from <matthias.fend@emfend.at>)\n\tid 1uwzqT-009jJH-6d; Fri, 12 Sep 2025 11:13:29 +0200" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=emfend.at header.i=@emfend.at\n\theader.b=\"UJrnqmyE\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=emfend.at;\n\ts=mail;\n\th=Cc:To:Message-Id:Content-Transfer-Encoding:Content-Type:\n\tMIME-Version:Subject:Date:From:Sender:Reply-To:Content-ID:Content-Description\n\t:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tIn-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=yLTAwkxtpLTzJo5b8kubNBsgAoAh5RqD7FmDObt7nug=;\n\tb=UJrnqmyEq3UB55wVIsUArUewnt\n\tD56mGaR6PtOsDcFjEr+OTZRChKPys40R3ObTbeE9NgMR5c0qfoGrTMwVa7vhymdyWh9tdzUj3f68w\n\tOnjvJKezQzxR85VJhu6CjyA3VvYyI9CKzHIXETo/IIKRowkg3lqyeeMU13xyLPcZuayc=;", "From": "Matthias Fend <matthias.fend@emfend.at>", "Date": "Fri, 12 Sep 2025 11:13:25 +0200", "Subject": "[PATCH] libcamera: libipa: camera_sensor: Add Himax HM1246 sensor\n\tproperties", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20250912-hm1246-v1-1-58c814f52a26@emfend.at>", "X-B4-Tracking": "v=1; b=H4sIADTkw2gC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE\n\tvPSU3UzU4B8JSMDI1MDS0Mj3YxcQyMTM11TU1ODJJMU0xRDs1QloOKCotS0zAqwQdGxtbUAZlL\n\tNz1gAAAA=", "X-Change-ID": "20250912-hm1246-5550b4d5d16e", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Matthias Fend <matthias.fend@emfend.at>", "X-Mailer": "b4 0.14.2", "X-Spam-Score": "", "X-Spam-Bar": "", "X-Spam-Report": "", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Provide the Himax HM1246 camera sensor properties and registration with\nlibipa for the gain code helpers.\n\nSigned-off-by: Matthias Fend <matthias.fend@emfend.at>\n---\nThe Himax HM1246-AWD is a 1/3.7-Inch CMOS image sensor SoC with an active\narray size of 1296 x 976 and parallell interface. The sensor has an\nintegrated ISP that is not supported by the kernel driver. The sensor is\ntherefore operated like a normal sensor in raw mode.\n\nThe kernel driver required for this is currently under review [1].\n[1] https://lore.kernel.org/r/20250912-hm1246-v3-0-3b89f47dfa43@emfend.at\n---\n src/ipa/libipa/camera_sensor_helper.cpp | 10 +++++++\n src/libcamera/sensor/camera_sensor_properties.cpp | 32 +++++++++++++++++++++++\n 2 files changed, 42 insertions(+)\n\n\n---\nbase-commit: b8d332cdcc130c27232f61369e7bab2d954e7ac6\nchange-id: 20250912-hm1246-5550b4d5d16e\n\nBest regards,", "diff": "diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\nindex dcd69d9f2bbb39feabfefe41cee8b45f0f958127..df93c0fdeb9c5ae2c3e3dc51dabc62ba4082c0d7 100644\n--- a/src/ipa/libipa/camera_sensor_helper.cpp\n+++ b/src/ipa/libipa/camera_sensor_helper.cpp\n@@ -497,6 +497,16 @@ public:\n };\n REGISTER_CAMERA_SENSOR_HELPER(\"gc08a3\", CameraSensorHelperGc08a3)\n \n+class CameraSensorHelperHm1246 : public CameraSensorHelper\n+{\n+public:\n+\tCameraSensorHelperHm1246()\n+\t{\n+\t\tgain_ = AnalogueGainLinear{ 1, 16, 0, 16 };\n+\t}\n+};\n+REGISTER_CAMERA_SENSOR_HELPER(\"hm1246\", CameraSensorHelperHm1246)\n+\n class CameraSensorHelperImx214 : public CameraSensorHelper\n {\n public:\ndiff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\nindex f2da8205372baabca58416e2c0f9da64e722fe02..810f0199d41f0582e120687b304c3ff549a19bc8 100644\n--- a/src/libcamera/sensor/camera_sensor_properties.cpp\n+++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n@@ -151,6 +151,38 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n \t\t\t},\n \t\t\t.sensorDelays = { },\n \t\t} },\n+\t\t{ \"hm1246\", {\n+\t\t\t.unitCellSize = { 3000, 3000 },\n+\t\t\t.testPatternModes = {\n+\t\t\t\t{ controls::draft::TestPatternModeOff, 0 },\n+\t\t\t\t/* Solid white. */\n+\t\t\t\t{ controls::draft::TestPatternModeSolidColor, 6 },\n+\t\t\t\t/* The six vertical bars (left-to-right) are as follows: black,\n+\t\t\t\t * blue, red, magenta, green and cyan.\n+\t\t\t\t */\n+\t\t\t\t{ controls::draft::TestPatternModeCustom1, 5 },\n+\t\t\t\t/*\n+\t\t\t\t * No corresponding test pattern mode for:\n+\t\t\t\t * 1: \"Checkboard\"\n+\t\t\t\t * 2: \"Ramp\"\n+\t\t\t\t * 3: \"Moving ones\"\n+\t\t\t\t * 4: \"Blending color bars\"\n+\t\t\t\t * 7: \"Solid black\"\n+\t\t\t\t * 8: \"Solid red\"\n+\t\t\t\t * 9: \"Solid green\"\n+\t\t\t\t * 10: \"Solid blue\"\n+\t\t\t\t *\n+\t\t\t\t * Even though the sensor supports color bars and faded color bars as test patterns, these are\n+\t\t\t\t * not offered because these patterns do not meet the expected properties.\n+\t\t\t\t */\n+\t\t\t},\n+\t\t\t.sensorDelays = {\n+\t\t\t\t.exposureDelay = 2,\n+\t\t\t\t.gainDelay = 2,\n+\t\t\t\t.vblankDelay = 2,\n+\t\t\t\t.hblankDelay = 2\n+\t\t\t},\n+\t\t} },\n \t\t{ \"imx214\", {\n \t\t\t.unitCellSize = { 1120, 1120 },\n \t\t\t.testPatternModes = {\n", "prefixes": [] }