Patch Detail
Show a patch.
GET /api/1.1/patches/24347/?format=api
{ "id": 24347, "url": "https://patchwork.libcamera.org/api/1.1/patches/24347/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24347/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<175766491057.2722520.11015700389987728544@neptunite.rasen.tech>", "date": "2025-09-12T08:15:10", "name": "[v2,1/2] ipa: rkisp1: Add settings for DreamChip RPPX1 ISP", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "42c3d6e72c9a77156cb3c1791ca98581612e6333", "submitter": { "id": 230, "url": "https://patchwork.libcamera.org/api/1.1/people/230/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund+renesas@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24347/mbox/", "series": [ { "id": 5438, "url": "https://patchwork.libcamera.org/api/1.1/series/5438/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5438", "date": "2025-09-12T08:15:10", "name": "[v2,1/2] ipa: rkisp1: Add settings for DreamChip RPPX1 ISP", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5438/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24347/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24347/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5B705BDB13\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 12 Sep 2025 08:15:22 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 51CDA69367;\n\tFri, 12 Sep 2025 10:15:21 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5EE6E613A3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 12 Sep 2025 10:15:19 +0200 (CEST)", "from neptunite.rasen.tech (unknown\n\t[IPv6:2404:7a81:160:2100:5c83:71e0:e0c7:1670])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id A12F7166D; \n\tFri, 12 Sep 2025 10:14:03 +0200 (CEST)" ], "Content-Type": "text/plain; charset=\"utf-8\"", "MIME-Version": "1.0", "Content-Transfer-Encoding": "quoted-printable", "In-Reply-To": "<20250911090547.1860863-1-niklas.soderlund+renesas@ragnatech.se>", "References": "<20250911090547.1860863-1-niklas.soderlund+renesas@ragnatech.se>", "Subject": "[PATCH v2 1/2] ipa: rkisp1: Add settings for DreamChip RPPX1 ISP", "From": "Niklas =?utf-8?q?S=C3=B6derlund?=\n\t<niklas.soderlund+renesas@ragnatech.se>", "To": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org", "Cc": "Niklas =?utf-8?q?S=C3=B6derlund?= <niklas.soderlund+renesas@ragnatech.se>", "Date": "Fri, 12 Sep 2025 17:15:10 +0900", "Message-ID": "<175766491057.2722520.11015700389987728544@neptunite.rasen.tech>", "User-Agent": "alot/0.0.0", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The DreamChip RPPX1 ISP appears to be a superset of the Rockchip RkISP1\nISP V10. The RkISP1 interface and hardware operates at 8-bits color\ndepth, while the RPPX1 operates at 24-bits. For this reason the RkISP1\nparameter and buffer formats are deigned around 8-bits.\n\nThe kernel driver for RPPX1 can however compensate for this and scale\ndown it's internal data structures to 8-bits and produce parameter\nbuffers (RK1E) and output statistics (RK1S) that is compatible with the\nRkISP1 IPA.\n\nThe one difference is that the RPPX1 have 32 histogram buckets compared\nto RkISP1 V10 16. Add a dedicated hardware revisions descriptor for the\nRPPX1 device so it can reuse the existing IPA.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>\n\nLooks good to me.\n\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\n include/libcamera/ipa/rkisp1.mojom | 8 ++++++++\n src/ipa/rkisp1/rkisp1.cpp | 11 +++++++++++\n 2 files changed, 19 insertions(+)", "diff": "diff --git a/include/libcamera/ipa/rkisp1.mojom b/include/libcamera/ipa/rkisp1.mojom\nindex 043ad27ea199..608ba82a0091 100644\n--- a/include/libcamera/ipa/rkisp1.mojom\n+++ b/include/libcamera/ipa/rkisp1.mojom\n@@ -8,6 +8,14 @@ module ipa.rkisp1;\n \n import \"include/libcamera/ipa/core.mojom\";\n \n+/*\n+ * Hardware revisions in rkisp1-config.h (enum rkisp1_cif_isp_version) start at\n+ * 10 and increment sequentially. Add a namespace starting at 0x80000000 for\n+ * devices not cover by the kernel rkisp1 implementation but still supported\n+ * by the IPA.\n+ */\n+const uint32 HwRevisionExternalRppX1 = 0x80000001;\n+\n struct IPAConfigInfo {\n libcamera.IPACameraSensorInfo sensorInfo;\n libcamera.ControlInfoMap sensorControls;\ndiff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex cf66d5553dcd..14600251dfe5 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -113,6 +113,14 @@ const IPAHwSettings ipaHwSettingsV12{\n false,\n };\n \n+const IPAHwSettings ipaHwSettingsRPPX1{\n+ RKISP1_CIF_ISP_AE_MEAN_MAX_V10,\n+ RKISP1_CIF_ISP_HIST_BIN_N_MAX_V12,\n+ RKISP1_CIF_ISP_HISTOGRAM_WEIGHT_GRIDS_SIZE_V10,\n+ RKISP1_CIF_ISP_GAMMA_OUT_MAX_SAMPLES_V10,\n+ false,\n+};\n+\n /* List of controls handled by the RkISP1 IPA */\n const ControlInfoMap::Map rkisp1Controls{\n { &controls::DebugMetadataEnable, ControlInfo(false, true, false) },\n@@ -147,6 +155,9 @@ int IPARkISP1::init(const IPASettings &settings, unsigned int hwRevision,\n case RKISP1_V12:\n context_.hw = &ipaHwSettingsV12;\n break;\n+ case HwRevisionExternalRppX1:\n+ context_.hw = &ipaHwSettingsRPPX1;\n+ break;\n default:\n LOG(IPARkISP1, Error)\n << \"Hardware revision \" << hwRevision\n", "prefixes": [ "v2", "1/2" ] }