Patch Detail
Show a patch.
GET /api/1.1/patches/2427/?format=api
{ "id": 2427, "url": "https://patchwork.libcamera.org/api/1.1/patches/2427/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2427/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20191216121029.1048242-4-niklas.soderlund@ragnatech.se>", "date": "2019-12-16T12:10:29", "name": "[libcamera-devel,3/3] test: file_descriptor: Add test", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "45d9387b931ed7b86bd0a23e9a5515edd653ce80", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/1.1/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2427/mbox/", "series": [ { "id": 588, "url": "https://patchwork.libcamera.org/api/1.1/series/588/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=588", "date": "2019-12-16T12:10:26", "name": "libcamera: Add FileDescriptor to help pass numerical fds around", "version": 1, "mbox": "https://patchwork.libcamera.org/series/588/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2427/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2427/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5C1F8601E4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 16 Dec 2019 13:11:11 +0100 (CET)", "from bismarck.berto.se (p54ac5865.dip0.t-ipconnect.de\n\t[84.172.88.101]) by bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid 1eea447d-1ffd-11ea-8e92-005056917f90;\n\tMon, 16 Dec 2019 13:11:05 +0100 (CET)" ], "X-Halon-ID": "1eea447d-1ffd-11ea-8e92-005056917f90", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 16 Dec 2019 13:10:29 +0100", "Message-Id": "<20191216121029.1048242-4-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.24.0", "In-Reply-To": "<20191216121029.1048242-1-niklas.soderlund@ragnatech.se>", "References": "<20191216121029.1048242-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 3/3] test: file_descriptor: Add test", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 16 Dec 2019 12:11:11 -0000" }, "content": "Add a test which exercises the whole FileDescriptor interface.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n test/file_descriptor.cpp | 152 +++++++++++++++++++++++++++++++++++++++\n test/meson.build | 1 +\n 2 files changed, 153 insertions(+)\n create mode 100644 test/file_descriptor.cpp", "diff": "diff --git a/test/file_descriptor.cpp b/test/file_descriptor.cpp\nnew file mode 100644\nindex 0000000000000000..b1d0d0e0b2807b20\n--- /dev/null\n+++ b/test/file_descriptor.cpp\n@@ -0,0 +1,152 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * Copyright (C) 2019, Google Inc.\n+ *\n+ * file_descriptor.cpp - FileDescriptor test\n+ */\n+\n+#include <fcntl.h>\n+#include <sys/stat.h>\n+#include <sys/types.h>\n+#include <unistd.h>\n+\n+#include <libcamera/file_descriptor.h>\n+\n+#include \"test.h\"\n+\n+using namespace std;\n+using namespace libcamera;\n+\n+class FileDescriptorTest : public Test\n+{\n+protected:\n+\tint init()\n+\t{\n+\t\tfd_ = open(\"/tmp\", O_TMPFILE | O_RDWR, S_IRUSR | S_IWUSR);\n+\t\tif (fd_ < 0)\n+\t\t\treturn TestFail;\n+\n+\t\treturn 0;\n+\t}\n+\n+\tint run()\n+\t{\n+\t\tFileDescriptor *desc1, *desc2;\n+\n+\t\t/* Test creating FileDescriptor from numerical file descriptor. */\n+\t\tdesc1 = new FileDescriptor(fd_);\n+\t\tif (desc1->fd() == fd_)\n+\t\t\treturn TestFail;\n+\n+\t\tif (!validFD(fd_) || !validFD(desc1->fd()))\n+\t\t\treturn TestFail;\n+\n+\t\tdelete desc1;\n+\n+\t\tif (!validFD(fd_))\n+\t\t\treturn TestFail;\n+\n+\t\t/* Test creating FileDescriptor from other FileDescriptor. */\n+\t\tdesc1 = new FileDescriptor(fd_);\n+\t\tdesc2 = new FileDescriptor(*desc1);\n+\n+\t\tif (desc1->fd() == fd_ || desc2->fd() == fd_ || desc1->fd() == desc2->fd())\n+\t\t\treturn TestFail;\n+\n+\t\tif (!validFD(fd_) || !validFD(desc1->fd()) || !validFD(desc2->fd()))\n+\t\t\treturn TestFail;\n+\n+\t\tdelete desc1;\n+\n+\t\tif (!validFD(fd_) || !validFD(desc2->fd()))\n+\t\t\treturn TestFail;\n+\n+\t\tdelete desc2;\n+\n+\t\tif (!validFD(fd_))\n+\t\t\treturn TestFail;\n+\n+\t\t/* Test creating FileDescriptor by taking over other FileDescriptor. */\n+\t\tdesc1 = new FileDescriptor(fd_);\n+\t\tdesc2 = new FileDescriptor(std::move(*desc1));\n+\n+\t\tif (desc1->fd() != -1 || desc2->fd() == fd_ || desc1->fd() == desc2->fd())\n+\t\t\treturn TestFail;\n+\n+\t\tif (!validFD(fd_) || !validFD(desc2->fd()))\n+\t\t\treturn TestFail;\n+\n+\t\tdelete desc1;\n+\t\tdelete desc2;\n+\n+\t\tif (!validFD(fd_))\n+\t\t\treturn TestFail;\n+\n+\t\t/* Test creating FileDescriptor by copy assigment */\n+\t\tdesc1 = new FileDescriptor();\n+\t\tdesc2 = new FileDescriptor(fd_);\n+\n+\t\tif (desc1->fd() != -1 || desc2->fd() == fd_ || desc1->fd() == desc2->fd())\n+\t\t\treturn TestFail;\n+\n+\t\tif (!validFD(fd_) || !validFD(desc2->fd()))\n+\t\t\treturn TestFail;\n+\n+\t\t*desc1 = *desc2;\n+\n+\t\tif (desc1->fd() == fd_ || desc2->fd() == fd_ || desc1->fd() == desc2->fd())\n+\t\t\treturn TestFail;\n+\n+\t\tif (!validFD(fd_) || !validFD(desc1->fd()) || !validFD(desc2->fd()))\n+\t\t\treturn TestFail;\n+\n+\t\tdelete desc1;\n+\t\tdelete desc2;\n+\n+\t\tif (!validFD(fd_))\n+\t\t\treturn TestFail;\n+\n+\t\t/* Test creating FileDescriptor by move assigment */\n+\t\tdesc1 = new FileDescriptor();\n+\t\tdesc2 = new FileDescriptor(fd_);\n+\n+\t\tif (desc1->fd() != -1 || desc2->fd() == fd_ || desc1->fd() == desc2->fd())\n+\t\t\treturn TestFail;\n+\n+\t\tif (!validFD(fd_) || !validFD(desc2->fd()))\n+\t\t\treturn TestFail;\n+\n+\t\t*desc1 = std::move(*desc2);\n+\n+\t\tif (desc1->fd() == fd_ || desc2->fd() != -1 || desc1->fd() == desc2->fd())\n+\t\t\treturn TestFail;\n+\n+\t\tif (!validFD(fd_) || !validFD(desc1->fd()))\n+\t\t\treturn TestFail;\n+\n+\t\tdelete desc1;\n+\t\tdelete desc2;\n+\n+\t\tif (!validFD(fd_))\n+\t\t\treturn TestFail;\n+\n+\t\treturn TestPass;\n+\t}\n+\n+\tvoid cleanup()\n+\t{\n+\t\tif (fd_ > 0)\n+\t\t\tclose(fd_);\n+\t}\n+\n+private:\n+\tbool validFD(int fd)\n+\t{\n+\t\tstruct stat s;\n+\t\treturn fstat(fd, &s) == 0;\n+\t}\n+\n+\tint fd_;\n+};\n+\n+TEST_REGISTER(FileDescriptorTest)\ndiff --git a/test/meson.build b/test/meson.build\nindex 1bb2161dc05a7b1d..9dc392df30efd956 100644\n--- a/test/meson.build\n+++ b/test/meson.build\n@@ -25,6 +25,7 @@ internal_tests = [\n ['event', 'event.cpp'],\n ['event-dispatcher', 'event-dispatcher.cpp'],\n ['event-thread', 'event-thread.cpp'],\n+ ['file_descriptor', 'file_descriptor.cpp'],\n ['message', 'message.cpp'],\n ['object', 'object.cpp'],\n ['object-invoke', 'object-invoke.cpp'],\n", "prefixes": [ "libcamera-devel", "3/3" ] }