Patch Detail
Show a patch.
GET /api/1.1/patches/24238/?format=api
{ "id": 24238, "url": "https://patchwork.libcamera.org/api/1.1/patches/24238/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24238/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250827090739.86955-2-david.plowman@raspberrypi.com>", "date": "2025-08-27T09:07:28", "name": "[RFC,01/12] libcamera: Infrastructure to ask for \"memory\" cameras", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "9889b22d710ae19cbefc80118734f5c19fa7f6cd", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/1.1/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24238/mbox/", "series": [ { "id": 5407, "url": "https://patchwork.libcamera.org/api/1.1/series/5407/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5407", "date": "2025-08-27T09:07:27", "name": "Bayer Re-Processing", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5407/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24238/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24238/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A3584BD87C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 27 Aug 2025 09:07:53 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3F6B9692EE;\n\tWed, 27 Aug 2025 11:07:48 +0200 (CEST)", "from mail-wr1-x434.google.com (mail-wr1-x434.google.com\n\t[IPv6:2a00:1450:4864:20::434])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C85CA613C0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 27 Aug 2025 11:07:44 +0200 (CEST)", "by mail-wr1-x434.google.com with SMTP id\n\tffacd0b85a97d-3c73d3ebff0so293571f8f.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 27 Aug 2025 02:07:44 -0700 (PDT)", "from raspberrypi.pitowers.org\n\t([2a00:1098:3142:1f:ffc9:aff6:7f7f:893b])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-45b6f30fe02sm21498675e9.18.2025.08.27.02.07.43\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 27 Aug 2025 02:07:43 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"JncETe+o\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1756285664; x=1756890464;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=KWoEiVaKZRbolQ7JZ2mn3Ccm5Fq8zD+7dRFyWs6vnD4=;\n\tb=JncETe+ouofaKkULrRNzvqJQ7/q//a3pEj2LTYAIrFhE6QNR/+20abOzvoFVExAoGn\n\tqwuguPC1ar0TXyI9gDtkUtLuFomQQmPFvgDvQMt4AZShi3WI5zNQw+6j22st1rhU2yI7\n\tbKjiND0FMhdESmovNLQTcRsMtj5IxHjIBiqnjlpigO3FTvjAN7hEKNTipTSzc2mBQXhg\n\tfv0bYGc3ul7C3u7bTBNRAwsnKWxH2M27/voH199HGCjkI11w8b9EiZbwW6FO8ERnCweB\n\ttIxOcbWq81DKDm5MRjw3uj4h7+ro8glzhkedi32I3b6ZgEU6TiI7tIZt+3tbaVC5MBwJ\n\tixzQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1756285664; x=1756890464;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=KWoEiVaKZRbolQ7JZ2mn3Ccm5Fq8zD+7dRFyWs6vnD4=;\n\tb=anUoNaU2jI4iI/U114Ha9o0KFEDm55266GmxTCxnVrICbuffmzPS0HTlpAoZO/lFZq\n\t6ufyi3lBYIf51x4MoN5/wi8mTv43m41tCYTY8cV6rN8PKWeSb8SCKGmqykGmP2knHVb9\n\tgy2a34ENNvdBcMo5NPSWYvETj/Sv9t6IoaaF3zhWGw4EsnAswjOSihFx4HQxdDZ697Q9\n\tphQxqCwi5D5RvqdQAvC3w5jlfgWOv0JZZCIGLun4f4NBeH5B0CxV2LOD+viwgh7vDhEf\n\tjx4mVR82EdQe87Sp3MrctEwmq+/eVTz1q5e1jNQsC++B7O4oC1ZauTQ4cQ6reFCBBFwo\n\tZyLg==", "X-Gm-Message-State": "AOJu0Yyyl9Kv5oXlutEwtcy5Ucg+jrHRnVZSK057BOeDzSAXWUIdy0a5\n\tZ3vflALWEyy4Jp8F6nHE/xk8Qeen35onbxqvxcilquM0JLfSEAlM6ZY5puZUrIj6NP4NhmYYDN0\n\tamwSt", "X-Gm-Gg": "ASbGnct4rTqhadkyhq288ZCJgJlB16w2LbWOwPSMYvpj+I/ZygOa29Xwm8it4sINKR+\n\tLdupxj3Qfez89Jj0+Rct+i0quW5PY7IlxxJ0RKdus31JrbdMAGSjAun39mU7JaHt8leUge06HbV\n\tec185D4qG++GNKce+oxkYW5u0MRnAOO87GBfST46A/oEnGIxEYn7oJk63C+3CWwxbuebpU9VXJg\n\tuj/ZoYcsKI69gIyRykask4m8RHod2/LITWVq1yktiI+1UFSS4WkMBhX3kFvNPLe6lqBSUcKRpsM\n\tg4UunnoDhFVkKmWkL+8E09Hf5zKhnjoCSnoAEQrMBEUIB2qTWAnAFmvqTVMASERsFpaULFXb4tm\n\tjRmI5uEIoiCg2Mi9Q/ypWgRsCylKd2P/koYmY69QbUiZCP1/UkY1bUVVMrkuJke5bTiq30HABI6\n\tEwr7qySKOl07MmlJanomq1TDDRcJCbmJHSCLGFzIU=", "X-Google-Smtp-Source": "AGHT+IFifNTZFgU4+DBCq+DKwm76bd4pDL7riH7TdCNJsx1AB+bE11Wwa0/eRmX1k/hRHoLeOj3CWQ==", "X-Received": "by 2002:a5d:5d10:0:b0:3c5:8300:978d with SMTP id\n\tffacd0b85a97d-3cbb15ca07fmr3725265f8f.22.1756285663781; \n\tWed, 27 Aug 2025 02:07:43 -0700 (PDT)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "David Plowman <david.plowman@raspberrypi.com>", "Subject": "[RFC PATCH 01/12] libcamera: Infrastructure to ask for \"memory\"\n\tcameras", "Date": "Wed, 27 Aug 2025 10:07:28 +0100", "Message-Id": "<20250827090739.86955-2-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.39.5", "In-Reply-To": "<20250827090739.86955-1-david.plowman@raspberrypi.com>", "References": "<20250827090739.86955-1-david.plowman@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Signed-off-by: David Plowman <david.plowman@raspberrypi.com>\n---\n include/libcamera/camera_manager.h | 4 ++\n include/libcamera/internal/camera_manager.h | 5 +++\n include/libcamera/internal/pipeline_handler.h | 8 ++++\n src/libcamera/camera_manager.cpp | 40 +++++++++++++++++++\n 4 files changed, 57 insertions(+)", "diff": "diff --git a/include/libcamera/camera_manager.h b/include/libcamera/camera_manager.h\nindex 27835500..436db409 100644\n--- a/include/libcamera/camera_manager.h\n+++ b/include/libcamera/camera_manager.h\n@@ -7,6 +7,7 @@\n \n #pragma once\n \n+#include <map>\n #include <memory>\n #include <string>\n #include <string_view>\n@@ -20,6 +21,7 @@\n namespace libcamera {\n \n class Camera;\n+class PipelineHandler;\n \n class CameraManager : public Object, public Extensible\n {\n@@ -33,6 +35,8 @@ public:\n \n \tstd::vector<std::shared_ptr<Camera>> cameras() const;\n \tstd::shared_ptr<Camera> get(std::string_view id);\n+\tstd::vector<std::string> memoryCameras() const;\n+\tstd::shared_ptr<Camera> getMemoryCamera(std::string_view id, std::string_view settings);\n \n \tstatic const std::string &version() { return version_; }\n \ndiff --git a/include/libcamera/internal/camera_manager.h b/include/libcamera/internal/camera_manager.h\nindex 0150ca61..a490cb25 100644\n--- a/include/libcamera/internal/camera_manager.h\n+++ b/include/libcamera/internal/camera_manager.h\n@@ -49,6 +49,9 @@ private:\n \tvoid pipelineFactoryMatch(const PipelineHandlerFactoryBase *factory);\n \tvoid cleanup() LIBCAMERA_TSA_EXCLUDES(mutex_);\n \n+\tstd::shared_ptr<Camera> getMemoryCamera(const PipelineHandlerFactoryBase *factory,\n+\t\t\t\t\t\tstd::string_view settings);\n+\n \t/*\n \t * This mutex protects\n \t *\n@@ -64,6 +67,8 @@ private:\n \n \tstd::unique_ptr<DeviceEnumerator> enumerator_;\n \n+\tstd::vector<std::string> memoryCameras_;\n+\n \tstd::unique_ptr<IPAManager> ipaManager_;\n \tProcessManager processManager_;\n };\ndiff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\nindex e89d6a33..0210d48b 100644\n--- a/include/libcamera/internal/pipeline_handler.h\n+++ b/include/libcamera/internal/pipeline_handler.h\n@@ -70,6 +70,14 @@ public:\n \n \tCameraManager *cameraManager() const { return manager_; }\n \n+\tvirtual bool supportsMemoryCamera() { return false; }\n+\n+\tvirtual std::shared_ptr<Camera> createMemoryCamera([[maybe_unused]] DeviceEnumerator *enumerator,\n+\t\t\t\t\t\t\t [[maybe_unused]] std::string_view settings)\n+\t{\n+\t\treturn nullptr;\n+\t}\n+\n protected:\n \tvoid registerCamera(std::shared_ptr<Camera> camera);\n \tvoid hotplugMediaDevice(MediaDevice *media);\ndiff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\nindex f81794bf..580c31bf 100644\n--- a/src/libcamera/camera_manager.cpp\n+++ b/src/libcamera/camera_manager.cpp\n@@ -152,6 +152,13 @@ void CameraManager::Private::pipelineFactoryMatch(const PipelineHandlerFactoryBa\n {\n \tCameraManager *const o = LIBCAMERA_O_PTR();\n \n+\t/* First check for any memory-to-memory camera pipelines. */\n+\t{\n+\t\tstd::shared_ptr<PipelineHandler> pipe = factory->create(o);\n+\t\tif (pipe->supportsMemoryCamera())\n+\t\t\tmemoryCameras_.push_back(std::string(pipe->name()));\n+\t}\n+\n \t/* Provide as many matching pipelines as possible. */\n \twhile (1) {\n \t\tstd::shared_ptr<PipelineHandler> pipe = factory->create(o);\n@@ -164,6 +171,19 @@ void CameraManager::Private::pipelineFactoryMatch(const PipelineHandlerFactoryBa\n \t}\n }\n \n+std::shared_ptr<Camera> CameraManager::Private::getMemoryCamera(const PipelineHandlerFactoryBase *factory,\n+\t\t\t\t\t\t\t\tstd::string_view settings)\n+{\n+\tCameraManager *const o = LIBCAMERA_O_PTR();\n+\n+\tstd::shared_ptr<PipelineHandler> pipe = factory->create(o);\n+\n+\tpipe->moveToThread(this);\n+\n+\treturn pipe->invokeMethod(&PipelineHandler::createMemoryCamera,\n+\t\t\t\t ConnectionTypeBlocking, enumerator_.get(), settings);\n+}\n+\n void CameraManager::Private::cleanup()\n {\n \tenumerator_->devicesAdded.disconnect(this);\n@@ -399,6 +419,26 @@ std::shared_ptr<Camera> CameraManager::get(std::string_view id)\n \treturn nullptr;\n }\n \n+std::vector<std::string> CameraManager::memoryCameras() const\n+{\n+\treturn _d()->memoryCameras_;\n+}\n+\n+std::shared_ptr<Camera> CameraManager::getMemoryCamera(std::string_view id,\n+\t\t\t\t\t\t std::string_view settings)\n+{\n+\tfor (const auto &name : _d()->memoryCameras_) {\n+\t\tif (name == id) {\n+\t\t\tconst PipelineHandlerFactoryBase *factory;\n+\t\t\tfactory = PipelineHandlerFactoryBase::getFactoryByName(name);\n+\n+\t\t\treturn _d()->getMemoryCamera(factory, settings);\n+\t\t}\n+\t}\n+\n+\treturn nullptr;\n+}\n+\n /**\n * \\var CameraManager::cameraAdded\n * \\brief Notify of a new camera added to the system\n", "prefixes": [ "RFC", "01/12" ] }