Patch Detail
Show a patch.
GET /api/1.1/patches/24220/?format=api
{ "id": 24220, "url": "https://patchwork.libcamera.org/api/1.1/patches/24220/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24220/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250824-b4-v0-5-2-gpuisp-v2-a-v2-35-96f4576c814e@linaro.org>", "date": "2025-08-24T00:48:47", "name": "[v2,35/37] libcamera: shaders: Rename bayer_8 to bayer_unpacked", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "92563517212ccf09b73afa366b2a799656c6a24c", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/1.1/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24220/mbox/", "series": [ { "id": 5400, "url": "https://patchwork.libcamera.org/api/1.1/series/5400/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5400", "date": "2025-08-24T00:48:12", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5400/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24220/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24220/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CAD16C32BB\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 24 Aug 2025 00:49:48 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2BD0269345;\n\tSun, 24 Aug 2025 02:49:48 +0200 (CEST)", "from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com\n\t[IPv6:2a00:1450:4864:20::32b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E5EEB69328\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 24 Aug 2025 02:49:08 +0200 (CEST)", "by mail-wm1-x32b.google.com with SMTP id\n\t5b1f17b1804b1-45a1b0cd668so17315795e9.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 23 Aug 2025 17:49:08 -0700 (PDT)", "from [192.168.0.13] (188-141-3-146.dynamic.upc.ie. [188.141.3.146])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-45b4e1d530esm69347225e9.0.2025.08.23.17.49.07\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 23 Aug 2025 17:49:08 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"lvxMuKEd\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1755996548; x=1756601348;\n\tdarn=lists.libcamera.org; \n\th=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n\t:mime-version:subject:date:from:from:to:cc:subject:date:message-id\n\t:reply-to; bh=/20L6tlWwYRY8DTJuz1yDUOAn1XNk35+RBXylKD+rFA=;\n\tb=lvxMuKEdYpK2d7zYrz+HaPL/01LLKyFJmd3QE34H0Pz2br578gWe0SdxYk0O5bQvf+\n\t8nx0Y4l78U2+JZuEkhU9qeSkiCTTz4fIIq15mEPPdunyE87wxlJ0xESM37DcPrm/ykwM\n\tCFAarHtR2yTNnK5xlyIIaekR4/Z3lp3l9AHD84GDgAGhHG4OWI0lRVc8VEE0tCesORO3\n\tIs2o8IKQnOnI6PBxFSOfKxpzFtJmfxWaZESqKSnBpXh82cfdfX9YRWGIv0ucd1YEYC0c\n\t8oyl8qESgeUXU8xhv533ip9yNxi+DD6MD+WTgzF/taqsQ/SUi9OexD2jsJ8VrAuHEuiJ\n\tnuAw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1755996548; x=1756601348;\n\th=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n\t:mime-version:subject:date:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=/20L6tlWwYRY8DTJuz1yDUOAn1XNk35+RBXylKD+rFA=;\n\tb=FR9ZuaX4opDomwvvbnOC+1O2m7irhJuYsa8xcWUrHeqs/R4lCDgT8VjFF2fEYkJZHF\n\t+dI04JRv8hUYyeWEwsq86mCJrFoVEKz4GmNMvramXkFDT73+YVq4LdZuZ+kk33wS7joO\n\t//7vrIU6EjUCriykfcrQ0xhz4k68E/U0y6T6OZUhqSVNlnfeJmkcVeSvU9wuyd7qNxFB\n\tthjkIjPbE4a8ljE2924e3EcVcmMW9Z585+2z/O5RSLIQ2zzcWN0iyc+J+AS3KJBKAOoX\n\tWnSi/QRjFKxhvmd1hVNILE/lNP4WY2+MBfGrkwYbu5b9ZIPEcXglPRTdkomIobniB2yj\n\tkNng==", "X-Gm-Message-State": "AOJu0YzieL/67cxEXuC1XKDNbtm2M+sP34Ml7uYr1W0MsQbMKC7cB5rA\n\tce4a1nUv5i3uV5eTEx1IG0XrgGoViHX5BQL0zY7T+FMoacElwcZthZLl2/DBXtolmKM=", "X-Gm-Gg": "ASbGncvY5YlqVzhKh1uku9k081mcBsz6YPzFK4IYzVd2OKWiuan7h1wE/vB71Z4l3Ka\n\t2jQ+I7jpAfNwJGQcs/AXbYoWkXFX8Vxj/hSiqZnAHxg9tGMT3CWgPVl+FCQuPXqMLCY5UpH1pJC\n\tP3agd6AYkuHQxkMWyo15FXQUjxM/Dx39gj4lb9PGc6emdHjrl/JVy7ofjQItjUe79r5zyFXTdvj\n\tZrSiROiJ4/ZIMO7bL/KGKqnAY3w1kHNNuMxA783nB+nifaBMG+t0zMp1yZfbK99AbdoHHmzfafc\n\tr42ayHEvJMNCyTZcRDaT94SF0SHdf3U8yRTkJTuXU3liv+VHrpRFVJkbDNOCoN3EEX8sePoPt8n\n\tkhT30z6h1vErgy75tkv/vFPc+DkgAhTwTyZUFu/nhiEMiNFsoRZVPT9bdK03MpN650st3E+IWm+\n\tBNevfIL1e2jpMBd51eQgBB", "X-Google-Smtp-Source": "AGHT+IEoi3qCLFocZrehiwxSFAFr0fz3ssI2gs1Sct6GYXBtcHNxL2qMbpoPdXMBKPl9fJNXlOoLoQ==", "X-Received": "by 2002:a05:600c:4687:b0:45b:47e1:ef71 with SMTP id\n\t5b1f17b1804b1-45b517f8e7fmr62114425e9.36.1755996548467; \n\tSat, 23 Aug 2025 17:49:08 -0700 (PDT)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "Date": "Sun, 24 Aug 2025 01:48:47 +0100", "Subject": "[PATCH v2 35/37] libcamera: shaders: Rename bayer_8 to\n\tbayer_unpacked", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20250824-b4-v0-5-2-gpuisp-v2-a-v2-35-96f4576c814e@linaro.org>", "References": "<20250824-b4-v0-5-2-gpuisp-v2-a-v2-0-96f4576c814e@linaro.org>", "In-Reply-To": "<20250824-b4-v0-5-2-gpuisp-v2-a-v2-0-96f4576c814e@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>, \n\tMilan Zamazal <mzamazal@redhat.com>", "X-Mailer": "b4 0.14.2", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=5027;\n\ti=bryan.odonoghue@linaro.org; h=from:subject:message-id;\n\tbh=IVK2WYEtHjy9TXfF8vGpMJ8qVd56wUL9Oe+1YL++eaA=;\n\tb=owEBbQKS/ZANAwAKASJxO7Ohjcg6AcsmYgBoqmFir+ayVXY3yuTjtQp+DlZrar520kT73UOK7\n\txSgOLd4y5yJAjMEAAEKAB0WIQTmk/sqq6Nt4Rerb7QicTuzoY3IOgUCaKphYgAKCRAicTuzoY3I\n\tOgI4D/9zkgFS4p9cBsWKhNMw8Dzn7apX+wlYVaYlu3wqOlVqurWX11SZ7J4KL8h+7mqbtu+59dC\n\tGd0qfxg68P/m+ps6lS8ukaVmpxiy1Il0b5QGClmHOnys5XWV7imcw+blG/Y6FiMivufEkbD2H58\n\tUVcPdrPoNOd9LG/H75csDQk32vV+STaz4UnMY5DiKRaQ1/f66Gbv049JLduOMzeGHWuhlSOCYbN\n\tiDjRLsoFlvWNy7rmSTo/hy0DV9r/szA9sBnFaupWz+LJ8wGoO6dAUkQYHTEIoKWHrKeLOAazsRP\n\trnjiuzY8Hi6wZrIBYkURmAMsJWLLH5pyFco/oHEY/6QGvArEJlfLaBwG3VJQRwuxAx7dwHgne8V\n\t9GpLz/sdOD+qg2RAy6MFVN1ugrmtQF97cWx/djrX7y2HjsqIL6Az9GGrGTiVeVv6pFOst4xCBv2\n\tczVykFK7vjyDGgPdJOjgeLREsgRcctyj3Ecp4EjwpFr7dNnEk1p4K8FysHUi/L1BeGhMTxAgvsJ\n\tOsdiInvcRJwqXJrKQvcl7PqAhQYGv1TGKkMZN79lMscSQ/tkvqMyEs8aea/DIh1Dd4x4Ds/6Lsn\n\tq3Ro3MaI7lzJRmgGRpj4icEoBcwfFZ24x2zDM83MHhlXVHsjy2PEWVJjYc2DixzsULdHSfEcUma\n\tlI4T8Kaj2dC93mw==", "X-Developer-Key": "i=bryan.odonoghue@linaro.org; a=openpgp;\n\tfpr=E693FB2AABA36DE117AB6FB422713BB3A18DC83A", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Milan Zamazal <mzamazal@redhat.com>\n\nbayer_8.* shaders are now used for all unpacked sensor data formats,\nregardless of the pixel bit width. Let's rename the \"8-bit\" shaders to\navoid confusion.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n .../shaders/{bayer_8.frag => bayer_unpacked.frag} | 0\n .../shaders/{bayer_8.vert => bayer_unpacked.vert} | 0\n include/libcamera/internal/shaders/meson.build | 4 ++--\n src/apps/qcam/assets/shader/shaders.qrc | 4 ++--\n src/apps/qcam/viewfinder_gl.cpp | 16 ++++++++--------\n 5 files changed, 12 insertions(+), 12 deletions(-)", "diff": "diff --git a/include/libcamera/internal/shaders/bayer_8.frag b/include/libcamera/internal/shaders/bayer_unpacked.frag\nsimilarity index 100%\nrename from include/libcamera/internal/shaders/bayer_8.frag\nrename to include/libcamera/internal/shaders/bayer_unpacked.frag\ndiff --git a/include/libcamera/internal/shaders/bayer_8.vert b/include/libcamera/internal/shaders/bayer_unpacked.vert\nsimilarity index 100%\nrename from include/libcamera/internal/shaders/bayer_8.vert\nrename to include/libcamera/internal/shaders/bayer_unpacked.vert\ndiff --git a/include/libcamera/internal/shaders/meson.build b/include/libcamera/internal/shaders/meson.build\nindex 386b342d03b106e8303121ae9b84b2d2ee4e96d8..dd441a5776700f6ffc17eb9e73652d728aee02c9 100644\n--- a/include/libcamera/internal/shaders/meson.build\n+++ b/include/libcamera/internal/shaders/meson.build\n@@ -4,7 +4,7 @@\n # for the purposes of inclusion in OpenGL debayering\n shader_files = files([\n 'bayer_1x_packed.frag',\n- 'bayer_8.frag',\n- 'bayer_8.vert',\n+ 'bayer_unpacked.frag',\n+ 'bayer_unpacked.vert',\n 'identity.vert',\n ])\ndiff --git a/src/apps/qcam/assets/shader/shaders.qrc b/src/apps/qcam/assets/shader/shaders.qrc\nindex 04f9d7061b16d0bcd6c1fe1aceeaac97bf0fc295..32dfa51bfef01b3a80a4255fe83807f9b76cdbf5 100644\n--- a/src/apps/qcam/assets/shader/shaders.qrc\n+++ b/src/apps/qcam/assets/shader/shaders.qrc\n@@ -6,8 +6,8 @@\n \t<file>../../../../../include/libcamera/internal/shaders/YUV_3_planes.frag</file>\n \t<file>../../../../../include/libcamera/internal/shaders/YUV_packed.frag</file>\n \t<file>../../../../../include/libcamera/internal/shaders/bayer_1x_packed.frag</file>\n-\t<file>../../../../../include/libcamera/internal/shaders/bayer_8.frag</file>\n-\t<file>../../../../../include/libcamera/internal/shaders/bayer_8.vert</file>\n+\t<file>../../../../../include/libcamera/internal/shaders/bayer_unpacked.frag</file>\n+\t<file>../../../../../include/libcamera/internal/shaders/bayer_unpacked.vert</file>\n \t<file>../../../../../include/libcamera/internal/shaders/identity.vert</file>\n </qresource>\n </RCC>\ndiff --git a/src/apps/qcam/viewfinder_gl.cpp b/src/apps/qcam/viewfinder_gl.cpp\nindex 70f600650b7b925f10d2f699e6498a6cbd0a238a..95965ab7170e5ea951869dda83537ed0bca9978d 100644\n--- a/src/apps/qcam/viewfinder_gl.cpp\n+++ b/src/apps/qcam/viewfinder_gl.cpp\n@@ -235,29 +235,29 @@ bool ViewFinderGL::selectFormat(const libcamera::PixelFormat &format)\n \tcase libcamera::formats::SBGGR8:\n \t\tfirstRed_.setX(1.0);\n \t\tfirstRed_.setY(1.0);\n-\t\tvertexShaderFile_ = \":include/libcamera/internal/shaders/bayer_8.vert\";\n-\t\tfragmentShaderFile_ = \":include/libcamera/internal/shaders/bayer_8.frag\";\n+\t\tvertexShaderFile_ = \":include/libcamera/internal/shaders/bayer_unpacked.vert\";\n+\t\tfragmentShaderFile_ = \":include/libcamera/internal/shaders/bayer_unpacked.frag\";\n \t\ttextureMinMagFilters_ = GL_NEAREST;\n \t\tbreak;\n \tcase libcamera::formats::SGBRG8:\n \t\tfirstRed_.setX(0.0);\n \t\tfirstRed_.setY(1.0);\n-\t\tvertexShaderFile_ = \":include/libcamera/internal/shaders/bayer_8.vert\";\n-\t\tfragmentShaderFile_ = \":include/libcamera/internal/shaders/bayer_8.frag\";\n+\t\tvertexShaderFile_ = \":include/libcamera/internal/shaders/bayer_unpacked.vert\";\n+\t\tfragmentShaderFile_ = \":include/libcamera/internal/shaders/bayer_unpacked.frag\";\n \t\ttextureMinMagFilters_ = GL_NEAREST;\n \t\tbreak;\n \tcase libcamera::formats::SGRBG8:\n \t\tfirstRed_.setX(1.0);\n \t\tfirstRed_.setY(0.0);\n-\t\tvertexShaderFile_ = \":include/libcamera/internal/shaders/bayer_8.vert\";\n-\t\tfragmentShaderFile_ = \":include/libcamera/internal/shaders/bayer_8.frag\";\n+\t\tvertexShaderFile_ = \":include/libcamera/internal/shaders/bayer_unpacked.vert\";\n+\t\tfragmentShaderFile_ = \":include/libcamera/internal/shaders/bayer_unpacked.frag\";\n \t\ttextureMinMagFilters_ = GL_NEAREST;\n \t\tbreak;\n \tcase libcamera::formats::SRGGB8:\n \t\tfirstRed_.setX(0.0);\n \t\tfirstRed_.setY(0.0);\n-\t\tvertexShaderFile_ = \":include/libcamera/internal/shaders/bayer_8.vert\";\n-\t\tfragmentShaderFile_ = \":include/libcamera/internal/shaders/bayer_8.frag\";\n+\t\tvertexShaderFile_ = \":include/libcamera/internal/shaders/bayer_unpacked.vert\";\n+\t\tfragmentShaderFile_ = \":include/libcamera/internal/shaders/bayer_unpacked.frag\";\n \t\ttextureMinMagFilters_ = GL_NEAREST;\n \t\tbreak;\n \tcase libcamera::formats::SBGGR10_CSI2P:\n", "prefixes": [ "v2", "35/37" ] }