Patch Detail
Show a patch.
GET /api/1.1/patches/24210/?format=api
{ "id": 24210, "url": "https://patchwork.libcamera.org/api/1.1/patches/24210/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24210/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250824-b4-v0-5-2-gpuisp-v2-a-v2-27-96f4576c814e@linaro.org>", "date": "2025-08-24T00:48:39", "name": "[v2,27/37] libcamera: shaders: Use highp not mediump for float precision", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "1be27c382aa8a6cb48a4d14854ff0ed550331eb6", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/1.1/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24210/mbox/", "series": [ { "id": 5400, "url": "https://patchwork.libcamera.org/api/1.1/series/5400/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5400", "date": "2025-08-24T00:48:12", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5400/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24210/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24210/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0A2BCC32BB\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 24 Aug 2025 00:49:35 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7BD606932C;\n\tSun, 24 Aug 2025 02:49:34 +0200 (CEST)", "from mail-wm1-x336.google.com (mail-wm1-x336.google.com\n\t[IPv6:2a00:1450:4864:20::336])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B7E07692FB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 24 Aug 2025 02:49:00 +0200 (CEST)", "by mail-wm1-x336.google.com with SMTP id\n\t5b1f17b1804b1-45a1b0bd237so24685235e9.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 23 Aug 2025 17:49:00 -0700 (PDT)", "from [192.168.0.13] (188-141-3-146.dynamic.upc.ie. [188.141.3.146])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-45b4e1d530esm69347225e9.0.2025.08.23.17.48.59\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 23 Aug 2025 17:48:59 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"S5vMiQlX\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1755996540; x=1756601340;\n\tdarn=lists.libcamera.org; \n\th=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n\t:mime-version:subject:date:from:from:to:cc:subject:date:message-id\n\t:reply-to; bh=p+mSSXAM4EsMOfaffp1veBC/N4dTalrnPCw/wGGa18w=;\n\tb=S5vMiQlX0u6akXIFSDy5OvMFeUPt8pFBe6A11euDYm+K/fq3A+kRfw2/pl3U9D3L8H\n\tOpkxIvQpgNWGZIYvSUMO4VSI2CepmR/KFtuYEGc3YOLpxdUTeW1RorIjeonlqEdLBbvf\n\tX02xg2a+xyD1HxVl410NkXr1Eov9jYrGMvyHW2tXqujhZ8lp9OgXC+WAYH/QMn8CLBl/\n\t9e06hGq4IKd7IzoXDYQGbZg+weTuMedX0NiCqUpvAaWmnxexJGoHVPugNg83kMiq5Gk6\n\tPHFcBBa1E4sBE/ovpetmp0W0LoSdSnZ85nTpzTE2uQzL5N/idD66j6w40lO4ehvJ+8nD\n\tWpRw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1755996540; x=1756601340;\n\th=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n\t:mime-version:subject:date:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=p+mSSXAM4EsMOfaffp1veBC/N4dTalrnPCw/wGGa18w=;\n\tb=w0iChuKE1UzNdtGHRqxYTeD7u8GZGCDKshFwtRE/Hw+KZ3ZYsnadDqaHQJMdmTKzlj\n\tBocSZ0jOc3O0LwEV3dLvznTryQDL1KMvY5N2D1RHi17nPu/C2AmcX3h7rgMGa+cnscf4\n\tZcz98WDXQyP2f39n+E+5/+9fIfcWFj9F7Ar6PmPr91Pd77KczJAQSqwgn0KeSBAek/rP\n\tM6J91Mcc26+ynIA3oEWud0qcYNyjeYrtJhvk4HX10fIsIaZLVgbe7gukMJzaV8T4KX5Z\n\tBQUWE52h4tA7vprMyeQgTqznCcRUfzqo/Atpc0Ar6Rdj4jT/dcWxHjSFYH3/ClkLP3Pk\n\t1tig==", "X-Gm-Message-State": "AOJu0YyrCX1+kiO8iZyMGPrNH6zSOySc3ABUvsz1sxB7efgCkAa5ufDp\n\tttJu20S8Pk1OdHDc+KxwIgZugMqtGziYPHtbtodaHPn8u6sQNkasWKiP5eU8Gdb8/nNVxuPYTDI\n\ttFLExdyQ=", "X-Gm-Gg": "ASbGncu5XznPRM8i2DNUjenZdNoLJL/pv00+T25irrzHMsDAXJ1v7+JpleXww/KzHQo\n\tqFIwMe1i+kWbRv04Hi6yw/sOX+e8crI0BUPoWOe6InHpvqN+4/gQCIvOQXcHVyXEiESdN+QKyNX\n\t6FpDvE23RzVQ5EHeYToeiX4/wymq6mg+guuwNEXPA+QnNz01JcETwxwrFfMo8EAB2p31Tg8iIhm\n\tzHVsP1xQYE4/yZW1eCwmVWI5oXVc/tfvj4ySgm3YFgCpP1fzS1L8O6/OZGLjdeq+0RZ73bJQZlK\n\t9zDd13W4I5yHbtY43evIAFvEjy2RwRs9bjn+3tv81HFZVVywQ1z8/f21MfY6OtcWj8WJRZ6QbzP\n\tNVex6FuxrPHiDWPL3JY+QaPd9XXzq9vpCFsN6IfzyTwsTXuc5DbLNXbfQJ1MydQbWfM6BRfooco\n\tSCr6FlVwPKF1bLy33yEnHp", "X-Google-Smtp-Source": "AGHT+IEHWEcVZwGDKhKzapQqG3M6oOe/KsEYo6qMrWBtRKgREkilTufq3lDJoKFrl9/GbCJb35iavw==", "X-Received": "by 2002:a05:600c:b95:b0:43d:fa59:af97 with SMTP id\n\t5b1f17b1804b1-45b517d2f5cmr57733165e9.32.1755996540194; \n\tSat, 23 Aug 2025 17:49:00 -0700 (PDT)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "Date": "Sun, 24 Aug 2025 01:48:39 +0100", "Subject": "[PATCH v2 27/37] libcamera: shaders: Use highp not mediump for\n\tfloat precision", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20250824-b4-v0-5-2-gpuisp-v2-a-v2-27-96f4576c814e@linaro.org>", "References": "<20250824-b4-v0-5-2-gpuisp-v2-a-v2-0-96f4576c814e@linaro.org>", "In-Reply-To": "<20250824-b4-v0-5-2-gpuisp-v2-a-v2-0-96f4576c814e@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "X-Mailer": "b4 0.14.2", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=3421;\n\ti=bryan.odonoghue@linaro.org; h=from:subject:message-id;\n\tbh=mArKPdK06uVUTR5pGsztmhyPt1VhLbfZlNX0eWU6g3U=;\n\tb=owEBbQKS/ZANAwAKASJxO7Ohjcg6AcsmYgBoqmFhAAApkDQ2Iq7sjC20UqrAl0CpY2bu9CBIf\n\tSpEAjYbSseJAjMEAAEKAB0WIQTmk/sqq6Nt4Rerb7QicTuzoY3IOgUCaKphYQAKCRAicTuzoY3I\n\tOqJ2D/wPUOlHPqtIuPe674Q1VZtn9YpOFdNL7unOSqZyk83ZyFHtbW6pILTeMsFphHDo9ueoEwa\n\tUIghC5k8vnJfqFe7v3arnrCt07WTHFHFUgh7PDLwcGQCw4Wof8HlWIXfEBP+J0yw++v6J3sq4Pc\n\tj23E6N5l6AjF1kXc6tVIknf1arS+s3GPDDJmBbU73lKTIHj51wffBllppZbzHHDexweA+dtCOs6\n\txmqx/XAILtcLsecHaZUl3tq91nDrhZqSSnOzjID4l2fvpKPt5vlrFarn0UCxHCNEZ9rBKfjJt2U\n\t9R/w5JuODE+ZKoq9mRsEFcRGk4L6vffSapygMA7NjNjj+hFaNS0mDi3W1EF6ZywUnt/le/95O8B\n\thKstPO00gcRtxJglOBsyv5Z7S/XfUqxrmITYHmIM/6crv+3QjtWgKKbDWw+KgT55pHVmWaufkwq\n\tP31RD42jpI1kTD2CBcqkOyw2qpfOs/79UMLNCApUXPD45pLxIw6pUqlprr0ZnCsFfWZwKRftoPf\n\ty9MwQEifoEF1Pev0V+1sxcUgW/7WKfn52RyHMPXD0Z3YMC9OkT+ZePbjLun3nZwjdJ9FxMdb673\n\tJIcuPsX/58YEYkn/NSGyrOwKl95fdDfgBQgHegCITEyMC4TIOhFZL8hNIOM7hJ+4MOAw7+wovkE\n\tKzDPEWFVEUPqJRw==", "X-Developer-Key": "i=bryan.odonoghue@linaro.org; a=openpgp;\n\tfpr=E693FB2AABA36DE117AB6FB422713BB3A18DC83A", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "We get better sample resolution with highp instead of mediump.\n\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n include/libcamera/internal/shaders/RGB.frag | 2 +-\n include/libcamera/internal/shaders/YUV_2_planes.frag | 2 +-\n include/libcamera/internal/shaders/YUV_3_planes.frag | 2 +-\n include/libcamera/internal/shaders/YUV_packed.frag | 2 +-\n include/libcamera/internal/shaders/bayer_1x_packed.frag | 2 +-\n include/libcamera/internal/shaders/bayer_8.frag | 2 +-\n 6 files changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/include/libcamera/internal/shaders/RGB.frag b/include/libcamera/internal/shaders/RGB.frag\nindex 4c374ac980958281506771d30584dc56f10735bb..7243958941cfed1e5e7f203173864e46ac07fed3 100644\n--- a/include/libcamera/internal/shaders/RGB.frag\n+++ b/include/libcamera/internal/shaders/RGB.frag\n@@ -6,7 +6,7 @@\n */\n \n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n varying vec2 textureOut;\ndiff --git a/include/libcamera/internal/shaders/YUV_2_planes.frag b/include/libcamera/internal/shaders/YUV_2_planes.frag\nindex 1d5d1206248f3a53e5e0c93c3a3ce6eba73e4437..d286f1179f7b998dd2f9f0406a68c5b45cccddce 100644\n--- a/include/libcamera/internal/shaders/YUV_2_planes.frag\n+++ b/include/libcamera/internal/shaders/YUV_2_planes.frag\n@@ -6,7 +6,7 @@\n */\n \n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n varying vec2 textureOut;\ndiff --git a/include/libcamera/internal/shaders/YUV_3_planes.frag b/include/libcamera/internal/shaders/YUV_3_planes.frag\nindex 8f788e90a6f86a584673c5706caaaf2bca25c97a..8e3e0b4a57039142d9741a0be8a6d71475d134a5 100644\n--- a/include/libcamera/internal/shaders/YUV_3_planes.frag\n+++ b/include/libcamera/internal/shaders/YUV_3_planes.frag\n@@ -6,7 +6,7 @@\n */\n \n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n varying vec2 textureOut;\ndiff --git a/include/libcamera/internal/shaders/YUV_packed.frag b/include/libcamera/internal/shaders/YUV_packed.frag\nindex b9ef9d41beaebdbeb04901b51d77696e28f7c6b7..3c9e3e397ada3eea7e3e31f12559e2fd92bb5026 100644\n--- a/include/libcamera/internal/shaders/YUV_packed.frag\n+++ b/include/libcamera/internal/shaders/YUV_packed.frag\n@@ -6,7 +6,7 @@\n */\n \n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n varying vec2 textureOut;\ndiff --git a/include/libcamera/internal/shaders/bayer_1x_packed.frag b/include/libcamera/internal/shaders/bayer_1x_packed.frag\nindex f53f5575802628d79c03c83a0565cee2d51429bd..19b13ad08b3a71e408774dbb8e75ca4e22d9ba8e 100644\n--- a/include/libcamera/internal/shaders/bayer_1x_packed.frag\n+++ b/include/libcamera/internal/shaders/bayer_1x_packed.frag\n@@ -20,7 +20,7 @@\n */\n \n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n /*\ndiff --git a/include/libcamera/internal/shaders/bayer_8.frag b/include/libcamera/internal/shaders/bayer_8.frag\nindex 7e35ca88e7ff516e81b751382e4e3e463c2c36fa..aa7a1b00436ae15d2ed6af7d666441d20db6bb0b 100644\n--- a/include/libcamera/internal/shaders/bayer_8.frag\n+++ b/include/libcamera/internal/shaders/bayer_8.frag\n@@ -16,7 +16,7 @@ Copyright (C) 2021, Linaro\n \n //Pixel Shader\n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n /** Monochrome RGBA or GL_LUMINANCE Bayer encoded texture.*/\n", "prefixes": [ "v2", "27/37" ] }