Patch Detail
Show a patch.
GET /api/1.1/patches/24191/?format=api
{ "id": 24191, "url": "https://patchwork.libcamera.org/api/1.1/patches/24191/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24191/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250824-b4-v0-5-2-gpuisp-v2-a-v2-8-96f4576c814e@linaro.org>", "date": "2025-08-24T00:48:20", "name": "[v2,08/37] libcamera: software_isp: Move Bayer params init from DebayerCpu to Debayer", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "ed73c2ab93a680fb80d46c61807263134fe88667", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/1.1/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24191/mbox/", "series": [ { "id": 5400, "url": "https://patchwork.libcamera.org/api/1.1/series/5400/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5400", "date": "2025-08-24T00:48:12", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5400/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24191/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24191/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 02C62C332A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 24 Aug 2025 00:48:55 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AEFCA69312;\n\tSun, 24 Aug 2025 02:48:54 +0200 (CEST)", "from mail-wm1-x334.google.com (mail-wm1-x334.google.com\n\t[IPv6:2a00:1450:4864:20::334])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C8AA1692F9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 24 Aug 2025 02:48:43 +0200 (CEST)", "by mail-wm1-x334.google.com with SMTP id\n\t5b1f17b1804b1-45a20c51c40so26179505e9.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 23 Aug 2025 17:48:43 -0700 (PDT)", "from [192.168.0.13] (188-141-3-146.dynamic.upc.ie. [188.141.3.146])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-45b4e1d530esm69347225e9.0.2025.08.23.17.48.42\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 23 Aug 2025 17:48:42 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"HUFSV1Hh\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1755996523; x=1756601323;\n\tdarn=lists.libcamera.org; \n\th=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n\t:mime-version:subject:date:from:from:to:cc:subject:date:message-id\n\t:reply-to; bh=tLEHqivrWJMjpVCUINDZ9MbPl02eXZ0jb9Y1qP3OEYE=;\n\tb=HUFSV1HhwK4xfQz8YKD10iJBlDmJEeCZCA7uu1qXdrykBvCJ6e9jUmRFhFU9mzQBxx\n\tPwX/MghLJqRHdYpj8W8g5/9JHkcd77EOCq43HYObmAYZ0x/djztAy1JXzpB+XsGy9635\n\td4ViaiUU4CTdwlHCSUm/i9xjxYWje03BQvonZ7jHEmC+aoeJB32/ZqlDunVxfSL6UEPb\n\tiM6uct3wgHw5/QTtpcrD6NdX09ivInTGa6aby1KkZFD3j07nNgDlHYlvIwc2RtaJO1pw\n\tqjfrepmtuKp44yvNVzzsn4dVXXr0IaT3wf8fxYpsupEOb+uiuXvJE8nTEFmhMYmm3ksw\n\toTmQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1755996523; x=1756601323;\n\th=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n\t:mime-version:subject:date:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=tLEHqivrWJMjpVCUINDZ9MbPl02eXZ0jb9Y1qP3OEYE=;\n\tb=cxxtPzqULUU+byUoIQ3IRzJ7QrabBcJFNBTNwqw6YPHpKjw260G7j6GbADUzc18F3n\n\trFGRRHy4f1TBalzeQq0+IOTur0qJ9Q6p13FVFD0gAkQr2hXcsG77cJxtQp2gHJAsCvUc\n\tytOFTEyGl+nwOkopdn8bzuWVnumFncXemKqbdrwWCt2bScYNq5/Bh3h9lQ9ENE8jltR6\n\tR2lcgxAqzKciKepQBMiDzIlUZdMap+x3GLAjEQtPF9KfW+k+mJAoNT6JTDz1+nNwJY3U\n\tj8t65v0nojyf9pDq2OQ91yvEuL6KUx2osTjZ7JZuqCG1ExCONiUFLDMyVc5h9sN9r5oL\n\t94Lg==", "X-Gm-Message-State": "AOJu0YxD/0Zgrn/87u5NFAdEXx9oOSy6jz5RKkNMz6Opw0ySOCBIbReV\n\tc8kS3HBbVwkIlCDixy2IkUp8Yw5hYmfGwYOeQ2ddM01mx+sjX8L3NF0IDuMEA7BMOJ8RyB6negJ\n\tCnsujNI0=", "X-Gm-Gg": "ASbGncuH9vKPKxGgWZteBrWkeVijNlM0mUEKCwbrp/SRsX0sCjYTkLQ57OFpjwyx777\n\tqfMZKBrwiKmmdk9u/Bp4cr2D6ibpbX+BzEuSxFv2rD7Yi90tf7ze5nVwDf5CW16Y/HInFeTuN3u\n\txeWNtFL96dN3W5e6HaVI0jr+DXkN+UKmI18JsG8xAYslI2s/TBHLIlYyqopwcZMwG2iQsqF6Cp5\n\tYFM/kyA0VpPUJq5qRmxWM1Z6xTjx2RJHx3D2V0nfhmbFKsXVK6j/4SfDfxV2u3DI7hfrbqFwQEn\n\tcp8k8n4EI8tvNEfG/p4kW8WRa+HctyF0gTm9F1hJaUTlR9YwwkhOJq+RSUF3JlSCWvrQ5S6qPpC\n\tIQEqgiczDeKjIs70cNOSdyjNNbkTBJCzTdV6hI6+gd3zTHfFX3cZCyul7Cy7k3W/mYHndD4FFzc\n\tmymJNGVnwh+lBFmXJAvSPm", "X-Google-Smtp-Source": "AGHT+IFjptaJdN2vrT2gFU5/REGe/9B7ex2dmWlVztgCLktnMAyS3lx+vQVeT7YHQqJp5lePure0YQ==", "X-Received": "by 2002:a05:600c:3147:b0:459:d46a:ee3d with SMTP id\n\t5b1f17b1804b1-45b51798f71mr61017965e9.2.1755996523366; \n\tSat, 23 Aug 2025 17:48:43 -0700 (PDT)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "Date": "Sun, 24 Aug 2025 01:48:20 +0100", "Subject": "[PATCH v2 08/37] libcamera: software_isp: Move Bayer params init\n\tfrom DebayerCpu to Debayer", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20250824-b4-v0-5-2-gpuisp-v2-a-v2-8-96f4576c814e@linaro.org>", "References": "<20250824-b4-v0-5-2-gpuisp-v2-a-v2-0-96f4576c814e@linaro.org>", "In-Reply-To": "<20250824-b4-v0-5-2-gpuisp-v2-a-v2-0-96f4576c814e@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "X-Mailer": "b4 0.14.2", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=2546;\n\ti=bryan.odonoghue@linaro.org; h=from:subject:message-id;\n\tbh=9pqT/2tcr+vuIs31tYBPjv6bibSNjZwn3wDmv+0JjMQ=;\n\tb=owEBbQKS/ZANAwAKASJxO7Ohjcg6AcsmYgBoqmFds/QdokyC9dde07KRjCYeifDjtt6/oK5uA\n\twv5RLwHc1qJAjMEAAEKAB0WIQTmk/sqq6Nt4Rerb7QicTuzoY3IOgUCaKphXQAKCRAicTuzoY3I\n\tOqi2EAC0eVG4tTAR1sUyZJaEHeUb8lT7UYkbjYfGGxputIm/uK8MlIONuNWimkbaftRUeIMoe+v\n\toqVQgqfb71W8m71pShpXJHgm9qj0gOdlVMubR6YD4NE5qrySBBWAxZ83oteaZvfjQEYXxygaXYI\n\t/5KLfctJaj6yxlFR+V5/sm2y9jYVXqc9ArHGbTRxX47xNwwea7H1AbYq5Rd92G9AvjxLgoUtq7p\n\tSYo+YURFHo4+VcFg7o7GloMRt2wkguxqTy/j6KI1bV28DoiOLqQ22enev/tX14Gp0m2CKZwYsl7\n\tL5O4QBboMIpMnAFSHhG78TGKPOa1G9q+j+qjOQ9ug8lZ0lYHbZqaFDHXxNuaqJORGWBRRfVZAH1\n\tSLTWBp7hxpy1iNABysjYyESNThUdaAZ5wI3Cr7xAa7Dr6nFt29IV8YpIR5p+vOouT/dM9LGwa0T\n\toC55b/qckv9cstf3Nq5RUDjBZTwStUJv4HPoctka9WfCmFDry+J4UZG6I9un8F77CXfkJqUDX9X\n\tW4QC/dWzhpsODL2fGRLBICDbXRiKJbccyOhtYPmMV2Z0lKRfycnvCP2Bd5NX2BE/VV7rPzBoGyT\n\tIxsxkOYjW9TTqireH3r4MT3B1bFpMSLtw00JIZk+MI17c5p/lKtcg4bxD8IW3EH0VAAZoPQk2mG\n\turi1q1tWXqKXeCw==", "X-Developer-Key": "i=bryan.odonoghue@linaro.org; a=openpgp;\n\tfpr=E693FB2AABA36DE117AB6FB422713BB3A18DC83A", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Move the initialisation of Bayer params and CCM to a new constructor in the\nDebayer class.\n\nEnsure we call the base class constructor from DebayerCpu's constructor in\nthe expected constructor order Debayer then DebayerCpu.\n\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/software_isp/debayer.cpp | 11 +++++++++++\n src/libcamera/software_isp/debayer.h | 1 +\n src/libcamera/software_isp/debayer_cpu.cpp | 8 --------\n 3 files changed, 12 insertions(+), 8 deletions(-)", "diff": "diff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp\nindex e9e18c488489c776ee93886184113406f39e6685..29fdcbbfd4eba4a23c520b22784bf003f22a93f4 100644\n--- a/src/libcamera/software_isp/debayer.cpp\n+++ b/src/libcamera/software_isp/debayer.cpp\n@@ -103,6 +103,17 @@ namespace libcamera {\n \n LOG_DEFINE_CATEGORY(Debayer)\n \n+Debayer::Debayer()\n+{\n+\t/* Initialize color lookup tables */\n+\tfor (unsigned int i = 0; i < DebayerParams::kRGBLookupSize; i++) {\n+\t\tred_[i] = green_[i] = blue_[i] = i;\n+\t\tredCcm_[i] = { static_cast<int16_t>(i), 0, 0 };\n+\t\tgreenCcm_[i] = { 0, static_cast<int16_t>(i), 0 };\n+\t\tblueCcm_[i] = { 0, 0, static_cast<int16_t>(i) };\n+\t}\n+}\n+\n Debayer::~Debayer()\n {\n }\ndiff --git a/src/libcamera/software_isp/debayer.h b/src/libcamera/software_isp/debayer.h\nindex 45da822a2173070fd1b99bbfed4c0fdeaa1a88c6..01b6e916f2a7199c592abd8a57ef549eaf388a8b 100644\n--- a/src/libcamera/software_isp/debayer.h\n+++ b/src/libcamera/software_isp/debayer.h\n@@ -32,6 +32,7 @@ LOG_DECLARE_CATEGORY(Debayer)\n class Debayer : public Object\n {\n public:\n+\tDebayer();\n \tvirtual ~Debayer() = 0;\n \n \tvirtual int configure(const StreamConfiguration &inputCfg,\ndiff --git a/src/libcamera/software_isp/debayer_cpu.cpp b/src/libcamera/software_isp/debayer_cpu.cpp\nindex 8d30bf4a2115137939f01378e8af594170d4d459..408ce2baa5e8a23902cbf0ca2b9ea87e73b4e882 100644\n--- a/src/libcamera/software_isp/debayer_cpu.cpp\n+++ b/src/libcamera/software_isp/debayer_cpu.cpp\n@@ -51,14 +51,6 @@ DebayerCpu::DebayerCpu(std::unique_ptr<SwStatsCpu> stats)\n \t * future.\n \t */\n \tenableInputMemcpy_ = true;\n-\n-\t/* Initialize color lookup tables */\n-\tfor (unsigned int i = 0; i < DebayerParams::kRGBLookupSize; i++) {\n-\t\tred_[i] = green_[i] = blue_[i] = i;\n-\t\tredCcm_[i] = { static_cast<int16_t>(i), 0, 0 };\n-\t\tgreenCcm_[i] = { 0, static_cast<int16_t>(i), 0 };\n-\t\tblueCcm_[i] = { 0, 0, static_cast<int16_t>(i) };\n-\t}\n }\n \n DebayerCpu::~DebayerCpu() = default;\n", "prefixes": [ "v2", "08/37" ] }